Ugly type safety #1548
Merged
Ugly type safety #1548
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blidd-google
added a commit
that referenced
this pull request
Apr 4, 2024
* add changelog * update docstrings * export authtype and add comment * separate out event type with auth context * Ugly type safety (#1548) * consolidate make firestore event fns and simplify typings --------- Co-authored-by: Brian Li <[email protected]> * add oninit tests --------- Co-authored-by: Thomas Bouldin <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here's the best I could do to make everything type safe without adding any extra
any. Personally, I'm not sure if I care to have this be so complicated or if we should have moreanys as well. Just if you do choose to shirk type safety, please make sure fields that shouldn't be defined in the non-auth event types don't have the extra fields.Should possibly extend test for make*Event to test fields other than data.