Skip to content

Fix: get the app when fetching named firestore #1562

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 3, 2024
Merged

Fix: get the app when fetching named firestore #1562

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
0239caf
get the app when fetching named firestore
colerogers May 3, 2024
4b64bc3
add changelog
colerogers May 3, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
get the app when fetching named firestore
  • Loading branch information
@colerogers
colerogers committed May 3, 2024
commit 0239caf1884f6e5bd4d123909357e4c656ac1018
8 changes: 4 additions & 4 deletions src/common/providers/firestore.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -54,7 +54,7 @@ function _getValueProto(data: any, resource: string, valueFieldName: string) {
/** @internal */
export function createSnapshotFromProtobuf(data: Uint8Array, path: string, databaseId: string) {
if (!firestoreInstance) {
firestoreInstance = firestore.getFirestore(databaseId);
firestoreInstance = firestore.getFirestore(getApp(), databaseId);
}
try {
const dataBuffer = Buffer.from(data);
Expand All @@ -74,7 +74,7 @@ export function createBeforeSnapshotFromProtobuf(
databaseId: string
) {
if (!firestoreInstance) {
firestoreInstance = firestore.getFirestore(databaseId);
firestoreInstance = firestore.getFirestore(getApp(), databaseId);
}
try {
const dataBuffer = Buffer.from(data);
Expand All @@ -97,7 +97,7 @@ export function createSnapshotFromJson(
) {
if (!firestoreInstance) {
firestoreInstance = databaseId
? firestore.getFirestore(databaseId)
? firestore.getFirestore(getApp(), databaseId)
: firestore.getFirestore(getApp());
}
const valueProto = _getValueProto(data, source, "value");
Expand All @@ -122,7 +122,7 @@ export function createBeforeSnapshotFromJson(
) {
if (!firestoreInstance) {
firestoreInstance = databaseId
? firestore.getFirestore(databaseId)
? firestore.getFirestore(getApp(), databaseId)
: firestore.getFirestore(getApp());
}

Expand Down