Skip to content

Revert "Update https types in function builder" #376

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jan 9, 2019
Merged

Revert "Update https types in function builder" #376

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Revert "Update https types in function builder"
  • Loading branch information
@kevinajian
kevinajian authored Jan 9, 2019
commit 237557ddf1f067e5171b1fcd8e4e1eac45702f42
6 changes: 3 additions & 3 deletions src/function-builder.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@ import * as https from './providers/https';
import * as pubsub from './providers/pubsub';
import * as remoteConfig from './providers/remoteConfig';
import * as storage from './providers/storage';
import { CloudFunction, EventContext } from './cloud-functions';
import { CloudFunction, EventContext, HttpsFunction } from './cloud-functions';

/**
* Configure the regions that the function is deployed to.
Expand Down Expand Up @@ -146,7 +146,7 @@ export class FunctionBuilder {
*/
onRequest: (
handler: (req: express.Request, resp: express.Response) => void
) => https._onRequestWithOpts(handler, this.options),
) => https._onRequestWithOpts(handler, this.options) as HttpsFunction,
/**
* Declares a callable method for clients to call using a Firebase SDK.
* @param handler A method that takes a data and context and returns a value.
Expand All @@ -156,7 +156,7 @@ export class FunctionBuilder {
data: any,
context: https.CallableContext
) => any | Promise<any>
) => https._onCallWithOpts(handler, this.options),
) => https._onCallWithOpts(handler, this.options) as HttpsFunction,
};
}

Expand Down