Skip to content

Conversation

@merlinnot
Copy link
Contributor

Description

This PR updates all dependencies to latest versions, there are no breaking changes - some files are reformatted by Prettier.

Code sample

Not relevant.

@merlinnot
Copy link
Contributor Author

@thechenky Unfortunately I don't have permissions to assign you as a reviewer, as requested in the previous PR.

@thechenky thechenky self-requested a review July 3, 2019 16:11
Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updates are nice. But all of these dependencies have a ^ so should automatically pull in all patch and minor updates if I'm understanding correctly. What is the benefit of updating them manually?

@thechenky
Copy link
Contributor

I'm sure you're on it already, but in case you forget, remove those formatted files since you have them in the other PR.

@merlinnot merlinnot force-pushed the update-dependencies branch from 193e55f to 4686a90 Compare July 3, 2019 18:34
@merlinnot
Copy link
Contributor Author

Thanks, I removed formatted files.

Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thechenky
Copy link
Contributor

I'll merge this in when the tests complete.

@thechenky thechenky merged commit 340bc77 into firebase:master Jul 3, 2019
@merlinnot merlinnot deleted the update-dependencies branch July 3, 2019 21:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants