Skip to content

Conversation

@merlinnot
Copy link
Contributor

@merlinnot merlinnot commented Jul 3, 2019

Description

This PR introduces two new scripts: format:fix and lint:fix, which runs Prettier and TSLint with autofixers. It also changes a behaviour of format to report issues. Both are now run in the CI, in parallel with tests.

I fixed all linter errors, so the CI passes. All changes in source files are autofixes made by TSLint.

Code sample

Not relevant.

@merlinnot merlinnot marked this pull request as ready for review July 3, 2019 15:19
@merlinnot
Copy link
Contributor Author

@thechenky Unfortunately I don't have permissions to assign you as a reviewer, as requested in the previous PR.

@merlinnot merlinnot force-pushed the travis-lint-format branch from d4a9378 to f42dd5f Compare July 3, 2019 17:17
@thechenky
Copy link
Contributor

Tests are failing for me here:

  276 passing (510ms)
  2 failing

  1) Database Functions
       process.env.FIREBASE_CONFIG not set
         should throw when trigger is accessed:
     AssertionError: expected [Function] to throw Error
      at Context.it (spec/providers/database.spec.ts:418:17)

  2) Storage Functions
       process.env.FIREBASE_CONFIG not set
         should throw when trigger is accessed:
     AssertionError: expected [Function] to throw Error
      at Context.it (spec/providers/storage.spec.ts:550:78)

@merlinnot
Copy link
Contributor Author

Tests are passing for me locally and in the CI (it's not fully done yet, but tests passed already). Maybe you could try again after running npm install?

@merlinnot
Copy link
Contributor Author

@thechenky The CI is now green, all steps.

@thechenky
Copy link
Contributor

@merlinnot yeah, something weird is happening for me - they're not passing even on master on your fork which is synced with master on this repo, but passing on master on this repo. Should be okay, I see the CI is green too.

Copy link
Contributor

@thechenky thechenky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@thechenky thechenky merged commit 9694dca into firebase:master Jul 3, 2019
@merlinnot merlinnot deleted the travis-lint-format branch July 3, 2019 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants