Skip to content

[Firebase AI] Make GenerativeAIRequest.Response Sendable #14947

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Jun 9, 2025
Merged

[Firebase AI] Make GenerativeAIRequest.Response Sendable #14947

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
930847b
[Firebase AI] Make `GenerativeAIRequest.Response` `Sendable`
andrewheard Jun 9, 2025
cb0ead3
Add explicit `Sendable` conformance to remaining responses
andrewheard Jun 9, 2025
df1d215
Make Imagen image types `Sendable`
andrewheard Jun 9, 2025
648fc60
Add CHANGELOG entry
andrewheard Jun 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions FirebaseAI/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,6 @@
# Unreleased
- [fixed] Fixed `Sendable` warnings introduced in the Xcode 26 beta. (#14947)

# 11.13.0
- [feature] Initial release of the Firebase AI Logic SDK (`FirebaseAI`). This
SDK *replaces* the previous Vertex AI in Firebase SDK (`FirebaseVertexAI`) to
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/GenerativeAIRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import Foundation

@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
protocol GenerativeAIRequest: Sendable, Encodable {
associatedtype Response: Decodable
associatedtype Response: Sendable, Decodable

var url: URL { get }

Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/Types/Internal/Imagen/ImagenGCSImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,7 +18,7 @@ import Foundation
///
/// TODO(#14451): Make this `public` and move to the `Public` directory when ready.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
struct ImagenGCSImage {
struct ImagenGCSImage: Sendable {
/// The IANA standard MIME type of the image file; either `"image/png"` or `"image/jpeg"`.
///
/// > Note: To request a different format, set ``ImagenGenerationConfig/imageFormat`` in
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/Types/Internal/Requests/CountTokensRequest.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,7 +38,7 @@ extension CountTokensRequest: GenerativeAIRequest {

/// The model's response to a count tokens request.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
public struct CountTokensResponse {
public struct CountTokensResponse: Sendable {
/// The total number of tokens in the input given to the model as a prompt.
public let totalTokens: Int

Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/Types/Public/Imagen/ImagenGenerationResponse.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -23,7 +23,7 @@ import Foundation
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
// TODO(#14451): Re-add "- ``ImagenModel/generateImages(prompt:gcsURI:)`` where `T` is
// ``ImagenGCSImage``" in the DocC above.
public struct ImagenGenerationResponse<T> {
public struct ImagenGenerationResponse<T>: Sendable where T: Sendable {
/// The images generated by Imagen; see ``ImagenInlineImage``.
///
/// > Important: The number of images generated may be fewer than the number requested if one or
Expand Down
2 changes: 1 addition & 1 deletion FirebaseAI/Sources/Types/Public/Imagen/ImagenInlineImage.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@ import Foundation

/// An image generated by Imagen, represented as inline data.
@available(iOS 15.0, macOS 12.0, macCatalyst 15.0, tvOS 15.0, watchOS 8.0, *)
public struct ImagenInlineImage {
public struct ImagenInlineImage: Sendable {
/// The IANA standard MIME type of the image file; either `"image/png"` or `"image/jpeg"`.
///
/// > Note: To request a different format, set ``ImagenGenerationConfig/imageFormat`` in
Expand Down
Loading