Skip to content

[Auth] Remove deprecated string-based provider ID APIs #15037

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ncooke3 merged 3 commits into from
Jun 24, 2025
Merged

[Auth] Remove deprecated string-based provider ID APIs #15037

Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1d8cda0
[Auth] Remove deprecated string-based provider ID APIs
ncooke3 Jun 24, 2025
7195fc7
ci
ncooke3 Jun 24, 2025
38c1a62
Merge branch 'main' into nc/provider-deprecations
ncooke3 Jun 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
ci
  • Loading branch information
@ncooke3
ncooke3 committed Jun 24, 2025
commit 7195fc703a0a9159c1b2611d02ba30f0838e0939
10 changes: 0 additions & 10 deletions FirebaseAuth/Tests/Unit/SwiftAPI.swift
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -475,34 +475,24 @@ class AuthAPI_hOnlyTests: XCTestCase {
func FIROAuthProvider_h() {
let _: (String, Auth) -> OAuthProvider = OAuthProvider.init(providerID:auth:)
let _: (AuthProviderID, Auth) -> OAuthProvider = OAuthProvider.init(providerID:auth:)
let _: (String) -> OAuthProvider = OAuthProvider.provider(providerID:)
let _: (String, Auth) -> OAuthProvider = OAuthProvider.provider(providerID:auth:)
let _: (AuthProviderID) -> OAuthProvider = OAuthProvider.provider(providerID:)
let _: (AuthProviderID, Auth) -> OAuthProvider = OAuthProvider.provider(providerID:auth:)
// `auth` defaults to `nil`
let provider = OAuthProvider(providerID: "id")
let _: String = provider.providerID
#if os(iOS)
let _: (String, String, String?) -> OAuthCredential =
OAuthProvider.credential(withProviderID:idToken:accessToken:)
let _: (AuthProviderID, String, String?) -> OAuthCredential =
OAuthProvider.credential(providerID:idToken:accessToken:)
// `accessToken` defaults to `nil`
let _: OAuthCredential =
OAuthProvider.credential(providerID: .apple, idToken: "")
let _: (String, String) -> OAuthCredential =
OAuthProvider.credential(withProviderID:accessToken:)
let _: (AuthProviderID, String) -> OAuthCredential = OAuthProvider
.credential(providerID:accessToken:)
let _: (String, String, String, String) -> OAuthCredential =
OAuthProvider.credential(withProviderID:idToken:rawNonce:accessToken:)
let _: (AuthProviderID, String, String, String?) -> OAuthCredential =
OAuthProvider.credential(providerID:idToken:rawNonce:accessToken:)
// `accessToken` defaults to `nil`
let _: OAuthCredential =
OAuthProvider.credential(providerID: .apple, idToken: "", rawNonce: "")
let _: (String, String, String) -> OAuthCredential =
OAuthProvider.credential(withProviderID:idToken:rawNonce:)

provider.getCredentialWith(provider as? AuthUIDelegate) { credential, error in
}
Expand Down