Skip to content

[Infra] Fix build warning in performance tests #15063

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jul 3, 2025
Merged

[Infra] Fix build warning in performance tests #15063

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8f7e801
Fix various build warnings across modules
google-labs-jules[bot] Jul 2, 2025
484f528
Fixes
ncooke3 Jul 2, 2025
2712d08
revert
ncooke3 Jul 3, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion FirebasePerformance/Tests/Unit/Common/FPRDiagnosticsTest.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -80,7 +80,9 @@ - (void)testFPRAssertSpeed {

/** Tests that FPRAssert actually asserts (when NS_BLOCK_ASSERTIONS=0|undefined). */
- (void)testFPRAssert {
XCTAssertThrows(FPRAssert(NO, @"This is a failed assert!"));
XCTAssertThrows(^{
FPRAssert(NO, @"This is a failed assert!");
}());
}

/** Tests emit diagnostics methods. */
Expand Down
Loading