Skip to content

fix(ci): Update to clang-format@21 #15260

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Aug 27, 2025
Merged

fix(ci): Update to clang-format@21 #15260

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
e183e26
fix(ci): Update to clang-format@21
ncooke3 Aug 27, 2025
0c09933
style
ncooke3 Aug 27, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CONTRIBUTING.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -132,7 +132,7 @@ To develop Firebase software, **install**:
To install [clang-format] and [mint] using [Homebrew]:

```console
brew install clang-format@20
brew install clang-format@21
brew install mint
```

Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -153,7 +153,7 @@ GitHub Actions will verify that any code changes are done in a style-compliant
way. Install `clang-format` and `mint`:

```console
brew install clang-format@20
brew install clang-format@21
brew install mint
```

Expand Down
2 changes: 1 addition & 1 deletion scripts/setup_check.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@ fi

# install clang-format
brew update
brew install clang-format@20
brew install clang-format@21

# mint installs tools from Mintfile on demand.
brew install mint
Expand Down
4 changes: 2 additions & 2 deletions scripts/style.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -56,7 +56,7 @@ version="${version/ (*)/}"
version="${version/.*/}"

case "$version" in
20)
21)
;;
google3-trunk)
echo "Please use a publicly released clang-format; a recent LLVM release"
Expand All @@ -65,7 +65,7 @@ case "$version" in
exit 1
;;
*)
echo "Please upgrade to clang-format version 20."
echo "Please upgrade to clang-format version 21."
echo "If it's installed via homebrew you can run:"
echo "brew upgrade clang-format"
exit 1
Expand Down
Loading