Skip to content

Conversation

andrewheard
Copy link
Contributor

Updated the URLContext struct to be internal instead of public. It doesn't need to be exposed publicly yet since it has no properties and should be initialized using Tool.urlContext() instead.

#no-changelog

Moved URLContext to be an internal type within the FirebaseAI module.

This involved:
- Moving the file to `FirebaseAI/Sources/Types/Internal/Tools/URLContext.swift`.
- Removing the `public` keyword from the struct.
- Making the `Tool.urlContext()` factory method internal.
- Updating documentation comments that referenced the now-internal type.

Could not run tests due to environment limitations.
Moved URLContext to be an internal type within the FirebaseAI module.

This involved:
- Moving the file to `FirebaseAI/Sources/Types/Internal/Tools/URLContext.swift`.
- Removing the `public` keyword from the struct.
- Updating documentation comments that referenced the now-internal type to point to the public factory method.

Could not run tests due to environment limitations.
Copy link
Contributor

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

@paulb777 paulb777 merged commit 609bb97 into ah/firebaseai-urlcontext Sep 17, 2025
44 checks passed
@paulb777 paulb777 deleted the refactor-urlcontext-internal branch September 17, 2025 03:09
paulb777 pushed a commit that referenced this pull request Sep 22, 2025
Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants