Skip to content

Fix browser detection #1773

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mmermerkaya merged 2 commits into from
May 10, 2019
Merged

Fix browser detection #1773

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4789457
Fix browser detection
mmermerkaya May 9, 2019
647def1
Remove redundant type annotations, fix comments
mmermerkaya May 9, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
Fix browser detection 
Web Workers are browser too.
  • Loading branch information
@mmermerkaya
mmermerkaya committed May 9, 2019
commit 4789457558e50bfc36a55ad331ee76a8e35886f3
2 changes: 1 addition & 1 deletion packages/util/src/environment.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -68,7 +68,7 @@ export function isNode(): boolean {
* Detect Browser Environment
*/
export function isBrowser(): boolean {
return typeof window !== 'undefined';
return typeof self === 'object' && self.self === self;
Copy link
Member

@Feiyang1 Feiyang1 May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just curious why checking self.self? Does some none browser env have self, but not self.self, or just to handle the case where someone defined a variable named self in none browse env?

The intention of this function was just to check if it's a browser window env.
My intuition is that webworker probably needs a dedicated env check logic, but we don't need it anywhere. Do you see any implication of treating webworker as a browser env?

Copy link
Contributor Author

@mmermerkaya mmermerkaya May 9, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To make sure that self is actually the global self, and not some random global that a developer defined.

I thought that in the place you use this function, you'd want the result to be true for web workers as well. It's a useful check in both window and web worker contexts.

}

/**
Expand Down