Skip to content

Updated to include promise instead of promiselike #8667

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
maneesht merged 14 commits into from
Jan 9, 2025
Merged

Updated to include promise instead of promiselike #8667

Changes from 1 commit
Commits
Show all changes
14 commits
Select commit Hold shift + click to select a range
02bca93
Updated to include promise instead of promiselike
maneesht Dec 6, 2024
7825789
Updated API
maneesht Dec 6, 2024
599db1c
Create tame-tigers-approve.md
maneesht Dec 6, 2024
92b889d
Removed unnecessary interface
maneesht Dec 6, 2024
a33ec70
Merge branch 'mtewani/implement-promises-fdc' of https://github.com/f…
maneesht Dec 6, 2024
9c04231
Update API reports
maneesht Dec 6, 2024
f2b8be0
Addressed review feedback
maneesht Jan 9, 2025
98295f3
Merge branch 'mtewani/implement-promises-fdc' of https://github.com/f…
maneesht Jan 9, 2025
0fca604
Merge remote-tracking branch 'origin/main' into mtewani/implement-pro…
maneesht Jan 9, 2025
c486948
Formatting
maneesht Jan 9, 2025
ecd67ce
Updated patch to minor
maneesht Jan 9, 2025
877ee8e
Bump upload artifact version
maneesht Jan 9, 2025
063e9b6
Merge remote-tracking branch 'origin/main' into mtewani/implement-pro…
maneesht Jan 9, 2025
c94a9ca
Bumped firebase minor
maneesht Jan 9, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Formatting
  • Loading branch information
@maneesht
maneesht committed Jan 9, 2025
commit c486948ac89f98f482a39afdf03622c88d5f8767
7 changes: 4 additions & 3 deletions packages/data-connect/src/core/QueryManager.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -105,9 +105,10 @@ export class QueryManager {
variables: queryRef.variables,
refType: QUERY_STR
});
const trackedQuery = this._queries.get(
key
) as TrackedQuery<Data, Variables>;
const trackedQuery = this._queries.get(key) as TrackedQuery<
Data,
Variables
>;
const subscription = {
userCallback: onResultCallback,
errCallback: onErrorCallback
Expand Down
Loading