Skip to content

fix(firestore): fix empty message reject inside transaction body #9177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
MarkDuckworth merged 5 commits into from
Aug 18, 2025
Merged

fix(firestore): fix empty message reject inside transaction body #9177

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
42ed26d
Fix empty message reject in transaction body
cherylEnkidu Jul 21, 2025
99e6d59
add changeset
cherylEnkidu Jul 21, 2025
b1a4873
address feedbacks
cherylEnkidu Jul 24, 2025
56ca0e1
address feedbacks 2
cherylEnkidu Jul 30, 2025
4714c7a
PR feedback - error? to Error | undefined
MarkDuckworth Aug 18, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
PR feedback - error? to Error | undefined
  • Loading branch information
@MarkDuckworth
MarkDuckworth committed Aug 18, 2025
commit 4714c7a3772b456df9d08cc6415e101427a24e81
2 changes: 1 addition & 1 deletion packages/firestore/src/core/transaction_runner.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -112,7 +112,7 @@ export class TransactionRunner<T> {
}
}

private isRetryableTransactionError(error?: Error): boolean {
private isRetryableTransactionError(error: Error | undefined): boolean {
if (error?.name === 'FirebaseError') {
// In transactions, the backend will fail outdated reads with FAILED_PRECONDITION and
// non-matching document versions with ABORTED. These errors should be retried.
Expand Down
Loading