Skip to content

Conversation

johannordin
Copy link
Contributor

closes #38

Hi! 👋
Gave this a go since I needed the typings myself.
Looks alright? Just let me know if you want to change anything.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@johannordin
Copy link
Contributor Author

johannordin commented Oct 3, 2018 via email

@googlebot
Copy link

CLAs look good, thanks!

@nicolasgarnier
Copy link
Contributor

Super! thanks so much @johannordin

@nicolasgarnier nicolasgarnier merged commit 18b7090 into firebase:master Oct 4, 2018
@nicolasgarnier
Copy link
Contributor

Just released this as part of v3.1.0

@SeraphicRav
Copy link

Thank you so much!

@prontiol
Copy link

prontiol commented Oct 5, 2018

I installed v3.1.0 and there are no typings included.
Please make sure you bundled typings into the npm package, @nicolasgarnier.

@nicolasgarnier
Copy link
Contributor

nicolasgarnier commented Oct 5, 2018

Yes, my bad :D Le me fix this.

@johannordin
Copy link
Contributor Author

I didnt change the package.json file, is thats whats missing? #49

@nicolasgarnier
Copy link
Contributor

yes, we have to list all files to add to the package in there.

I just released v3.1.2 which should contain it :)

@ShaMan123
Copy link

Hi guys, since there isn't a mention in the package.json types are not accessible

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create Typescript type definitions
6 participants