Skip to content

[firebase_auth] getIdToken use actual refresh value instead of checking if object exists #1334

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinjackson merged 7 commits into from
Nov 13, 2019
Merged

[firebase_auth] getIdToken use actual refresh value instead of checking if object exists #1334

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
3198736
getIdToken use actual refresh value instead of checking if object exists
AlexZaiats Oct 31, 2019
8431a0d
getIdToken refresh integration test
AlexZaiats Oct 31, 2019
279365d
Fixed code style issues in auth test
AlexZaiats Nov 1, 2019
72f8765
Rebase fixes
AlexZaiats Nov 7, 2019
86bee23
CollinJackson review fixes
AlexZaiats Nov 8, 2019
6aa503e
Rebase with master
AlexZaiats Nov 8, 2019
f6d1bdc
Update packages/firebase_auth/CHANGELOG.md
AlexZaiats Nov 13, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Next Next commit
getIdToken use actual refresh value instead of checking if object exists
  • Loading branch information
@AlexZaiats
AlexZaiats committed Nov 8, 2019
commit 3198736120b0f7a478346ea419e828f93c62615d
4 changes: 4 additions & 0 deletions packages/firebase_auth/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,11 @@

## 0.14.0+7

<<<<<<< HEAD
* Remove AndroidX warning.
=======
* Do not ignore "refresh" value for "getIdToken" on iOS
>>>>>>> getIdToken use actual refresh value instead of checking if object exists

Copy link
Contributor

@collinjackson collinjackson Nov 7, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

## 0.14.0+6

Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/ios/Classes/FirebaseAuthPlugin.m
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -205,7 +205,7 @@ - (void)handleMethodCall:(FlutterMethodCall *)call result:(FlutterResult)result
}
} else if ([@"getIdToken" isEqualToString:call.method]) {
NSDictionary *args = call.arguments;
BOOL refresh = [args objectForKey:@"refresh"];
BOOL refresh = [[args objectForKey:@"refresh"] boolValue];
[[self getAuth:call.arguments].currentUser
getIDTokenResultForcingRefresh:refresh
completion:^(FIRAuthTokenResult *_Nullable tokenResult,
Expand Down