Skip to content

Update FirebaseApp creation in tests #1406

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
bparrishMines merged 1 commit into from
Nov 14, 2019
Merged

Update FirebaseApp creation in tests #1406

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Update FirebaseApp creation in tests
  • Loading branch information
@kroikie
kroikie committed Nov 13, 2019
commit 227be22f3d321f50d88295533b6f176c7e89ed73
2 changes: 1 addition & 1 deletion packages/cloud_firestore/test/cloud_firestore_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -175,7 +175,7 @@ void main() {
});

test('settings', () async {
final FirebaseApp app = const FirebaseApp(name: "testApp2");
final FirebaseApp app = FirebaseApp(name: "testApp2");
final Firestore firestoreWithSettings = Firestore(app: app);
await firestoreWithSettings.settings(
persistenceEnabled: true,
Expand Down
2 changes: 1 addition & 1 deletion packages/cloud_functions/test/cloud_functions_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ void main() {
.getHttpsCallable(functionName: 'baz')
.call();
final HttpsCallable callable =
CloudFunctions(app: const FirebaseApp(name: '1337'), region: 'space')
CloudFunctions(app: FirebaseApp(name: '1337'), region: 'space')
.getHttpsCallable(functionName: 'qux')
..timeout = const Duration(days: 300);
await callable.call(<String, dynamic>{
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_database/test/firebase_database_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ void main() {

int mockHandleId = 0;
final List<MethodCall> log = <MethodCall>[];
final FirebaseApp app = const FirebaseApp(
final FirebaseApp app = FirebaseApp(
name: 'testApp',
);
final String databaseURL = 'https://fake-database-url2.firebaseio.com';
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_storage/test/firebase_storage_test.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,7 +14,7 @@ void main() {
TestWidgetsFlutterBinding.ensureInitialized();

group('FirebaseStorage', () {
final FirebaseApp app = const FirebaseApp(
final FirebaseApp app = FirebaseApp(
name: 'testApp',
);
final String storageBucket = 'gs://fake-storage-bucket-url.com';
Expand Down