Skip to content

[firebase_remote_config] Bumps Android Firebase dependency to 19.0.3 #1443

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinjackson merged 7 commits into from
Nov 19, 2019
Merged

[firebase_remote_config] Bumps Android Firebase dependency to 19.0.3 #1443

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
545145b
Bump AGP, Gradle & Google Services Plugin
Nov 18, 2019
c101478
Bumps dependency to Firebase Config 19.0.3
Nov 18, 2019
5621f4f
Replaces a deprecated method usage with the updated version
Nov 18, 2019
461a210
Bumps version, adds changelog
Nov 18, 2019
17f71f8
Ensures failed activations set the activateFailed error name
Nov 18, 2019
a904f00
Update CHANGELOG.md
collinjackson Nov 19, 2019
c97708b
Update CHANGELOG.md
collinjackson Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Ensures failed activations set the activateFailed error name
  • Loading branch information
Sebastian Roth committed Nov 18, 2019
commit 17f71f8b14f4c4714a4e6cbd6a4b9b9de6439072
2 changes: 1 addition & 1 deletion ...src/main/java/io/flutter/plugins/firebase/firebaseremoteconfig/MethodCallHandlerImpl.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -110,7 +110,7 @@ public void onComplete(Task<Void> task) {
public void onComplete(Task<Boolean> task) {
if (!task.isSuccessful()) {
String errorMessage = "Unable to complete activate.";
result.error("fetchFailed", errorMessage, null);
result.error("activateFailed", errorMessage, null);
} else {
Map<String, Object> properties = new HashMap<>();
properties.put("parameters", getConfigParameters());
Expand Down