Skip to content

[cloud_firestore] [firebase_performance] fix analyzer warnings #1453

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
collinjackson merged 7 commits into from
Nov 19, 2019
Merged

[cloud_firestore] [firebase_performance] fix analyzer warnings #1453

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
5d95b62
fix analyzer warnings
collinjackson Nov 18, 2019
e406ae1
fix analyzer warnings
collinjackson Nov 18, 2019
90967a9
fix analyzer warnings
collinjackson Nov 18, 2019
cec64cf
Fix analyzer warnings for cloud_firestore
collinjackson Nov 19, 2019
770db17
CHANGELOG
collinjackson Nov 19, 2019
b81c988
Fix more analyzer issues
collinjackson Nov 19, 2019
3e00b02
bring back hasStarted
collinjackson Nov 19, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 4 additions & 0 deletions packages/firebase_performance/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
## 0.3.1+3

* Fixed analyzer warnings about unused fields.

## 0.3.1+2

* Updated README instructions for contributing for consistency with other Flutterfire plugins.
Expand Down
3 changes: 0 additions & 3 deletions packages/firebase_performance/lib/src/http_metric.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -24,9 +24,6 @@ class HttpMetric extends PerformanceAttributes {
final String url;
final HttpMethod httpMethod;

@override
bool _hasStarted = false;

@override
bool _hasStopped = false;

Expand Down
1 change: 0 additions & 1 deletion packages/firebase_performance/lib/src/performance_attributes.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@ abstract class PerformanceAttributes {

final Map<String, String> _attributes = <String, String>{};

bool get _hasStarted;
bool get _hasStopped;

int get _handle;
Expand Down
4 changes: 2 additions & 2 deletions packages/firebase_performance/pubspec.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Google Performance Monitoring for Firebase, an a
iOS.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_performance
version: 0.3.1+2
version: 0.3.1+3

dependencies:
flutter:
Expand All @@ -28,4 +28,4 @@ flutter:

environment:
sdk: ">=2.0.0-dev.28.0 <3.0.0"
flutter: ">=1.9.1+hotfix.5 <2.0.0"
flutter: ">=1.9.1+hotfix.5 <2.0.0"