Skip to content
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Fix analyzer
  • Loading branch information
collinjackson committed Nov 18, 2019
commit 663322070971a4acbb614967a3932b82842313d4
4 changes: 3 additions & 1 deletion packages/firebase_auth/CHANGELOG.md
Original file line number Diff line number Diff line change
@@ -1,6 +1,8 @@
## 0.14.0+11
## 0.15.0

* Fix NoSuchMethodError in `reauthenticateWithCredential`
* Fixed `IdTokenResult` analyzer warnings.
* Reduced visibility of `IdTokenResult` constructor.

## 0.14.0+10

Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/example/test/firebase_auth.dart
Original file line number Diff line number Diff line change
Expand Up @@ -92,7 +92,7 @@ void main() {
await auth.fetchSignInMethodsForEmail(email: testEmail);
expect(methods.length, 1);
expect(methods[0], 'password');
AuthResult renewResult = await result.user.reauthenticateWithCredential(
final AuthResult renewResult = await result.user.reauthenticateWithCredential(
EmailAuthProvider.getCredential(
email: testEmail,
password: testPassword,
Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/lib/src/firebase_user.dart
Original file line number Diff line number Diff line change
Expand Up @@ -40,7 +40,7 @@ class FirebaseUser extends UserInfo {
'app': _app.name,
});

return IdTokenResult(data, _app);
return IdTokenResult._(data);
}

/// Associates a user account from a third-party identity provider with this
Expand Down
5 changes: 1 addition & 4 deletions packages/firebase_auth/lib/src/id_token_result.dart
Original file line number Diff line number Diff line change
Expand Up @@ -12,10 +12,7 @@ part of firebase_auth;
/// Only server side verification can guarantee the integrity of the token
/// claims.
class IdTokenResult {
@visibleForTesting
IdTokenResult(this._data, this._app);

final FirebaseApp _app;
IdTokenResult._(this._data);

final Map<dynamic, dynamic> _data;

Expand Down
2 changes: 1 addition & 1 deletion packages/firebase_auth/pubspec.yaml
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@ description: Flutter plugin for Firebase Auth, enabling Android and iOS
like Google, Facebook and Twitter.
author: Flutter Team <[email protected]>
homepage: https://github.com/FirebaseExtended/flutterfire/tree/master/packages/firebase_auth
version: 0.14.0+11
version: 0.15.0

flutter:
plugin:
Expand Down