Skip to content

[firebase_remote_config] Support v2 android embedder. #282

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cyanglaz merged 28 commits into from
Nov 14, 2019
Merged

[firebase_remote_config] Support v2 android embedder. #282

Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
9f8bf53
Plugin side of new embedding
bparrishMines Oct 7, 2019
550b2d9
Update example app to used embedding api
bparrishMines Oct 7, 2019
3e73439
I always forget to format
bparrishMines Oct 7, 2019
143b534
channel name constant no null check
bparrishMines Oct 8, 2019
d00e5b9
migrate
Oct 8, 2019
78c8828
migrate
Oct 8, 2019
839defa
Revert "migrate"
Oct 8, 2019
46b97e8
add firebase core dependency in example app
Oct 8, 2019
e592f6a
Update gradle.properties
Oct 8, 2019
1dcd55f
Update MethodCallHandlerImpl.java
Oct 8, 2019
4f0c1df
Update EmbeddingV1Activity.java
Oct 8, 2019
a27c3cd
Update MainActivity.java
Oct 8, 2019
bc2f587
Update MethodCallHandlerImpl.java
Oct 8, 2019
593e84f
Update EmbeddingV1Activity.java
Oct 8, 2019
ca428a8
Update MainActivity.java
Oct 8, 2019
1f1359c
fix gradle
Oct 11, 2019
6721ca4
Update MainActivity.java
Oct 15, 2019
9ed4745
Update MainActivity.java
Nov 13, 2019
ab84f7b
adding e2d tests
Nov 13, 2019
7284d68
Merge branch 'fb_remote_config' of github.com:cyanglaz/flutterfire in…
Nov 13, 2019
86a66ae
formatting
Nov 13, 2019
c91fcc1
merge master
Nov 13, 2019
ebda522
merge master
Nov 13, 2019
4523a3b
revert local change to firebase core
Nov 13, 2019
9a7e371
Update pubspec.yaml
Nov 13, 2019
fe66176
merge master
Nov 14, 2019
6c0610c
Merge branch 'fb_remote_config' of github.com:cyanglaz/flutterfire in…
Nov 14, 2019
a85b301
update firebase core dependency
Nov 14, 2019
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
add firebase core dependency in example app
  • Loading branch information
Chris Yang committed Oct 8, 2019
commit 46b97e8c8b1c92189bb607c6e9699eed2db38be4
6 changes: 6 additions & 0 deletions ...p/src/main/java/io/flutter/plugins/firebase/firebaseremoteconfigexample/MainActivity.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,8 @@

import io.flutter.embedding.android.FlutterActivity;
import io.flutter.embedding.engine.FlutterEngine;
import io.flutter.embedding.engine.plugins.shim.ShimPluginRegistry;
import io.flutter.plugins.firebase.core.FirebaseCorePlugin;
import io.flutter.plugins.firebase.firebaseremoteconfig.FirebaseRemoteConfigPlugin;

public class MainActivity extends FlutterActivity {
Expand All @@ -10,5 +12,9 @@ public class MainActivity extends FlutterActivity {
public void configureFlutterEngine(FlutterEngine flutterEngine) {
super.configureFlutterEngine(flutterEngine);
flutterEngine.getPlugins().add(new FirebaseRemoteConfigPlugin());

ShimPluginRegistry shimPluginRegistry = new ShimPluginRegistry(flutterEngine);
FirebaseCorePlugin.registerWith(
Copy link
Contributor

@xster xster Oct 31, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ditto from other PR

Copy link
Author

@cyanglaz cyanglaz Nov 13, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I might have missed some updates about the V2 embedding. I took a look of other firebase plugin migration PR and figured we don't have to use the ShimPluginRegistry to manually register the firebase core plugin anymore. And instead we need to add the e2e plugin. So I have updated the file the same. Could you please take another look see if it is good to merge? @xster

Copy link
Contributor

@xster xster Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I meant rather that https://github.com/FirebaseExtended/flutterfire/blob/master/packages/firebase_core/android/src/main/java/io/flutter/plugins/firebase/core/FirebaseCorePlugin.java has a v2 embedding implementation. Shouldn't it just work if you did flutterEngine.getPlugins.add(new FirebaseCorePlugin());?

Copy link
Author

@cyanglaz cyanglaz Nov 14, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see thanks! Will update the dependency as well.

shimPluginRegistry.registrarFor("io.flutter.plugins.firebase.core.FirebaseCorePlugin"));
}
}