Skip to content

Fix race condition when adding mock reviews #16

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
nicolasgarnier merged 1 commit into from
Oct 31, 2017
Merged

Fix race condition when adding mock reviews #16

nicolasgarnier merged 1 commit into from
Oct 31, 2017

Conversation

@lukaselmer
Copy link
Contributor

@lukaselmer lukaselmer commented Oct 31, 2017

image

@nicolasgarnier
Copy link
Contributor

nicolasgarnier commented Oct 31, 2017

Thanks @lukaselmer !

(although the previous code was showcasing the automatic retry of the transaction :D)

@nicolasgarnier nicolasgarnier merged commit b0fa233 into firebase:master Oct 31, 2017
@samtstern
Copy link
Contributor

samtstern commented Nov 1, 2017

cc @AbeHaskins just so you know this code now uses async/await. Seems that this is supported in almost every browser though http://caniuse.com/#feat=async-functions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@lukaselmer @nicolasgarnier @samtstern