Skip to content

Conversation

@phil-hz
Copy link

@phil-hz phil-hz commented Sep 26, 2018

Version 4.0.0 of material-components-web has BC breaks that cause this to stop working. 0.39.0 does work.

Requires reworking how MDCDialog is setup and initialised. MCDDialog.show() is now .open() but just changing the call in FriendlyEats.View.js isn't enough. Believe it needs all the lists shown in the dialog to be updated. I'm not familiar enough with MDC (nor will I be) to do all the updates.

Version 4.0.0 of material-components-web has BC breaks that cause this to stop working. 0.39.0 does work.

Requires reworking how MDCDialog is setup and initialised. MCDDialog.show() is now .open() but just changing the call in FriendlyEats.View.js isn't enough. Believe it needs all the lists shown in the dialog to be updated. I'm not familiar enough with MDC (nor will I be) to do all the updates.
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here (e.g. I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

@phil-hz
Copy link
Author

phil-hz commented Sep 26, 2018

Opened PR on wrong account

@phil-hz phil-hz closed this Sep 26, 2018
@phil-hz phil-hz deleted the patch-1 branch September 26, 2018 11:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants