Set specific version for MDC js and css #41
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Version 4.0.0 of material-components-web has BC breaks that cause this to stop working. 0.39.0 does work. Requires reworking how MDCDialog is setup and initialised. MCDDialog.show() is now .open() but just changing the call in FriendlyEats.View.js isn't enough. Believe it needs all the lists shown in the dialog to be updated. I'm not familiar enough with MDC (nor will I be) to do all the updates.
Contributor
|
Hopefully @AbeHaskins or maybe @nicolasgarnier can look into this. Thanks @philrennie for submitting! |
Contributor
|
Thanks @philrennie Let's merge this for now since this fixes the codelab for everyone :) We'll look into upgrading to 0.40.0 in a separate PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Version 4.0.0 of material-components-web has BC breaks that cause this to stop working. 0.39.0 does work.
Requires reworking how MDCDialog is setup and initialised. MCDDialog.show() is now .open() but just changing the call in FriendlyEats.View.js isn't enough. Believe it needs all the lists shown in the dialog to be updated. I'm not familiar enough with MDC (nor will I be) to do all the updates.