feat(go/plugins/compat_oai): Added xAI support #3605
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@hugoaguirre review it please |
|
Hey @gvozdevs, thanks for the contribution. I'll review the changes in a moment. |
hugoaguirre
changed the title
hugoaguirre
reviewed
Sep 19, 2025
| } | ||
|
|
||
| // Initialize Genkit with the xAI plugin | ||
| g, err := genkit.Init(ctx, |
There was a problem hiding this comment.
genkit.Init no longer returns an error, it panics if something goes wrong.
hugoaguirre
reviewed
Sep 19, 2025
| @@ -0,0 +1,91 @@ | |||
| # OpenAI Plugin | |||
There was a problem hiding this comment.
It would be helpful if we list the supported features of the plugin. Some providers might have limited functionality if their models are being called using the OpenAI API
hugoaguirre
reviewed
Sep 19, 2025
| }) | ||
|
|
||
| t.Run("invalid config type", func(t *testing.T) { | ||
| // Try to use a string as config instead of *ai.GenerationCommonConfig |
There was a problem hiding this comment.
Should be *openai.ChatCompletionNewParams instead of *ai.GenerationCommonConfig
hugoaguirre
requested changes
Sep 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added support for xAI models
Checklist (if applicable):