fix(cli/telemetry-server): fixed trace duplication in the index which resulted in duplication in trace list in dev ui #3619
+47
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pavelgj
changed the title
The `save` method in `LocalFileTraceStore` was incorrectly using the hydrated `trace` object to determine if a root span exists before indexing. The hydration process can modify span data, which could cause the root span check to fail. This change ensures the check is performed on the original `rawTrace` object, guaranteeing that traces with root spans are correctly identified and added to the index.
pavelgj
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
also truncate large attributes in spans when listing traces
Checklist (if applicable):