Add passkey authentication sample to auth quickstart#1061
Draft
macastelaz wants to merge 4 commits into
Draft
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces Passkey authentication to the Firebase Auth quickstart, adding a new HTML interface, TypeScript logic utilizing Firebase's passkey APIs, and an updated dependency version. Feedback on the changes highlights two critical issues: first, the local path aliases added to auth/vite.config.js will break builds for external users and should be removed; second, calling JSON.stringify directly on the Firebase User object in auth/passkey.ts will throw a circular structure error, so user.toJSON() should be used instead.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For additional details, please see go/firebase-auth-web-passkey-public-preview.