Skip to content

Add passkey authentication sample to auth quickstart#1061

Draft
macastelaz wants to merge 4 commits into
masterfrom
auth-passkey-sample
Draft

Add passkey authentication sample to auth quickstart#1061
macastelaz wants to merge 4 commits into
masterfrom
auth-passkey-sample

Conversation

@macastelaz

Copy link
Copy Markdown

For additional details, please see go/firebase-auth-web-passkey-public-preview.

Comment thread auth/passkey.html Fixed

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request introduces Passkey authentication to the Firebase Auth quickstart, adding a new HTML interface, TypeScript logic utilizing Firebase's passkey APIs, and an updated dependency version. Feedback on the changes highlights two critical issues: first, the local path aliases added to auth/vite.config.js will break builds for external users and should be removed; second, calling JSON.stringify directly on the Firebase User object in auth/passkey.ts will throw a circular structure error, so user.toJSON() should be used instead.

Comment thread auth/vite.config.js Outdated
Comment thread auth/passkey.ts Outdated
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants