Revert Jest Runners for linting and upgrade Jest to 23 🎉 #6412
Conversation
| ```js | ||
| it("should call handleClick function", () => { | ||
| const onClick = jest.genMockFunction(); | ||
| const onClick = jest.fn(); |
There was a problem hiding this comment.
genMockFunction was removed and was an undocumented API. Removing it from our examples and code.
| ```js | ||
| it("should render a button", () => { | ||
| const onClick = jest.genMockFunction(); | ||
| const onClick = jest.fn(); |
There was a problem hiding this comment.
genMockFunction was removed and was an undocumented API. Removing it from our examples and code.
| | Type | Command | | ||
| | -------- | ------------------- | | ||
| | all | `yarn run lint` | | ||
| | css | `yarn run lint:css` | |
There was a problem hiding this comment.
We swapped back and forth on using - and : in the config so I just settled on :
| addLineClass: jest.fn(), | ||
| removeLineClass: jest.fn(), | ||
| markText: jest.genMockFunction().mockReturnValue({ clear }), | ||
| markText: jest.fn(() => ({ clear })), |
There was a problem hiding this comment.
genMockFunction was removed and was an undocumented API. Removing it from our examples and code.
| import ResultList from "../ResultList"; | ||
|
|
||
| const selectItem = jest.genMockFunction(); | ||
| const selectItem = jest.fn(); |
There was a problem hiding this comment.
genMockFunction was removed and was an undocumented API. Removing it from our examples and code.
| function generateDefaults(overrides) { | ||
| return { | ||
| selectLocation: jest.genMockFunction(), | ||
| selectLocation: jest.fn(), |
There was a problem hiding this comment.
genMockFunction was removed and was an undocumented API. Removing it from our examples and code.
wldcordeiro
force-pushed
the
rollback-jest-runners
branch
from
c70464d to
eae9fa5
Compare
2 participants
Summary of Changes
@jasonLaster requested this as we were seeing some weirdness and large outputs.