Upgrade Jest and other test-related libraries #1212
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -334,7 +334,6 @@ exports[`app/Home renders the install screen for the legacy add-on 1`] = ` | |
| To start recording a performance profile in Firefox, first install the | ||
|
|
||
| <a | ||
|
Contributor
Author
There was a problem hiding this comment. it looks like that when a prop has an |
||
| href="https://raw.githubusercontent.com/devtools-html/Gecko-Profiler-Addon/master/gecko_profiler_legacy.xpi" | ||
| onClick={[Function]} | ||
| > | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -369,6 +369,16 @@ Array [ | |
| "rgba(255, 255, 255, 0.0)", | ||
| ], | ||
| ], | ||
| "results": Array [ | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| ], | ||
|
Contributor
Author
There was a problem hiding this comment. mock functions now track results in addition to parameters, that's why we see it in the serialized version too. Looking at this snapshot, it looks like that What do you think ? I could do it directly in this PR or in a separate PR.
Member
There was a problem hiding this comment. I'm fine however you want to do it. |
||
| }, | ||
| }, | ||
| ], | ||
|
|
@@ -576,6 +586,16 @@ Array [ | |
| "rgba(255, 255, 255, 0.0)", | ||
| ], | ||
| ], | ||
| "results": Array [ | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ], | ||
|
|
@@ -880,6 +900,16 @@ Array [ | |
| "rgba(255, 255, 255, 0.0)", | ||
| ], | ||
| ], | ||
| "results": Array [ | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| Object { | ||
| "isThrow": false, | ||
| "value": undefined, | ||
| }, | ||
| ], | ||
| }, | ||
| }, | ||
| ], | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -145,7 +145,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons 1`] = ` | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
|
Contributor
Author
There was a problem hiding this comment. looks like |
||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -271,7 +271,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons 1`] = ` | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
@@ -490,7 +489,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons 2`] = ` | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -616,7 +615,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons 2`] = ` | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
@@ -835,7 +833,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -961,7 +959,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
@@ -1180,7 +1177,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -1306,7 +1303,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
@@ -1525,7 +1521,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -1651,7 +1647,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
@@ -1870,7 +1865,7 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| className="menuButtonsPermalinkTextField" | ||
| readOnly="readOnly" | ||
| type="text" | ||
| value="http://localhost/" | ||
| /> | ||
| </div> | ||
| </div> | ||
|
|
@@ -1996,7 +1991,6 @@ exports[`app/MenuButtons renders the MenuButtons buttons with profile.meta.netwo | |
| checked={false} | ||
| className="menuButtonsShareNetworkUrlsCheckbox" | ||
| disabled={true} | ||
| type="checkbox" | ||
| /> | ||
| Share the URLs of all network requests | ||
|
|
||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AH the new snapshots are actually what's expected -- this means the tests weren't working properly before :/
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is enzymejs/enzyme#1499 -- and this is a good thing !
Before this we had to call "update" everywhere (I just forgot to do it here).
I'm gonna remove them all then !I can't remove the call toupdateanywhere else because this is only forshallowand not formountyet (maybe later ?)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Woops.