I2c fix shorter or larger messages #110
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
For some reason github is reporting this as unmergable (auto merge). Maybe because you had two pull requests with the same commit? |
…l/arduino into i2c-fix-shorter-or-larger-messages
Contributor
Author
|
Don't know. I made a new pull request with a new branch at #111 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In the current code, if the board gets a shorter or larger I2C reply, an string message is sent to the host with the warning. But then the I2C_REPLY is also sent to the host, without including the data data and without including the slave address and register. At least not including the address and the register is a bug.
I fixed the bug by changing the behaviour. When the board receives a shorter or larger I2C reply, a warning message will be sent, but also the reply including the slave address, the register (fixing the bug) and the data (truncated in the case of a larger than expected reply).