implement reporting for changed positions only #120
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
@nicolaspanel If there are no objections from your side I'll merge this. |
|
No problem for me but have you check that all tests are still passing (see NB : require last version of arduinounit |
Member
Author
|
good point, I'll do that. |
…ew autoReport semantics
Member
Author
|
had to adjust encoder_test.ino to match new toggleAutoReport(byte report) signature and semantics, runs fine now :-) |
ntruchsess
added a commit
that referenced
this pull request
Feb 28, 2014
implement reporting for changed positions only
Member
Author
There was a problem hiding this comment.
whenever autoReport is > 0 (see the if in line 161) and either autoReport == 1 or position is different to previously read value it's written to the sysex-report-message. So for autoReport = 1 it's reported allways, for any value > 1 (e.g. 0x02) it's reported only when changed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
implements #118
also increased Firmata-version to 2.6 as we have extended the protocol in a backwards compatible way.