merge configurable_dev into configurable #179
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ase.sh to build for arduino 1.0.x and arduino 1.5.x
…ve-configurable Update I2C_READ_CONTINUOUSLY to match I2C_READ w/ no provided slaveRegister
soundanalogous
changed the title
soundanalogous
added a commit
that referenced
this pull request
Feb 1, 2015
merge configurable_dev into configurable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After this merge lets stop using
configurable_dev. Contributors should instead create a topic branch off of theconfigurablebranch. If collaboration on a feature is needed we can create a common topic feature branch if necessary.This pull request includes a bugfix for I2C_READ_CONTINUOUSLY and a number of small formatting tweaks. It also adds the ability to change the stepDelay for Stepper from 1 microsecond to 2 microseconds to support some high current stepper drivers. The version has been bumped to 2.6.1.
I'm using the sublime text astyle plugin for formatting. I've only run it on Firmata.cpp, Firmata.h and Boards.h so far. I'll update formatting all files in an upcoming commit. The only change I've made in the astyle default options is changing spacing from 4 to 2 spaces (no tabs).
This pull request also changes all of the includes for local files (in the utility directory) to use double quotes rather than brackets. I was having issues with the brackets (unless changing all to
<utility/filename.h>) in clean versions of Arduino. I've tested the updated version in Arduino 1.0.5, 1.0.6, 1.5.7 and 1.5.8 both with the bundled versions (run release.sh and copy the Firmata file, overwriting the core Firmata library) as well as copying the raw directory structure from this repo into the core Firmata library directory. Was able to compile without issue in all tested versions of the IDE.