Skip to content

namespace firmata #348

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 26, 2017
Merged

namespace firmata #348

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
1819548
namespace firmata
zfields Feb 24, 2017
6004516
Remove redundant naming
zfields Feb 25, 2017
3cd149c
Unify sysex payload naming to DATA
zfields Feb 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Unify sysex payload naming to DATA
  • Loading branch information
@zfields
zfields committed Feb 26, 2017
commit 3cd149c5021fcff4a7c784fcab93ceb74154f986
2 changes: 1 addition & 1 deletion FirmataConstants.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -52,7 +52,7 @@ static const int END_SYSEX = 0xF7; // end a MIDI Sysex message
// extended command set using sysex (0-127/0x00-0x7F)
/* 0x00-0x0F reserved for user-defined commands */

static const int SERIAL_MESSAGE = 0x60; // communicate with serial devices, including other boards
static const int SERIAL_DATA = 0x60; // communicate with serial devices, including other boards
static const int ENCODER_DATA = 0x61; // reply with encoders current positions
static const int SERVO_CONFIG = 0x70; // set max angle, minPulse, maxPulse, freq
static const int STRING_DATA = 0x71; // a string message with 14-bits per char
Expand Down
2 changes: 1 addition & 1 deletion FirmataDefines.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -101,7 +101,7 @@
#ifdef SERIAL_MESSAGE
#undef SERIAL_MESSAGE
#endif
#define SERIAL_MESSAGE firmata::SERIAL_MESSAGE // communicate with serial devices, including other boards
#define SERIAL_MESSAGE firmata::SERIAL_DATA // communicate with serial devices, including other boards

#ifdef ENCODER_DATA
#undef ENCODER_DATA
Expand Down