Skip to content

Fix I2C config parameter interpretation #383

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 19, 2017
Merged

Fix I2C config parameter interpretation #383

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Fix I2C config parameter interpretation 
The current implementation pulls bytes out of the sysex buffer, regardless of whether or not the user specified such bytes.
  • Loading branch information
@zfields
zfields committed Aug 18, 2017
commit 4fce1f33b6b7c81e262f8a20d7c85cca42df8e91
2 changes: 1 addition & 1 deletion examples/StandardFirmata/StandardFirmata.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -586,7 +586,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/StandardFirmataBLE/StandardFirmataBLE.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -603,7 +603,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/StandardFirmataChipKIT/StandardFirmataChipKIT.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -588,7 +588,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/StandardFirmataEthernet/StandardFirmataEthernet.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -666,7 +666,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/StandardFirmataPlus/StandardFirmataPlus.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -611,7 +611,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down
2 changes: 1 addition & 1 deletion examples/StandardFirmataWiFi/StandardFirmataWiFi.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -675,7 +675,7 @@ void sysexCallback(byte command, byte argc, byte *argv)
case I2C_CONFIG:
delayTime = (argv[0] + (argv[1] << 7));

if (delayTime > 0) {
if (argc > 1 && delayTime > 0) {
i2cReadDelayTime = delayTime;
}

Expand Down