Skip to content

fixed memory leak in string buffer #76

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 10, 2013
Merged

fixed memory leak in string buffer #76

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
b1c78c5
fixed memory leak in string buffer
soundanalogous Aug 1, 2013
04b04d5
updated to decode incoming string within input buffer to save memory
soundanalogous Aug 4, 2013
9e5d2b8
increased input data buffer size from 32 to 64 bytes
soundanalogous Aug 4, 2013
f1c6f12
removed string memory leak test
soundanalogous Aug 4, 2013
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
removed string memory leak test
  • Loading branch information
@soundanalogous
soundanalogous committed Aug 4, 2013
commit f1c6f1203aab2152a6bd3e2820de51cffa86302f
19 changes: 0 additions & 19 deletions test/unit/firmata_test/firmata_test.ino
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -46,10 +46,6 @@ void processMessage(const byte* message, size_t length)
}
}

void stringCallback(char *myString)
{
}

byte _digitalPort;
int _digitalPortValue;
void writeToDigitalPort(byte port, int value)
Expand Down Expand Up @@ -130,21 +126,6 @@ test(specifiedDigitalWritePort)
assertEqual(1, _digitalPort);
}

test(stringDataDoesNotLeakMemory)
{
Firmata.attach(STRING_DATA, stringCallback);

int initialMemory = freeMemory();

byte stringMsg[] = { START_SYSEX, STRING_DATA, 72, 0, 101, 0, 108, 0, 108, 0, 111, 0, END_SYSEX };

for (int i = 0; i < 4; i++) {
processMessage(stringMsg, 13);
}

assertEqual(0, initialMemory - freeMemory());
}

test(setFirmwareVersionDoesNotLeakMemory)
{
Firmata.setFirmwareVersion(1, 0);
Expand Down