Repository navigation
Record a coding run's file operations and its plan (LAB-134) #1332
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
23 commits
Select commit
Hold shift + click to select a range
118b790
feat(claude-code): run the agent as a workstream (LAB-133)
claude feb4dc3
chore: name LAB-133 in the changeset body (process guard)
claude 0a2dfcf
fix(goal): the ordering assertion was blind and passed anyway (LAB-133)
claude 156eb7b
docs(goal): verdict rows for the corrected ordering assertion (LAB-133)
claude afe30a1
docs(claude-code): two claims the page was making that the code does …
claude 76e0566
docs(claude-code): same two corrections in the README (LAB-133)
claude 2f066e7
feat(claude-code): record a coding run's file operations and its plan…
claude 5c07baa
docs(goal): cite the commit each verdict row was actually run on (LAB…
claude df6cfdb
fix(claude-code): three ways the record could misreport what happened…
claude 4f2f63d
fix(claude-code): key the record by invocation, not by request (LAB-134)
claude ee55636
fix(goal): two assertions that passed the world they existed to rejec…
claude 952bb09
fix(claude-code): make recorder shutdown structural, and settle the f…
claude 0eba857
fix(claude-code): record what the harness confirms, not what the agen…
claude 75dc695
fix(claude-code): never settle from call-time values wearing a confir…
claude 877e25c
fix(claude-code): give observations call identity, and deliver them a…
claude 8b01b39
fix(claude-code): confirm nothing that cannot be checked, and say whi…
claude 281bed4
fix(claude-code): apply each rule on both sides of its axis (LAB-134)
claude f1b5c96
docs(goal): correct the round-10 before-count from 181 to 176 (LAB-134)
claude e6cc9b4
feat(claude-code): count applied file operations per path (LAB-134)
claude 16a88ab
refactor(claude-code)!: rename `sessionState` to `detached`, invertin…
claude e326056
fix(changeset): drop the migration fragment — nothing shipped `sessio…
claude 393cc3e
docs(claude-code): document `appliedCount` on both read surfaces (LAB…
claude aa8ade3
Merge origin/main into fix/LAB-134
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
fix(claude-code): three ways the record could misreport what happened…
… (LAB-134) Review rounds 1 and 2 on #1332. All three defects are the same family — the record saying something other than what the run did. **The reporting path could fail the run.** `onSkipped` was called unguarded from inside the serialized flush chain, so a throwing hook rejected `flush()`/`stop()` and turned a successful coding run into a bookkeeping failure — precisely the outcome this module exists to make impossible, hiding in the one place nobody defends because it is the thing that reports failures. Every call now routes through one guarded helper, so a future third call site cannot forget. **A phantom unresolved mutation.** The attempt was keyed at call time and the settlement keyed under the harness's resolved path, so a single write left a permanent `pending` row beside an `applied` one whenever the two differed. The key is fixed at call time by the recording cadence, so settling elsewhere can only ever split one operation in two: settlement now uses the call-time path. The harness's path still rides along and is compared AFTER canonicalization — in the recorder, where `notes.txt` and `/work/notes.txt` are known to be one key — and a real divergence becomes a gap row rather than a silent mis-keying. **A successful re-wording was dropped.** `TaskUpdateInput.subject` is declared on the pinned SDK and changes an item's wording, but only `taskId`/`status` were kept — so `observed-plan` held the create-time title forever while claiming to be the run's current plan. The new wording is now retained and applied on a confirmed update only, the same rule the status already followed. Also: the option's doc said two collections where three are declared, the comment beside the prose id fallback now scopes what was and was not measured (one probe run, `claude` 2.1.234), and the comment claiming pathless calls are "skipped silently" said the opposite of the code — an invitation to simplify away the gap emission that makes the next issue's assertion buildable. Kept the coalescing flush: a turn-boundary flush survives a kill between turns but not within one, and a long tool-heavy turn is exactly the coding-run shape. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01MVcrTezeLMBQRVHRg2QX2f
- Loading branch information
commit df6cfdbedcf313bb2a0a2c766d42ec359b18583c
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.