Repository navigation
Conversation
A channel can hold 0..N task ledgers, declared as one `boards:` key in its own CHANNEL.md. The ledger's identity is minted from the channel, the channel holds rows and never drains them, and a seat declares the same id to run them. Channel actions and taskTools are two doors on one mutation surface. Written against landed code at d8e4c99, which carries both W3 inputs. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Membership stays the channel's own and filing reuses the post path's fence. Verified in channel-flow.ts: the post path reads `members` off the channel's session state, so it is already live and authoritative at post time. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
|
The four documents, as absolute links — the relative forms in the description resolve unreliably from a PR body, and the description is not rewritten because that would defang the figure.
Two notes for whoever reviews: Written against landed code at ER-3 is recorded, not re-opened. Membership stays the channel's own and filing reuses the post path's fence, per the epic ruling. Checked against the code rather than taken on the ruling: the post path reads Linear was unreachable for this run ( Generated by Claude Code |
|
FSD Architect — coherence review on this never-merge child spec. Not owner approval / not the gate. Shared No silent two-direction forkChecked against open siblings and locked W4 material:
Soft ask · "Open: none" vs epic Open (ER-15)Epic #1905 Open parks four returned FIX-1408 walls and says they bite the first child that builds over the wire — which is FIX-1385, and to settle them on this child's spec review at the latest (else the child stalls or decides locally = ER-15 break):
This PR's first-cut goal check is file → other seat's existing What to change: do not keep a bare Open: none that reads as if the epic Open list is empty for this child. In DECISIONS / Sign off / PR body, add an explicit Not closing here block:
That keeps "Open: none" true for this cut's D1–D3 sign-off surface without quietly absorbing epic Open. D2 weigh (reviewer ask) — Architect lean, not a gateSilence on an unattended board (BR-16) is the correct price of the fence for this cut. Visibility belongs on FIX-1405 inventory, not a drain-shaped guard that would blur D2. Agree with leaving it documented-not-checked here. Not blocking / not Jake-pingingNo new product invent. No two-direction fork against another in-flight stream. Soft fold above is enough for the attached agent; owner still owns D1–D3. — FSD Architect |
There was a problem hiding this comment.
Simplify review (spec FIX-1385)
Verdict: The architectural direction is the right minimal move for this epic — one YAML key, minted org TaskCollection, channel holds / seat drains, models through existing taskTools. That reuses defineTaskCollection, taskBoard, channel-binder, and createTaskToolsCapability instead of inventing a channel workstream layer or a second tool surface. The rejected alternatives in DECISIONS (shared ledger, boards/ tree, document-the-recipe-only) are fairly argued; I would not steer back toward them.
Where complexity shows up is mostly artifact and delivery shape, not the fence itself:
-
Operational tradeoff (sign-off #2) — D2/BR-16 makes unattended boards silent until FIX-1405. The spec is honest about that; weighing it at sign-off is correct. Optional tighten (not required for approval): a bind-time roster lint (channel with
boards:has a seat declaring the minted id) would catch the common miswire without widening the channel kind. -
Dual doors (S5 + S6) — Necessary for the epic goal (human file + model
taskTools), but the highest drift risk. PLAN guardrails already say one write path; I'd add an implement-time note to resolve the ledger once per request and route both doors throughresolveResourceCollection+ the same mutation path asaddTask(reuse review against workforce reimplementing orchestration). -
Plan granularity — Eight surfaces / four PRs is traceable but heavy for a feature describable in three moves (validate
boards:, declare collections, wire file/read + resolver + helper). Collapsing to three PRs or three deliverables in the table would shrink cognitive load without changing behavior. -
Spec surface area — Four diagrams + repeated BP-030/031 prose could trim ~15–20% without losing decisions. BR-8 vs BR-9 is correct but author-facing copy could be one rule (“only names on this channel’s list”).
-
Phasing (if epic allows) — If the first ship only needs the DevForce-style human path, PR-C (
taskTools) could trail PR-B until VG needs model filing; D3 still stands, sequencing flexes. -
YAGNI question — S2/BR-6 custom
flow:kind parity is compositionally right; if W4 has no custom channel kind in tree yet, consider deferring to a follow-up unless epic gate requires it.
Skipped (product/epic calls, not spec defects): whether FIX-1405 must ship with this; migration story for channel folder rename beyond the table row in SPEC.
No implementation changes from this automation run — review only.
Sent by Cursor Automation: Review For Best Approach
| | **asks a model to file and triage work** | Gets a private board nobody else can see, or hand-writes tools over a shared one | The eight task tools it already has, pointed at the channel's board. Same rows a person sees | | ||
| | **is not a member of the channel** | A post claiming to be them is refused | Filing a row is refused the same way, for the same reason, in the same words | | ||
| | **already has channels open** | — | Nothing moves. A channel naming no board holds none, and reads and posts byte for byte as today | | ||
| | **renames a channel's folder** | The transcript moves with it | The rows do not. A rename is a re-key, and rows filed under the old name are orphaned | |
There was a problem hiding this comment.
Rename/re-key orphaning rows is called out clearly — good. For simpler author experience (not a different architecture), consider whether SPEC or S8 docs owe a short rename procedure (even “treat as new board; rows stay on old id”) so teams don’t discover this only from the table. Uncertain this belongs in FIX-1385 vs a channels doc follow-up.
| **What the seat that runs the work writes, in app code:** | ||
|
|
||
| ```diff | ||
| + const work = channelBoard("eng.feature", "work") // the ledger the channel holds |
There was a problem hiding this comment.
channelBoard("eng.feature", "work") duplicates identity already fixed at bind time — typo drift between CHANNEL.md and seat code is a real smell. Alternatives (if you want a cleaner change at implement time): roster-generated constants, or channelRef(...).board("work") so the minted id is single-sourced. Not blocking D1.
| |---|---| | ||
| | **Instead of** | A `drain` action on the channel kind, so a channel could run its own board | | ||
| | **Because** | Workers do, channels hold (the epic's D3). A channel that drains is an assignable channel acting as an executor, which the epic invent-killed. It is also what keeps this issue small: claiming, the lease, the start gate and the hand-off all stay on the seat side where they already work. `defineFlow` refuses a flow declaring a task *entry* with no board reachable; it asks nothing of a flow declaring only a collection, so holding costs the channel no machinery | | ||
| | **Locks in** | Filing work always takes two parties. A channel can hold a board no seat is pointed at, and those rows sit with nothing reported — no drain means nothing is watching. That silence is the price of the fence, and FIX-1405's inventory is what will make an unattended board visible, rather than a guard added here | |
There was a problem hiding this comment.
This is the main accepted complexity cost of the fence. Sign-off #2 surfaces it well. If product wants less silent failure without channel drain, the lightest spec add might be optional bind-time wiring check (board declared ⇒ some seat references minted id) — distinct from FIX-1405 inventory. Worth a one-line call in DECISIONS only if epic wants that guard.
| | BR-13 | A channel session opened before this shipped is read | It is still a bound channel and still accepts posts. An absent board list reads as none, never as unparseable state (BP-030) | CI · a recorded pre-upgrade session, and the negative control below | | ||
| | BR-14 | This issue names a Layer 2 concept on any new surface — a key, an action, an error, a doc heading | It uses the settled name and never the superseded one: *Channel* not *room*, *Role* not *Worker*, *Strategy* not *Pattern*, *Instructions* not *prompt template*, *stream visibility* not `agentType` | CI · a check over the diff, not a reading | | ||
| | BR-15 | A seat declares a board id no channel minted | Nothing here refuses it. A seat's board is the seat's, and this issue adds no registry of legal board ids | Existing suite | | ||
| | BR-16 | A channel declares a board and no seat drains it | The rows sit `pending`. Nothing reports it, because nothing is watching — [D2](DECISIONS.md#d2) | Documented, not checked | |
There was a problem hiding this comment.
BR-16 as “documented, not checked” makes “Open: none” in SPEC slightly narrow — readers hunting gaps should land here. Fine as-is; optional rename to known gap in sign-off cross-link.
| | S2 | `workforce` · the channel-kind contract | A kind receives the board ids its records declared — the built-in and a `kinds` entry alike, so `flow:` and `boards:` compose | BR-6 | | ||
| | S3 | `workforce` · the kind's declaration | One `defineTaskCollection` per minted id, `org` scope, as a flow resource. **No board, no drain, no task entry** (D2) | BR-1 BR-2 | | ||
| | S4 | `workforce` · channel session state | The declared-board list, **defaulted to `[]`**, written at open and projected by the read | BR-12 BR-13 | | ||
| | S5 | `workforce` · two new channel actions | File a row; read the board. Ledger resolved from the session's identity plus the caller's local name; an undeclared name refuses; the post path's membership fence reused | BR-7 BR-8 BR-9 BR-10 | |
There was a problem hiding this comment.
Two channel actions (file + read board) vs BR-12’s split read model. For a smaller first PR-B, if VG only needs filing + seat-side listTasks/drain, read-board on the channel kind might defer until kitchen-sink/docs need it. Uncertain — epic goal may already require read-board for transparency.
| | ID | Package · role | Change | Rules | | ||
| |---|---|---|---| | ||
| | S1 | `workforce` · the binder's validation pass | `boards` joins the closed key list: plain names, each minted `<channelId>.<name>`, each checked as a collection id, duplicates refused. In the pass that already walks the roster | BR-1 BR-3 BR-4 BR-5 | | ||
| | S2 | `workforce` · the channel-kind contract | A kind receives the board ids its records declared — the built-in and a `kinds` entry alike, so `flow:` and `boards:` compose | BR-6 | |
There was a problem hiding this comment.
S2/BR-6 custom-kind handoff is the right composition contract. Simpler delivery path: land built-in channel kind first, add custom flow: parity only when epic tree has a consumer — avoids speculative factory work if W4 is built-in-only today.
| | The board list is defaulted, never required (BP-030) | Boundness is one parse of the whole session state, so a required field reads every already-open channel as *not a channel* and refuses every post on it | | ||
| | Both the ledger and the membership check come off session state, never the call (BP-031) | Both are caller-controllable otherwise, and one of them picks storage. The fan-out already reads the roster this way | | ||
| | Both doors resolve one collection ref and write through one path (tenet 5) | Two write paths over one ledger drift on what they refuse, and that shows up as a model being allowed what a person is not | | ||
| | No drain, task entry or dispatcher reaches the channel kind | D2 is the fence, and reading the kind's declaration is cheaper than arguing three rounds later | |
There was a problem hiding this comment.
Suggest pinning explicitly: BR-4/BR-5 run only in binder S1, never on file/read/tool hot path; mint + resolveResourceCollection memoized per (sessionId, localBoardName) per request so eight taskTools don’t re-walk registry each call. Cheap PLAN guardrail, prevents accidental complexity in implementation.
| | S1 | `workforce` · the binder's validation pass | `boards` joins the closed key list: plain names, each minted `<channelId>.<name>`, each checked as a collection id, duplicates refused. In the pass that already walks the roster | BR-1 BR-3 BR-4 BR-5 | | ||
| | S2 | `workforce` · the channel-kind contract | A kind receives the board ids its records declared — the built-in and a `kinds` entry alike, so `flow:` and `boards:` compose | BR-6 | | ||
| | S3 | `workforce` · the kind's declaration | One `defineTaskCollection` per minted id, `org` scope, as a flow resource. **No board, no drain, no task entry** (D2) | BR-1 BR-2 | | ||
| | S4 | `workforce` · channel session state | The declared-board list, **defaulted to `[]`**, written at open and projected by the read | BR-12 BR-13 | |
There was a problem hiding this comment.
Adding boards: to an already-open channel will not activate the board. openChannels deliberately leaves bound session state unchanged, while S4 stores board declarations only when opening and defaults a missing list to []. The channel therefore continues reporting no boards and S5 refuses filings as undeclared until its session is deleted and recreated, so the promised one-line adoption does not work for existing channels. Specify reconciliation, an explicit migration, or a loud refusal for this case.
Knowledge Base Used: Workforce workers, seats, and channels
| | S5 | `workforce` · two new channel actions | File a row; read the board. Ledger resolved from the session's identity plus the caller's local name; an undeclared name refuses; the post path's membership fence reused | BR-7 BR-8 BR-9 BR-10 | | ||
| | S6 | `workforce` → `orchestration` · the model's door | A resolver pointing `createTaskToolsCapability` at a channel's ledger, on the **kind**. No new tool, nothing colocated in a seat's folder — a board is an org-scoped resource, refused there at hire (D3) | BR-11 BR-17 | |
There was a problem hiding this comment.
Membership checks are bypassable
S5 cannot provide members-only filing by reusing the post fence, and S6 bypasses that fence entirely. The existing post check validates only an optional, explicitly unverified author; omitting it skips membership validation. Meanwhile, addTask has no author or member input and writes through the resolved collection directly. As specified, an anonymous channel action or a non-member seat using taskTools can therefore file work despite the stated membership boundary. Define a trusted invoking-seat identity and enforce it on both write paths rather than relying on the optional author claim.
How this was verified: The post handler checks membership only when author is present, and the task-tools addTask schema and execution path contain no channel-member check.
Knowledge Base Used:
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 0a0679ff01
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| | S1 | `workforce` · the binder's validation pass | `boards` joins the closed key list: plain names, each minted `<channelId>.<name>`, each checked as a collection id, duplicates refused. In the pass that already walks the roster | BR-1 BR-3 BR-4 BR-5 | | ||
| | S2 | `workforce` · the channel-kind contract | A kind receives the board ids its records declared — the built-in and a `kinds` entry alike, so `flow:` and `boards:` compose | BR-6 | | ||
| | S3 | `workforce` · the kind's declaration | One `defineTaskCollection` per minted id, `org` scope, as a flow resource. **No board, no drain, no task entry** (D2) | BR-1 BR-2 | | ||
| | S4 | `workforce` · channel session state | The declared-board list, **defaulted to `[]`**, written at open and projected by the read | BR-12 BR-13 | |
There was a problem hiding this comment.
Migrate board declarations into already-open channels
When an operator adds boards: [work] to a channel that was opened before this feature ships, this plan writes the list only during channel creation. The current openChannels path treats a bound session as settled and leaves its state untouched (packages/workforce/src/channel/channel-binder.ts:572-576), so the new default merely parses the missing field as []; S5 will continue refusing work, and deleting/reopening to populate it would discard the existing transcript. Add a reconciliation/migration path, or resolve declarations from a source that is not frozen at initial open.
Useful? React with 👍 / 👎.
| | S6 | `workforce` → `orchestration` · the model's door | A resolver pointing `createTaskToolsCapability` at a channel's ledger, on the **kind**. No new tool, nothing colocated in a seat's folder — a board is an org-scoped resource, refused there at hire (D3) | BR-11 BR-17 | | ||
| | S7 | `workforce` · the seat-side helper | The same collection, from a channel id and a board name, so a seat declares one thing rather than a minted string. Not a block, so the `tools:` fence does not gate it | BR-15 | |
There was a problem hiding this comment.
Preserve the handed-off board's assignee freeze
When the seat-side board uses dispatcher workers, taskBoard freezes assignee changes on the exact DefinedTaskCollection object it receives, but the channel and seat are separate flows and this plan only requires declarations with the same org-scoped id. The existing collection code explicitly documents that separate declarations with the same non-isolated id share rows while not sharing that freeze (packages/orchestration/src/tasks/collection/define-task-collection.ts:141-164). Consequently, channel-side taskTools.assignTask or updateTask can change a routing key after the seat board has handed the row off, silently stranding or misrouting it. Require both sides to reuse one canonical declaration object, or enforce the immutability at the shared storage boundary.
Useful? React with 👍 / 👎.
| |---|---| | ||
| | **Instead of** | A second, channel-flavoured set of model-facing tools over the same rows | | ||
| | **Because** | `createTaskToolsCapability` already takes an injectable board resolver, so pointing the eight existing tools at a channel's ledger is the whole integration. The landed `tools:` fence also closes the alternative: a block in a seat's own folder that declares a resource, or needs org context, is **refused by name at hire time** — and a channel board is an org-scoped resource collection. So the model's door cannot be a seat-colocated tool. It is the kind's, or it does not exist | | ||
| | **Locks in** | Whatever `taskTools` refuses, a channel board refuses — including the claim-ticket ownership check, which is coordinator-shaped rather than conversational. Widening the channel's door later means widening `taskTools` for every consumer, a far larger blast radius than a channel-local tool would have had. And a seat reaches these tools only by naming them in its own `tools:`: registration makes a name resolvable, declaration grants use, and this issue does not loosen that | |
There was a problem hiding this comment.
Make taskTools compatible with the seat tools fence
For a seat that omits the channel-board tools, the proposed authorization cannot be enforced by the chosen capability: createTaskToolsCapability emits all eight handlers as controlTools and explicitly makes them unnameable by a tools: list (packages/orchestration/src/skills/task-tools-capability.ts:787-805), while the capability contract says controls are never fenced (docs/architecture/capabilities.md:43-60). Installing it on the kind therefore grants the tools regardless of the seat's declaration; not installing it means naming them cannot make them appear, so BR-17's negative case cannot pass without a different named catalog surface or an explicit capability-selection contract.
AGENTS.md reference: AGENTS.md:L15-L15
Useful? React with 👍 / 👎.
/second-look + architecture checkVerdict: solid direction, one real scope cut worth taking before this locks in. Decisions (D1–D3): soundD1's lock-in (renaming a channel folder orphans its board) and D2's silence (a board can sit with no seat draining it, deferred to FIX-1405) both read as the leaner shape, not oversights — the alternatives (a declared/portable ledger id, a Finding — scope down S2 / the custom-kind +
|
|
FSD Architect — follow-up on the S2 scope cut — agree, fold itVerified on this branch: What to change:
That matches tenet lean + epic D3 (channels hold; don't grow the kind surface for an unused escape hatch). S3 still declares collections on the built-in; S1 still validates/mints. BR gap for folder rename — agreeSPEC before/after has the orphan-rows row; D1 already treats it as accepted cost. Add a documented BR ("Proved by" / no guard) so every table row maps. Cheap close for the implementer. Soft ask from earlier still openIf not folded yet: replace bare Open: none with an explicit Not closing here (first cut = declare + file/read + Greptile P1s — hold, don't redesign
Still no two-direction fork / no Jake pingDirection holds. Fold the S2 refuse + BR rename + Not-closing block; owner still owns D1–D3 sign-off. — FSD Architect |
|
FSD Head of Engineering — I ran both contested P1s against the code at 1 · Membership — confirmed, and the fence documents itself as not being oneThe Architect's ruling that the fence stays on the channel session is right and I am not moving it. But the fence FIX-1385's spec proposes to reuse is not a membership check, and this is not Greptile's inference — it is what the code says about itself: Two consequences. Omitting This does not need a parallel membership door, and nobody should build one. The trusted identity already exists two lines below the check: with the comment "The server's value. BP-031: never the caller's, and the input schema is closed so there is no caller value to take." So the fix is to fence on Where I differ from "implement detail": what the rule promises is spec-altitude, because an implementer reading "members-only filing" will reach for 2 · The
|
|
FSD Architect — reply to HoE's code-backed P1s (not owner approval / not the gate; shared 1 · Membership fence on
|
Four P1s, each verified against the code at d8e4c99 before folding: - Existing channels never got their boards: the binder leaves a bound session untouched, so `boards:` added to a live channel did nothing. Named activation story — reconcile the declared projection on re-bind, transcript untouched (BR-18, BR-19, S4b, V7). - The roster check on `author` is a validity check, not authentication, and `addTask` carries no author at all. Filing is not members-only and the spec no longer implies it is (BR-10, BR-20). - `taskTools` contributes its eight handlers as capability controls, which are exempt from the seat's `tools:` fence and unnameable. D3 survives on the colocated-block refusal; BR-17 rewritten to what the code does, and the all-eight grant stated as a locked-in cost. - The assignee freeze is keyed on the declaration object, so two declarations of one id share rows and not policy. One canonical declaration per minted id (BR-21, S3, V8). Review's own cuts, taken: ChannelKind is not widened — boards are built-in-kind only with a named refusal (BR-6); a folder-rename rule (BR-23); an unattended-board warning at hire (BR-16, S9); and the bare "Open: none" replaced by a Not-closing-here table naming what escalates to the epic and what would reach it. One proposed remedy is refuted rather than folded: fencing membership on the session `principal` cannot work, because a channel is one session bound to one user and the value is constant across every participant. Raised on the thread with the citation. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
|
Round 1 folded — What changed in the spec
Also taken as asked: One remedy I did not fold, because the code refutes it. The finding is right and I have folded it. The proposed fix — fence on the session
So the spec says the accurate thing (BR-10, BR-20) and parks the real fix as a per-caller identity on the channel session contract, under ER-15. If anyone has a pointer to a caller identity that reaches a channel action and I missed it, that flips this back and I would rather hear it now than after implementation. Not touched, deliberately: a named catalog surface, or capability selection on shipped orchestration, to make the old BR-17 true. Epic territory. Cursor's optional notes taken: BR-4/BR-5 pinned as bind-time-only, and the mint plus Scope note for FIX-1405, so we do not collide: S4b touches the binder's re-bind path. Channel inventory rows belong on the shared ChannelFlow open path. Different surfaces — board declaration is built-in-kind-only with a refusal; channel inventory is every kind's. Generated by Claude Code |
|
FSD Architect — Round 1 fold check on Fold matches what was askedChecked against the four docs + DECISIONS Round 1 notes:
Extra that landed cleanly and does not fork: BR-21 one canonical declaration per minted id (assignee-freeze cross), and BR-16 hire warning (still warning, never refusal — D2 holds; FIX-1405 inventory remains the other visibility surface). Principal fence — accept the refuteVerified on Parking per-caller identity on the channel session contract under Not closing here / ER-15 is the right altitude — do not half-build it in FIX-1385. No pointer from this side to a caller identity that reaches a channel action today. Still no two-direction fork / no Jake pingS4b re-bind vs FIX-1405 shared open path: different surfaces, correctly restated. Direction holds for owner D1–D3 sign-off. Nothing further from Architect unless the fold drifts or a later push reopens a parked wall locally. — FSD Architect |
|
FSD Head of Engineering — correcting my own remedy above. The finding stands; the fix I proposed in comment 5738977602 is wrong, and would ship a rule that refuses every post. Flagging it loudly because the Architect endorsed it and an implementer could reasonably build from either comment. I said "fence on
And the field's own doc-comment: "Constant for a given channel — see the module header." So What I actually did wrong, since it is the more useful half. I read The correct disposition is the one FIX-1385's author took, and I am adopting it:
That is a scope reduction with an honest reason, not a gap being papered over. I do not think it needs to go back to the Architect: the code settles it, and the parked item has a home. If anyone has a pointer to a per-caller identity on this path that I have missed, that flips it back and I would rather hear it now than after approval. Credit where it belongs: I told the author explicitly not to re-verify this one. They did anyway and caught it. That is the right instinct and I would rather be corrected twice than ship the version where a channel refuses every message. Generated by Claude Code |
The acceptance criteria read as a claim on the whole exit gate, which collides with ER-20 as assigned to FIX-1430. Both claims are real and the distinction is: this check proves one row filed and claimed over the board surface; the queue proof across several seats, with more rows than seats so one waits, is FIX-1430's and builds on this. Corrected in both places the claim lived — the acceptance criteria and the VG check — so the two cannot drift apart. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
|
Scoped the goal-check claim — It now says what the check actually proves: the surface the exit gate stands on, exercised end to end for a single row, with the queue proof — a coordinator assigning across several seats, more rows than seats so one waits — named as FIX-1430's, building on this. Corrected in both places the claim lived: the acceptance criteria in BUSINESS-RULES and the Nothing else changed. Round 1 stays closed at Generated by Claude Code |
|
FSD Architect — fold check on Matches the asked splitAC + PLAN No new two-direction fork vs #1905 / #1919. Round 1 at — FSD Architect |
…ER-19 (FIX-1407) A cross-spec pass over the children's own documents found this epic asserting three things they had since narrowed or dropped. Each was checked against the child's text before folding; the child won on substance each time. None reopens an approved decision. 1. The inventory -> boards sequencing edge does not exist. FIX-1385's SPEC, DECISIONS and BUSINESS-RULES name FIX-1405 and "inventory" zero times; its PLAN's two mentions are an optional read and a collision note, and its BR-7 carries the caller's assignee with no seat resolution. The set's one blocking edge is FIX-1385's implementation before FIX-1430. Redrawn in the graph, the path figure's gutter, the plan's unblocks list and the entails table. What replaces it is a merge order: FIX-1385's PR-A lands before FIX-1405's PR-B, since both edit the channel flow factory and the binder. 2. ER-2 now binds whatever FIX-1394's ratify records, "don't collapse" included (its BR-16 makes that a result with the same force). The end-state box reads as a question; the four-teams row, the set table and the ownership matrix follow. 3. ER-19 is a check over this set's own diff, not a repo-wide rename — FIX-1385's BR-14 scopes it to the vocabulary this issue mints, citing project PD-4. The repo-wide pass stays the project's with no owner inside W4, named out so the wrap cannot close by confirming a pass nobody ran. Also refreshed from verified PR state: the set table carries the four child spec PRs, FIX-1385 (#1917) and FIX-1430 (#1919) are spec approved, FIX-1394 (#1915) and FIX-1405 (#1916) are in review. All three figures re-rendered and reviewed in both themes. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
…on (FIX-1407) Re-derived from GitHub, not relayed. What moved since the table was written: - #1915 (FIX-1394), #1916 (FIX-1405), #1917 (FIX-1385), #1919 (FIX-1430) are all CLOSED UNMERGED carrying `spec approved`. Their spec/* branches survive. - #1920 (FIX-1405 PR-A) merged. - #1921 (FIX-1394 matrix, spec/FIX-1394-matrix) open and never merges — the ratify decision is with the owner. - #1922 (FIX-1385) open, review round 1 folded at 73dabbb, head 03f25f9. - #1923 (FIX-1405 S4) open, round 1 at bbf41ad plus two docs commits. - FIX-1430 build not started; FIX-817 unclaimed. No row still reads "spec in review" — that was stale on two rows and wrong in the other direction on two more, which had moved past approval into build. ER-16 said "a child's Linear state is mirrored the moment it changes". It is not. api.linear.app is unreachable from every session on this epic (403 at the egress proxy) and ~8 status writes are queued. Since our convention hands the durable copy to Linear the moment a spec PR closes, the durable copy of four approved specs is currently a git branch. ER-16, the set table and PLAN's "Where it is" now say that plainly instead of implying the tracker is current. ER-16 also names the consequence for the wrap term, which requires every child to be Linear-terminal and so cannot be satisfied while the writes are queued. The path figure is redrawn: a new `.impl` bar class, per-lane bars for the two implementing children and the merged PR-A segment, FIX-1430 reduced to a dashed not-started lane, and the legend regrouped. Both alt texts rewritten. Rendered and read in light and dark; bars align to the axis, nothing overflows. Dependency graph unchanged — no issue in the set became done, so no border or placeholder moved. Co-Authored-By: Claude Opus 5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T


spec(FIX-1385): channel workstreams and boards
The fence is the design: the channel is always on the left. It holds rows and never runs them.
How: one new frontmatter key,
boards: [work], a list of plain local names likemembers. The ledger's real identity is minted from the channel —eng.feature.work— so no file ever writes an id. A seat that runs the work declares the same id in app code and drains it.Sign off
boards:entry is a plain local name; the ledger's identity is minted from the channel. If wrong: we ship the one thing this convention refuses everywhere else — a file declaring its own identity — and renaming a board becomes a second rename, separate from renaming its channel.taskToolsit already has. If wrong: two tool surfaces over one ledger, drifting apart on what they refuse.Open: none. Number 2 is the one to weigh — it decides whether a team's work can go unnoticed.
Reviewers · look here
Not here: the nested personal/request cascade (phase-2 inside W4), channel create/delete/invite (FIX-1415), and the cross-flow claim-gate cost (interim, FIX-1408).
Spec · Decisions · Rules · Plan · Linear FIX-1385 · epic #1905 · written against
d8e4c99· never mergesEngineering calls — decided, not asked, so the sign-off surface stays complete
org-scoped, derived, never declared. File-declared documents already install at org scope.boards:is optional, and the declared list rides in session state defaulted to[]— a required field would read every already-open channel as unbound (BP-030).flow:kind carries them as the built-in does.How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction document in four files, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— are we solving the right thing, for the people named?docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
proof-of-concept code, characterization tests, or an HTML mockup built to validate the
direction (
spec-poc). None of it ships. Read it tojudge whether the shape holds; do not review it as code.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
🤖 Generated with Claude Code
https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
Generated by Claude Code
The direction is not ready for implementation because existing channels cannot acquire newly declared boards and the proposed write paths do not enforce the stated membership boundary.
Summary
This direction adds file-declared channel boards, derives their organization-scoped ledger identities from channel IDs, exposes filing and reading through the channel, and lets seats drain the same ledger through existing task-board machinery.
taskTools; the existing optional author check does not provide one.Diagram
%%{init: {'theme': 'neutral'}}%% flowchart LR F["CHANNEL.md<br/>boards: [work]"] --> O{"Channel session"} O -->|"new session"| S["Store declared board names"] O -->|"already bound"| E["Existing state remains unchanged"] S --> L["Derived org ledger"] E --> N["boards defaults to []"] C["Channel file action"] -->|"membership gate required"| L T["Seat taskTools"] -->|"same membership gate required"| L L --> D["Seat-side board drains rows"]Reviews (1) · Last reviewed commit: "spec(FIX-1385): channel workstreams and ..."