Repository navigation
spec(FIX-1430): manager-queue lab — the proof that work reaches a seat #1919
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Closed
Changes from 1 commit
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
spec(FIX-1430): round 1 — routing claim gets an oracle, BR-6 goes obs…
…ervational Folds spec-level findings from Cursor, Greptile and Codex. - BR-4's negative control could not fail: it mutated the caller-supplied assignee-to-seat map, which PLAN declared the sole authority, so repointing it moved the correct destination along with the routing. The expected association is now held out in the tree (each worker seat's file names the assignee it answers for) while the host's map stays the implementation under test, and VG states the red state it produces. - BR-6 required a busy seat's second row to read `pending`. A hand-off claims a row before its child starts and leaves it `in_progress` (docs/architecture/dispatched-work.md, "The claim gate and the fence ticket"), so that reading is not guaranteed — and requiring it also settled the busy-seat policy D3 says this lab must only show. BR-6 now requires what holds at every drain width (nothing re-routes, nothing drops, the assignee is held) and records the status instead. - D3 dissolved: "shown, not chosen" means the lab is wired to run at either width from one switch, not that this issue's CI runs the queue twice. S8/V5 come off the merge bar; the two-width comparison lands when the epic asks. - PLAN pins assignee `eligibility` on every drain's claim. ClaimOptions narrows candidates before the CAS flip; omit it and a drain claims a row addressed to another seat, keyedRouter misses, and recordError settles the row `errored`. - Queued is the substrate's admission predicate, not `pending` alone, so an in_progress row with a lapsed lease is no longer in no column at all. The claim gate refuses adoption past the lease, so queued is where it belongs. Figure and alt text redrawn to match. - A missing tool grant is not hire-fatal: `tools:` grants use, so a seat that omits it hires cleanly and fails at filing. Taxonomy corrected, BR-2 kept. - The diff gate now rejects goals/devforce-lab/ — a behavioural suite cannot prove a tree unchanged. Q1 stays open and stays the owner's. The narrow shape it would pick is now a hard requirement of the plan so the gate cannot widen while it is open. Two SPEC-layout findings refuted and left open: spec-template.md governs a spec document's headings, and writing-for-humans.md exempts structural navigation from "nothing precedes the problem". Claude-Session: https://claude.ai/code/session_01PxDE76gD3BxXnPPjT7BT1T
- Loading branch information
commit 50af21c04d8da495cbbae535a474cafcdf3deea8
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Spec gate · Q1. Recommendation is already narrow; “Settled: none” leaves the exit gate one implementation choice away from devforce economics (×4 harness). I’d close this at spec review as narrow + small worker artifacts and reflect that in SPEC sign-off so VG can’t widen silently.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Half accepted, and the half I am declining is the one that is not mine to take.
Not closing Q1 here. It is the product owner's call and it is with him now. Closing it at spec review would be an agent settling a scope question about what the epic's exit gate means, which is the kind of decision the gate exists to put in front of a person.
Settled: nonestays accurate — no claim here has been argued twice, which is the bar for a settlement.Accepting the thing underneath it. Your actual worry is that the exit gate sits one implementation choice away from devforce economics while the question is open, and that is fair — an open question is not a licence to widen. So the narrow shape is now a hard requirement of the plan rather than a recommendation waiting on an answer: stub worker handlers doing small deterministic work, one model surface (the coordinator only), pentest-style poll and timeout fixtures. It is a guardrail with a because, not a note.
DECISIONS.mdrecords this under Q1 explicitly — what is fenced while the owner decides, and that if the answer comes back wide, that is a change to make then, deliberately and with the cost visible. Not a door left open now.So VG cannot widen silently, which is what you were protecting. It just does not cost the owner his question. Leaving this open since it tracks a live gate.
Generated by Claude Code