Repository navigation
spec(epic): W5 amendment — three producers named, checklist row 5 re-owned (FIX-1457) #2033
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from 1 commit
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
a3347bf
spec(epic): W5 amendment — three producers named, checklist row 5 re-…
claude 0161354
spec(epic): correct the row-5 mechanism to the naming gap (FIX-1457)
claude c789af5
spec(epic): the gap is selection, not access — match #2037's wording …
claude c1fd770
spec(epic): fold the POC settlement into Open 1 (FIX-1457)
claude efa779f
spec(epic): strike the ER-25 justification from row 5's blocked cells…
claude 2300b89
spec(epic): make the rest of the set agree with Open 1 (FIX-1457)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
spec(epic): the gap is selection, not access — match #2037's wording …
…(FIX-1457) Third pass on the same passage. The previous version still overstated it: "which org is a question the surface cannot currently be asked" is wrong, because the surface CAN be asked — it just always answers with the same org. Corrected in all five places the set repeats it (BUSINESS-RULES.md, SPEC.md, DECISIONS.md D1 addendum and Open 1 plain-terms, PLAN.md, EVOLUTION.md), matching #2037's re-derivation per the Architect's sibling gate. The chain that survives, verified end to end on origin/main: - the three inventory collections are scope:"org"; - an org-scoped read takes its storage key from the execution's orgId (createExecutionContext -> resolveOrgStorageKey), which is the org the session carries; - that org is set once at creation from the configured resolver, with body.orgId never consulted (FIX-1442); - the listing has no orgId query fallback by design. Two corrections to my own previous text: - The short-circuit is not that anonymousFlowIds is merely unset. authorizeManagementRoute returns ALLOWED at its FIRST guard when the host is on the default resolver and nothing authenticates, so the anonymous branch is never reached; the branch that is reached in a mixed app always returns a Set. So `allowed === undefined` means "no flow in this app authenticates". - The listing clause is dropped rather than repaired. handleListSessions lists sessions; the rule is about reading inventory resources. It did no work in the argument even when true. Also removed an unverified premise I had asserted: that nothing under packages/devtool, packages/fsdev or apps/devtool configures a resolvePrincipal. No single artifact is confidently "the shell flow", so the text is conditional now — "where no resolver is configured it is DEFAULT_ORG_ID" — which is true of the code regardless of which app is meant. ER-26, the producers, row 5's re-owning and the conclusion are unchanged. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_016qaz1VpRK4wCQzxpjzZ4Hz
- Loading branch information
commit c789af5cc737d66fd181f52bc32f7ceaf77304bb
Some comments aren't visible on the classic Files Changed page.
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Simplify / altitude: The blockquote about this amendment’s wrong drafts (
handleListSessions, #2037) is valuable forensic history but heavy inside BUSINESS-RULES (children inherit this file as rules, not changelog).Recommend moving to
EVOLUTION.md(you already have a 2026-09-22 row there) and leaving one invariant here: “gap is org selection, not access; do not cite closed BP-031 hole.”