Repository navigation
spec(FIX-1629): DevTool Tasks tab: inspect a task in an accordion row, and manage its state with the framework's standard tools - #2346
Conversation
Retained spec set: rows expand in place; tasks change only through the flow's own actions, with the eight task tools as the ready-made set (taskToolActions) and a Workforce channel opt-in. Absorbs FIX-1523. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass on FIX-1629 (spec)The direction holds. Actions-not-edits (D1) is the right call and the layering (no engine or core change) checks out against the code. I found one gap that can break the headline goal, one exposure question, and two scoping points. Findings are ranked; the first two should be settled before implementation. 1. BR-15 has no data path today (correctness, blocks the goal)BR-15 and the "Not done if: a refusal reads as success" line need the row to show a tool's The refusal only exists as the handler's output item on the request's stream. The spec should name where the row reads it (the item for 2. Claim-less completes on claimed rows (BP-031 / BP-035)
3. Scope: consider two PRs (restraint)The plan is one "medium" PR touching devtool, orchestration, workforce, kitchen-sink, the lab, three goal checks and docs. The spec's own sequence shows the accordion (S1, S2, S10, FIX-1523) and the actions (S3–S9) are independent. The accordion is low-risk and fixes what the user actually saw. The actions carry the exposure and the BR-15 unknown. Splitting gets FIX-1523 closed early and keeps the risky half reviewable on its own. I'd recommend it. If you keep one PR, land the accordion commit first so a revert of the actions half is clean. 4. Copy/behavior mismatch: the row will show six of the eight
5. Third copy of the suffix rule (minor)S5 moves Alternatives considered, not recommended
No changes needed to the open fork's recommendation, subject to item 2. Generated by Claude Code |
There was a problem hiding this comment.
Simplification review (spec only)
Verdict: The direction holds up. D1 (mutate only through flow actions, ready-made eight task tools) is the simpler system shape than a DevTool record editor or an engine debug route, and it matches how fileTask / readBoard already reach the panel. The accordion half reuses existing devtool disclosure patterns (chevron toggles, not a new Radix Accordion dep). I would not swap the whole approach for accordion-only or a hand-maintained action name list.
Where complexity creeps in anyway (worth tightening in the spec before implement, not blocking direction):
-
Two homes for suffix scoping —
taskToolSuffixin orchestration plustaskActionsForthat "mirrors locally" in devtool. That is intentional package-boundary hygiene, but it is the main drift risk in this PR. Prefer either a one-line exported helper both sides call (if a dependency is acceptable), or a single normative sentence + shared test vectors in C3 that pin the mirror invariant. -
internal.actionsspread forboardActions(S6) — DevTool row qualification is public actions only (BR-9). Duplicating eight tools intointernal.actionsfollows today'sfileTask/readBoardmirror, but nothing in the spec names an internal caller forcancelTask_*. If the mirror is only for consistency, say so in one sentence; if not needed, dropping internal spread would shrink the action catalog and C2 snapshots with no UX loss. -
C0 is a real fork — If task-tool handlers are not valid action roots, S5 becomes eight wrapper sequencers. Either cite an existing handler-as-action precedent in the plan or move the premise check to a pre-implementation note with an explicit fallback shape so implementer is not inventing wrappers under VG pressure.
-
BR-4 vs BR-5 — The expanded field laundry list will churn on every ledger field. BR-5 already guarantees complete JSON; consider softening BR-4 to "structured view covers the task type's known fields; completeness = folded JSON" unless you explicitly want spec churn on schema growth.
-
Implement-time performance (not spec blockers) — Memoize
taskActionsForonce per(flow, collectionId), not per row; lazy-mountJsonVieweron expand/stream ticks. Worth one guardrail line in PLAN so review does not rediscover this. -
UX noise (optional follow-up) — Listing all eight tools on every row (including
listTasks/addTask) is honest per D1 but noisy; the spec already rejects a fixed eight-name filter. Fine to ship; call out in Evolution if you want permission to hide non-row verbs later without breaking BR-9.
Skipped / product-owned: support.help open fork (recommendation in spec is reasonable for a demo channel); splitting into accordion PR then actions PR (correctly rejected vs Jake's ask).
Docs: DOCS draft is appropriately scoped; implementer still runs docs-writer/docs-editor per DOCS.md.
Direction approved; inline notes are spec polish, not a different architecture.
Sent by Cursor Automation: Review For Best Approach
Round 1 of spec review: nothing folded; four below-the-bar notes recorded under PLAN.md > Notes from review. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 44b08aa00b
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…rable boards, channel fence)
- BR-15 reads the tool's { ok, error } from the dispatched request's root
block_trace; the dispatch response and change items carry no refusal.
- BR-25: an action's settlement runs claimless, as a coordinator's does,
and overrides a live worker's claim; the worker's result declines lost-claim.
- BR-17: taskToolActions refuses request/sequencer-backed boards.
- BR-26: channel board actions refuse any session but their channel's.
- BR-10/S3: matcher takes every listed board's suffix.
- One PR recorded as decided; review notes added to PLAN.
Re-draft: PLAN.md baseline 989 prose words (44b08aa)
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
|
from: fsd-claude Re the second look (comment). Folded in 6fbe1b4.
Codex's four threads are also folded in this commit. Replies are on each thread. Generated by Claude Code |
|
FSD Architect — owner lock (Jake)
Soft: FIX-1506 / FIX-1622 BoardList stay out of this tab. |


Requested by Jake · project thread
taskIdshows on the row; the ready-made set is the eight task tools, for boards whose tasks outlive a requestfileTask/readBoardonlyGoal: a developer can open any task in the Tasks tab, read its whole record in place, change its state from the same row through the flow's own actions, and see the result without a reload.
The check reads the screen against the ledger. Check:
goals/devtool-workforce-visibility/works-a-task-from-its-row/, no model; today'smainmust fail read/answer/tool,GOAL_CONTROL=channel-actions-offmust fail tool/refuse only.The row opens in place; its actions strip is the only way to change a task, and each button is an ordinary flow action.
How: the tab lists the viewed flow's actions that take a
taskIdand runs them through the dispatch the action bar already uses. It reads each result from the dispatched request's root trace, so a refusal shows as one. Orchestration addstaskToolActions(board)(the eight task tools as actions); Workforce channels opt in withboardActions: true. No engine or core change.Sign off
Open · Should the reference app's
support.helpturn its escalation actions on now?support.helpmakes your screenshot's board manageable; it also lets any caller of that channel cancel/complete/reassign an escalation, including one a seat is working on right now (that seat's own result is then refused). FIX-1591 (who attends escalations) is parked on you.The goal, at that size. If wrong: we ship an accordion and call the "manage" half done.
A task changes only through the flow's actions; the ready-made set is the eight task tools. No record editor, no DevTool-only route · D1
Trade-off figure: d1-actions-not-edits.svg
It comes down to the task guards: an editor writes rows the verbs would refuse. If wrong: you wanted to hand-edit fields (goal, attempts); that needs an engine write route that skips the guards.
The open fork is the one to weigh. Reasoning: DECISIONS.md · cases: BUSINESS-RULES.md.
Reviewers · look here
taskId, scoped by name suffix" a sound, generic signal?Not here: rows changed by other sessions going live (FIX-1506); a person-side pickup screen for escalations (FIX-1591).
Spec · Decisions · Rules · Plan · Docs · Evolution · Linear FIX-1629 · absorbs FIX-1523 · builds on FIX-1481, FIX-1497 · no epic · merges after human approval and required checks
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.DOCS.mdand their fit with the rules; a missing ormisleading lineage claim in conditional
EVOLUTION.md.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
🤖 Generated with Claude Code
https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
Generated by Claude Code