Repository navigation
POC: compose a board's capability once and drop the row id hash - #2349
Closed
cursor[bot] wants to merge 11 commits into
Closed
cursor[bot] wants to merge 11 commits into
cursor[bot] wants to merge 11 commits into
Conversation
The Tasks tab's table becomes a list of disclosure rows. A collapsed row leads with status, then goal and reason sharing the width as minmax(0, 1fr) tracks, so the reason stays in view on a laptop-width pane (absorbs FIX-1523). Clicking the row, or Enter/Space on it, opens it in place: every field the task carries, with the raw record folded at the bottom. Open rows are keyed by board and task id and held above the rows, so a streamed change never closes one. The floating <details> JSON expander and its fixed 28rem block are gone. FIX-1481's reason tests are re-pointed from the Reason column to the row's reason slot; the presence predicate and verbatim text are kept. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…actions (FIX-1629)
taskToolActions(board) returns the eight task tools as a flow actions map,
named <tool>_<suffix>, each running the same guarded verb a model's tool
does. A refusal comes back as { ok: false, error } and writes nothing; it
is readable from the root block_trace of the request that ran it. No
action claims or drains the board, and an action settling a row a worker
holds lands like a coordinator's call, so the worker's own result is then
declined.
Request- and sequencer-backed boards are refused by name: their rows do
not outlive the request that filed them. Each handle-form action composes
the board's capability, so the ledger is installed without the flow
declaring it again. taskToolActions(collectionId, resolve) serves a caller
that resolves its own ledger. taskToolSuffix is the one qualifier rule.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…ns (FIX-1629) A CHANNEL.md may declare `boardActions: true` (the seventh key in the closed list, boolean only, refused by name otherwise). Each of that channel's boards then gains the eight task tools as channel actions, named <tool>_<board id with dots as underscores>, built with orchestration's taskToolActions. Channels that say nothing keep exactly today's actions. Channels share one flow, so each action first checks the session is the board's own channel, then resolves the ledger through the same check fileTask and readBoard make; another channel's session is refused before any row is read. The local boardToolSuffix copy is replaced by orchestration's taskToolSuffix. The reference app's support.help opts in, so its escalations can be worked from the DevTool's Tasks tab. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…(FIX-1629)
An open Tasks-tab row lists the viewed flow's actions whose input requires
a string taskId. A board's suffixed task tools show only on that board's
rows; a generic action such as an app's `answer` shows on every board.
Picking one opens its form in the row with taskId filled and locked, and
submitting runs it through the panel's existing action dispatch, the path
the action bar uses. There is no other write.
The dispatch answers with a request id and no output, and a refused verb
writes nothing, so the row reads the tool's { ok, error } from the root
block_trace of the request it sent: success, a refusal in the tool's own
words, a failure, or "outcome isn't visible" when the request left no
trace. A dispatch that throws shows its message and keeps the form filled.
handleSendAction now returns what it dispatched; useActionDispatch
resolves a thrown dispatch to { error }. SchemaForm gains locked fields.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
… (FIX-1629) New goal devtool-workforce-visibility/works-a-task-from-its-row: on the multi-seat-collab hire, in Chromium on the shipped DevTool at 1280x800, the parked row is read collapsed and open, answered through the seat's own action, and a board task tool is run and refused from the channel's row. The lab's channel opts in with `boardActions: true`; GOAL_CONTROL= channel-actions-off hires it as if it had not. The two existing checks that read the Tasks tab's Reason column now read the row's reason slot by task id. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…tions (FIX-1629) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…X-1629) The spec's failure taxonomy: a render error in one row must not blank the tab. Each row now sits in its own boundary, which shows a one-line note in the row's place and retries when the task changes. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
… again (FIX-1629) Running an action a second time left the first run's "Done" on the row until the new dispatch came back, so a refusal read as success for that long. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…r (FIX-1629) Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
taskToolActions installs the board capability through handler.withDefaults instead of spreading uses into all eight tools. A Tasks-tab row uses useId for aria-controls, and the open body no longer has a dispatch-run field nothing renders. Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
| /** Whether the open row's text for one field shows the ledger's value. */ | ||
| function shows(key: string, shown: string, value: unknown): boolean { | ||
| if (key === "attempts") return shown.split("/")[0]!.trim() === String(value); | ||
| if (typeof value === "object" && value !== null && !Array.isArray(value)) { |
| * cannot pass by matching the same words somewhere else on the page. | ||
| */ | ||
| import { describe, expect, it, vi } from "vitest"; | ||
| import { render, screen, within } from "@testing-library/react"; |
jhoffner
pushed a commit
that referenced
this pull request
Sep 28, 2026
…prop, one withDefaults (FIX-1629)
The row's aria-controls id comes from useId() instead of a hash of its key.
TaskRowBody's dispatchRun prop is gone; nothing passed it and the run link
sits on the collapsed row. buildTaskTools applies the board capability once
through handler.withDefaults({ uses }) instead of spreading it into all
eight tools. From the draft POC #2349.
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Tasks-tab row hashes its open-state key into a DOM id, and the open body still has a dispatch-run field nothing passes. The board capability is also copied onto all eight task tools for one caller.
Subtracted:
bodyIdOf. The toggle'saria-controlstarget comes fromuseId().TaskRowBody'sdispatchRunprop. Nothing passed it. The run link stays on the collapsed row....withUsesspreads.handler.withDefaultsapplies the board capability once insidebuildTaskTools.Still passes:
@flow-state-dev/devtool:task-collections-rows,task-row-actions,task-collections-view,task-collections-reason,task-actions(45 tests).@flow-state-dev/orchestration:task-tool-actions(13 tests), including the flow that does not declare the collection.This PR does not merge. It is a smaller shape of #2347. Fold the subtraction into that branch, then close this unmerged after the original lands.