Repository navigation
spec(FIX-1629): amend BR-25 and C1 — the displaced worker's settlement declines terminal - #2355
Conversation
…t declines terminal Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second-look / architecture reviewSpec-only, 3-line amendment. The core correction holds up against the code: One thing to fix before this merges: the "today the reason is
Nit: DECISIONS.md line 77 now runs well past the wrap width of the surrounding bullet. Re-wrap it. Generated by Claude Code |
There was a problem hiding this comment.
/simplify review
Verdict: The direction is right and I’m approving. The old text was wrong: when a coordinator-style action finishes a held row, the worker’s late fenced settlement declines with reason terminal, not lost-claim — that matches transitionDeclineReason / advisory-write behavior in orchestration today. PLAN C1 and DECISIONS are the right places to pin the held-row proof and the “action overrides claim” intent.
Where this went a bit far: BR-25’s Then cell is doing three jobs at once — correct terminal vs lost-claim split, a blockTask legality aside, and a “so today the reason is terminal” implementer note. That makes the WHEN row (blockTask listed among verbs that “run” on a held row) fight the THEN footnote. A cleaner spec change (same behavior, less table prose) would be:
- Narrow BR-25 WHEN to
completeTask,failTask, orcancelTaskon a row a live worker holds (dropblockTask; illegal moves stay BR-18 only — C1 already testsblockTask_xas illegal transition). - Shorten BR-25 THEN to: action runs unguarded (no claim); worker’s later claim-fenced settlement is declined and dropped with reason per existing task-substrate precedence (
terminalif the row is already terminal; elselost-claimwhen the ticket no longer owns the attempt). Avoid re-defining reasons in the epic table — point at published substrate docs /transitionDeclineReasoninstead of “today …”. - Keep the two-reason split in DECISIONS (and optional PLAN note); if CI only exercises
completeTask_x→terminal, that’s fine — mention softfailTask→ workerlost-claimin C1 only if you want CI to prove the “otherwise” branch.
Skipped (not worth blocking): collapsing duplicate DECISIONS + BR-25 prose; adding a second C1 case for soft-fail lost-claim; terminology pass on “declines terminal” vs “declined/ok:false”.
Performance / reuse: N/A for this markdown-only diff; substrate already owns the vocabulary — reuse it rather than growing BR-25.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 1e71a47797
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…es lost-claim Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…ains the retryable failTask leg After a retrying failTask re-queues a held row, the displaced worker's completion declines `disallowed` and its failure `lost-claim`, neither writing (task-tool-actions.test.ts on #2347). Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
|
@codex review Generated by Claude Code |
|
Codex Review: Didn't find any major issues. Can't wait for the next one! Reviewed commit: ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |


This amends the merged FIX-1629 spec, following orchestration.md "Merging and amending a spec". The implementation is #2347.
What changes
BR-25, PLAN C1 and the matching DECISIONS bullet said that when a row action settles a task a worker is still running, the worker's own result is later refused as
lost-claim. That is not the whole story. The task substrate gives a reason that depends on what the action did to the row:terminalwhen the action finished the row (complete, cancel, or a fail with no retries left). The substrate checks whether the row is settled before it checks the claim, and that order is deliberate.lost-claimwhen afailTaskwith retries left returned the row to pending.BR-25 now names only
completeTask,failTaskandcancelTask. AblockTaskon a held row is an illegal move, so it belongs to BR-18, and C1 cites it there.Scope
This corrects a fact; it does not change direction. The behaviour is the same: the action lands, and the worker's result is refused and dropped.
Evidence
Both tests are in
packages/orchestration/test/task-board/task-tool-actions.test.tson #2347:completeTask_xon a held row, followed by the worker's settlement, produces exactly{ outcome: "declined", reason: "terminal", status: "completed" }.blockTask_xon a held row is refused asillegal_status_transition.The soft-fail route (
failTaskback to pending while retries remain) is intask-tools-capability.ts, where it goes throughshouldRetryOnFail.🤖 Generated with Claude Code
https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N