Skip to content

spec(epic): the public release installs, and holds its boundaries (FIX-1635) - #2360

Merged
jhoffner merged 3 commits into
mainfrom
epic/hard-gates
Sep 29, 2026
Merged

jhoffner merged 3 commits into
mainfrom
epic/hard-gates

Conversation

@jhoffner

@jhoffner jhoffner commented Sep 29, 2026 •

Copy link
Copy Markdown
Collaborator
A team that… Today After this epic
installs FSD from npm 0.1.1 failed on its first import; nothing in CI installs a packed tarball and imports it Every published package imports from a clean install, and DevTool ships its client assets
puts several users in one tenant A caller who knows another user's request or session id can reach that record, its items or its sandbox An id a caller chooses is an address, never an ownership
exposes flows over public HTTP Re-entry, sibling-flow listings and cross-flow dispatch each trust something the caller controls Each admits on the stored record and the target flow's own rules
runs work on a queue host (BullMQ) Delivery into an existing session is refused The recipient runs under its own concurrency policy
calls a generator without streaming A multi-step turn returns only its last step's text The same text as the streamed turn

Goal: someone who installs FSD from the packed release can import every package and run a server, and none of the holes this epic names can be reached over real HTTP.

flowchart LR
  A["pack every package · install into an empty project"] --> L1["leg a · import each, start a server · standing CI job"]
  L1 --> L2["leg b · the children's HTTP suite · two users, one tenant, one case per hole"]
  L1 --> L3["leg c · BullMQ host with real Redis"]
  L2 --> R["what each caller gets back"]
  L3 --> R
  R -->|"every leg holds"| P["PASS · the epic's goal is met"]
  C["control · the 0.1.1 tarball for leg a"] -.-> R
  R -.->|"under the control"| F["must FAIL · names its leg"]
Loading

Leg a is the one no child's own test reaches: 0.1.1 passed every source test. It becomes a standing CI job when FIX-1431 lands it, and each child proves its own HTTP case fails on the commit before its fix. Proved by the closure issue FIX-1636's goal check on one main commit. Why this goal: SPEC.md.

What's in the box: the release loads, an id is an address, entry points admit on the stored record, guards hold, queue-host delivery, one turn one text. Fence: no Workforce word below Workforce, org stays required, no refusal deleted without its guarantee. Not built: first-hour DX, Tier B leftovers, Workforce adoption, kitchen-sink polish

Inside the box is what any app gets from the release without writing a line. The fence keeps a hard-gates epic from turning into a redesign.

Why now. The release is the first time someone outside this repository runs FSD. A leaked record or a package that won't import is found by the first user, and costs trust before any feature is judged.

The set: twelve child issues, locked by the owner with the FSD Architect, plus the closure issue. Request and session ids, re-entry, sibling-flow reads, cross-flow admission, the packed release, queue-host delivery, non-streaming text. As of 2026-09-29: 2 done (FIX-1256, 1261, with FIX-1510 under 1261), 10 open, the closure filed; the set table links live Linear state.

The path: shipped fixes, this spec in review, a wide first step of reproductions, fixes and two specs, FIX-1286 and FIX-1634 implementing after FIX-1018, then the closure run

Almost everything starts at the gate. The critical path is FIX-1018, then FIX-1634's implementation, then the closure run.

Who owns what: thirteen rules by the open children and the closure issue, each with one owner; FIX-1286 and FIX-1634 consume FIX-1018's binding, FIX-1334 builds on FIX-1431's leg a job, and the closure runs the children's suite

Every rule a child builds has one owner. FIX-1286 and FIX-1634 build on FIX-1018's binding instead of inventing their own.

Sign off

These twelve are one epic with one release-shaped proof · D1

One epic with a closure run, chosen, beside twelve fixes proved from source. Decides it: a package that fails on import passed every source test. Price: a closure run that packs, installs and needs Redis

It comes down to 0.1.1: every source test passed and the first import failed. If wrong: we spend a closure run on fixes that were each fine alone.

FIX-1018 lands first; a caller's request id is bound to its owner · D3

FIX-1018 binds the id first, chosen, beside FIX-1286 deciding first and beside re-keying the workspace. Decides it: a confirmed cross-user read whose fix answers FIX-1286's question. Price: FIX-1286 and FIX-1634 wait to implement

It comes down to a confirmed leak: a design question should not hold its fix. If wrong: FIX-1286 and FIX-1634 wait a few days on a fix they didn't need.

What would change my mind on D1: the release not going to external users soon. Recorded, not asked: D2, each worker reproduces on current main first, records the result on its Linear issue, and a hole already closed closes with a regression test. Reasoning: DECISIONS.md. Rules: BUSINESS-RULES.md.

Open: none. Merging this PR is the approval.

Reviewers · look here

  • Is the closure worth its weight? It packs, installs, serves over HTTP and needs Redis. Round 1 made it lighter: leg a is a standing CI job it reuses, and each child proves its own control, so the closure never rebuilds an old commit.
  • ER-3 now covers stream attach and resume. A request id stops being a capability token; FIX-1018 amends state-and-scopes.md (EVOLUTION.md).
  • Several tickets may already be closed on main. FIX-1431, 1334, 1021 and 1328 predate passes that look like they fixed them. D2 makes each worker prove it with a test instead of rewriting code.

Not here: any single issue's approach. Those are the spec and implementation PRs.

Spec · Decisions · Rules · Plan · Docs · Evolution
· Linear FIX-1635 · Project: Public Launch · merges after human approval and required checks

How to review this — an epic-spec, not an implementation plan

This is an epic-spec: the shared objective and cross-cutting decisions for a set of
issues, in a retained document set. It is not any one issue's implementation design.

In scope to challenge:

  • The objective and the goal in SPEC.md — is this body of work worth doing, and is the
    goal the real need at full size, or a smaller one the set could meet while the need stays
    unmet? Would the closure issue's check fail if the goal were not met?
  • Whether the set overbuilds. Each issue can earn its place while the whole is too much.
    That question can only be asked here.
  • A cross-cutting decision in DECISIONS.md — shared surface, naming, sequencing, contracts.
  • A rule in BUSINESS-RULES.md with no owner, or two.
  • A missing issue the objective implies, or one in the set that doesn't serve it.
  • Shared promises and publication ownership in DOCS.md; missing or misleading
    predecessor treatment in conditional EVOLUTION.md.

Out of scope — owned by the individual issue specs:

  • Any single issue's approach, architecture, file layout, or test plan.
  • Anything that touches exactly one issue. It belongs on that issue's spec PR.
  • The figures, at the pixel level, and routine status movement since the dated snapshot.
  • POC production polish. End-state experiments under the owning spec's poc/
    show shape and scoping, not shippable implementation. Directional evidence, experimental
    isolation and absence of secrets/generated dependencies remain in scope.

Feedback in the second list is routed to the issue it concerns as an implementer note, not
folded in here.

Required repository checks, approvals and review-thread policy still govern merge.
Optional comments are triaged, not a reason to grind to zero or restart the design review.

🤖 Generated with Claude Code

https://claude.ai/code/session_01HNTQkGXCUryuVD2TEBLi6G

The retained epic set for FIX-1635: the goal (the packed release installs,
imports and holds its security boundaries over real HTTP), the locked
child set with routes, three cross-cutting decisions (one release-shaped
proof, reproduce-first, FIX-1018 lands first), rules with owners, the
path, the shared docs narrative and cross-child lineage. Closure issue
FIX-1636 filed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNTQkGXCUryuVD2TEBLi6G
@vercel

vercel Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Sep 29, 2026 12:29pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Sep 29, 2026 12:29pm UTC
flow-state-dev-ui Ignored Ignored Preview Sep 29, 2026 12:29pm UTC

Request Review

@linear-code

linear-code Bot commented Sep 29, 2026

Copy link
Copy Markdown

FIX-1635

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 29, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-29T12:21:26.364427Z 5132f36 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

Copy link
Copy Markdown
Collaborator Author

Second-look + architecture review (spec PR #2360)

Scope note: this is an epic-spec, so this review stays at set level. Feedback that touches one child is marked → implementer note and belongs on that child's spec/PR, not here. Nothing below blocks the direction; items 1–3 are the ones I'd fold into the spec.

Second look: is there a leaner or better shape?

1. Leg a should be a standing CI gate, not just a closure step (fold in).
The goal check runs once, on one main commit, at closure. But ER-1/ER-2 ("packed → installed → imports; DevTool serves assets") regress silently after closure — that is exactly how 0.1.1 shipped. The cheapest form of leg a is a small pack→install-empty-project→import job in ci.yml/release.yml, landed by FIX-1431/FIX-1334 (the owners of ER-1/ER-2), with closure reusing it. Today PLAN says closure delivers "the committed release check", which makes the only consumer-shaped check the most expensive and last child. Suggest: assign the CI job to FIX-1431 (ER-1) and have FIX-1636 add legs b/c on top of it. Same closure proof, permanent protection, and closure gets smaller.

2. Leg a's control ("last published npm version") is unstable.
Once anything newer than 0.1.1 is published (FIX-1161 publish work is adjacent), "last npm release" may pass and the control stops failing. Pin the control to 0.1.1 (or a recorded tarball) so "must FAIL" stays meaningful.

3. Leg b's controls and ER-16 describe two overlapping tests per hole (fold in).
ER-16 already makes every child land a regression test that fails on the commit before its fix. Leg b then re-proves each hole over HTTP against "the commit just before its fix merged", which requires the closure harness to build/run historical commits, including for fixes that shipped before the epic. That is the heaviest, most brittle part of the closure. Leaner: have each direct child land its two-user HTTP test into a shared harness location as part of its own PR (ER-16 made concrete: "over HTTP, as user B"), and let closure run that suite against packed tarballs. The "fails under control" property is then established once, by the child, at fix time, instead of re-derived by checking out old commits at closure. Also finds a wrong test early instead of at the end.

4. FIX-1286 as spec→impl may be paying for a design PR the answer might not need. (→ decision for the epic wake, low stakes)
D3 itself says 1286 "may close as proved by FIX-1018" and PLAN sizes it "Small, or none". A spec PR for something that may be a test is the heaviest route for the likeliest outcome. Consider making 1286 direct-route after 1018 merges (reproduce, then only escalate to a spec if a shared workspace survives per-owner records — which is already D3's stated mind-changer). Costs nothing now; the spec can be started at the gate but is optional.

Architecture: is this an opportunity to consolidate rather than add three copies?

5. Owner-scoped lookup should be one primitive owned by FIX-1018 (fold in).
ER-3 (request), ER-5 (session), ER-7 (sibling-flow requests/items) and ER-6 (re-entry) are all the same shape: look up a stored record, admit only if the caller's principal owns it, otherwise not-found with one shape. The PLAN's seam table sends FIX-1022 and FIX-1046 to createExecutionContext and says "each adds its own binding beside user, tenant and org; whichever lands second rebases, never merges the two", and notes not-found should be "one shape across all three". Three children independently adding checks in createInboundTransportHost, createExecutionContext, and the routes (resume-routes.ts, http-handlers.ts, initial-request-record.ts) is the recipe for three subtly different admission behaviours and a fourth hole later.
Recommendation: make FIX-1018 (already first, already gating) introduce a single engine-level owner check (e.g. one helper that resolves a record for a principal or returns the canonical not-found), record it as an owned rule (new ER, owner FIX-1018), and mark FIX-1022/1046/1021 as consuming it in the ownership figure the way 1286/1634 consume ER-3. That trades a slightly larger FIX-1018 for removing the rebase seam and the "one shape" coordination rule, and it fits Tenet "one obvious way" better than parallel bindings. If FIX-1018's reproduction shows the paths are too different to share, the child says so — but the default should be shared.

6. Same for ER-8 (cross-flow admission "exactly as ingress would"). (→ implementer note for FIX-1328)
The rule is best met by the seam calling ingress admission rather than reimplementing org/rule checks beside it; otherwise the next change to ingress admission re-opens this hole. Worth stating in FIX-1328's worker brief.

Smaller notes (non-blocking)

  • D2 / ER-17 "closes with a test, not a rewrite" is the right call. One addition: the reproduction's result (reproduces / doesn't, on which SHA) should be recorded on the Linear issue so the closure can cite it instead of re-deriving which holes shipped before the epic.
  • ER-14 vs FIX-1634: "what still can't be honoured is refused by name" plus "no refusal deleted without restating its guarantee" is good; make sure FIX-1634's spec names the FIX-1302 external-dispatcher refusal's guarantee explicitly since it narrows it.
  • Closure needs real Redis: fine, but say where it comes from in CI (service container vs. testcontainers) in the FIX-1636 QA plan so it is not a local-only leg.
  • Verified PR shape: 12 files, spec-only, no code changes; not-here scope (FIX-1161, Tier B, Workforce adoption) is stated and consistent with ER-13/15.

Net: direction is sound and the D1 argument (0.1.1 passed every source test) is convincing. The main improvement is moving the cheap, durable check (leg a) earlier and standing, letting children own their HTTP tests, and consolidating the owner-check into one primitive instead of three parallel bindings.


Generated by Claude Code

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coherence check (FSD Architect) — not owner approval / not the gate. Shared jhoffner login can look like product-owner sign-off; this is approach/coherence only. Spec/epic gate already passed; this stamp is holistic fork-check only.

Verdict: No two-direction fork. This is the sole open spec(epic) for FIX-1635 / hard gates. It sits cleanly under #2359 (Public Launch project-spec, stamped coherent earlier today) and does not compete with it.

Matches locked graph:

  • Child set — Jake+Architect lock (1634, 1431, 1018, 1286, 1021, 1022, 1256, 1510+1261 as one outcome, 1046, 1328, 1334, 1628) plus proof-child FIX-1636. Linear nesting agrees; 1510 stays under 1261, not a 13th feature.
  • Placement — Public Launch cross-cut; invent-kills nest under FIX-1161 / Done FIX-1592; soft-related FIX-1161 only as parallel first-hour track.
  • Closure framing — FIX-1636 = pack→install→HTTP proof-child / mayWrap (1596/1601 spine), not a feature gate. D1/D2/D3 and the stranger-harm fence match PD-2 on #2359.

Does not fork: no second hard-gates epic-spec; #1312 (FIX-548) stays first-hour; Tier B / KS polish / Ops / L2 adopt for 1634 correctly fenced out. Soft note only: #2359’s “2 of 12 children done” snapshot lags this PR’s accurate “3 done” (1256/1261/1510) — refresh on the project-spec when convenient; not a product conflict.

No Jake ping. Coherence/approach only — human owner still owns merge of this never-merge epic-spec.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Simplify review (spec-only PR)

Verdict: approve direction. Scope, D2 (reproduce-first), and D3 (FIX-1018 before 1286/1634) are the right complexity reducers. The locked issue set and HTTP consumer bar match RELEASING.md and the 0.1.1 lesson. I would not reopen the twelve-issue bundle.

The main place the approach risks more machinery than the fixes is not the epic framing—it is how FIX-1636 is allowed to land. D1 explicitly accepts a large, end-loaded closure child; that is defensible for a one-time pre-release gate, but the repo already has most of the ingredients to avoid a monolithic “run everything once at the end” harness.

What to keep

  • D2 / ER-17 — best part of the set; shrinks work without shrinking guarantees.
  • Leg b anti-game (HTTP only, two users, one tenant) — correct bar; implement via goals/ + router patterns (hire-plane, cli-principal.integration.test.ts), not new ad-hoc harness code.
  • FIX-1601 + orchestration.md closure template — reuse structure for FIX-1636’s plan PR; do not invent a second closure doctrine.

Simpler architecture (optional epic amendment; otherwise FIX-1636 child spec)

Current shape Lighter alternative
FIX-1636 blocked until all children merge; full plan rerun per finding batch Incremental main CI jobs added as children land: (1) release:build → pack publish set → empty ESM install/import + DevTool asset probe (leg a); (2) matrix HTTP security cases sharing one server (leg b); (3) Redis service job for BullMQ (leg c). Epic wrap = those checks green + one SHA, not a separate QA-only integrator.
ER-1–12 + closure re-run + child tests One “checked at” column: required CI job or package test; avoid “child test and closure leg” duplication unless leg b truly walks a different path.
Controls: pre-fix commit per hole + full rebuild each time Build artifact once per baseline SHA (worktree/matrix assertions only); do not nest release:build + ~27 packs inside every control case.
21 ERs (many restate DECISIONS / SPEC fence) Keep ER-1–12 as the traceability table; fold ER-13–19 process rules into PLAN or drop ER-19 (orchestration); ER-20/21 duplicate SPEC/DOCS. Nit—follow-up OK.
Six decision/path SVGs + parallel mermaid One source of truth for graphs; SVGs drift from the dated issue table. Nit.

Third-party / existing tooling

  • Do not duplicate add-esm-extensions.mjs --check --all, publint, or dry-run publish as “closure”—they already pass on broken 0.1.1.
  • Do script the install loop already documented in RELEASING.md (possibly one goals/release-gates/ goal), committed on the closure PR per orchestration.
  • packages/integration-tests stays wrong for leg b (no HTTP; by design)—don’t force scenarios there.

Skipped (owner call, not simplify nits)

  • Shrinking the locked twelve-issue set.
  • Whether leg c is release-critical vs post-1634 canary (spec treats it as in-box).

What I did not flag

No code to run tests on. Spec prose and figure count are in line with sibling epics (e.g. FIX-1592/1457).

Merge recommendation: merge this epic spec; when FIX-1636’s QA plan is written, bias toward early CI wiring + FIX-1601-shaped goals rather than a finale-only manual closure loop. If you want D1 amended to say “closure checks live on main before wrap,” that would be a small DECISIONS/SPEC tweak—not required for me to approve the direction.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Comment thread specs/epics/FIX-1635/DECISIONS.md Resolved
Comment thread specs/epics/FIX-1635/SPEC.md Resolved
Comment thread specs/epics/FIX-1635/PLAN.md Resolved
Comment thread specs/epics/FIX-1635/BUSINESS-RULES.md Resolved
Comment thread specs/epics/FIX-1635/DOCS.md Resolved

Copy link
Copy Markdown
Collaborator Author

Coherence check (FSD Architect) — not owner approval / not the gate. Shared jhoffner login can look like product-owner sign-off; this is approach/coherence only.

Verdict: Direction coherent with Public Launch and the locked child set. No silent duplicate epic and no two-direction fork with another open stream. The outside second-look (Claude Code / Jake login) is constructive set-level feedback; fold-ins 1–3 and 5 need an explicit Architect accept/reject so the PR agent does not invent a second sequencing / ownership story while rewriting.

vs other open streams

Claude second-look items (set-level)

# Stamp Why
1 Leg a as standing CI (FIX-1431 / FIX-1334 land it; FIX-1636 reuses) Accept · fold in Matches Public Launch PR-1 and D1's 0.1.1 lesson. Closure stays the whole-set proof; it must not be the only place leg a lives.
2 Pin leg-a control to 0.1.1 (or a recorded tarball) Accept · fold in "Last npm" drifts once adjacent publish work lands.
3 Children own two-user HTTP tests; closure runs that suite vs packed tarballs Accept · fold in Concrete ER-16; drops historical-commit rebuild from closure. Control-must-fail stays at the child.
4 FIX-1286 maybe direct-route after FIX-1018 Park (→ epic wake, low stakes) Already allowed by D3 ("may close as proved by FIX-1018"). No rewrite required on this PR.
5 Owner-scoped lookup one primitive owned by FIX-1018; FIX-1022 / 1046 / 1021 consume Reject as a hard fold-in Would rewrite ownership and widen D3 / ER-18's gate set beyond "FIX-1018 → FIX-1286 / FIX-1634". Keep PLAN's parallel bindings plus the existing "one not-found shape" coordination. A shared helper is fine if it falls out of FIX-1018's reproduction — → implementer note / optional consume, not a new ER that blocks the principal cluster.
6 ER-8: seam calls ingress admission Accept as → implementer note for FIX-1328 Already child-only; keep it off this epic.

Rewrite ask (for the PR agent)

Fold 1–3 into SPEC / PLAN / BUSINESS-RULES (and the ownership figure if ER-1 / ER-2 delivery moves to FIX-1431 / FIX-1334 with closure reuse). Do not fold 5 into a new ER owned by FIX-1018, or into new blocked-by edges for FIX-1022 / 1046 / 1021. Leave 4 for the epic wake. Item 6 stays off this epic.

No Jake ping — review was already on the PR; this only stamps fold-ins so the rewrite has one direction.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5132f36601

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread specs/epics/FIX-1635/SPEC.md Resolved
Comment thread specs/epics/FIX-1635/SPEC.md Resolved
Comment thread specs/epics/FIX-1635/BUSINESS-RULES.md Resolved
Comment thread specs/epics/FIX-1635/EVOLUTION.md Resolved
Comment thread specs/epics/FIX-1635/SPEC.md Resolved
Comment thread specs/epics/FIX-1635/BUSINESS-RULES.md Resolved
jhoffner pushed a commit that referenced this pull request Sep 29, 2026
… bot review

Status: hard gates' objective is in review (PR #2360, closure FIX-1636
filed); the epics table carries epic state only, counts live once in Now.

Folded from #2359 review: check 5 means the showcase paths run, not
polish; the docs, brand and demo bar gates the cut on checks 3 and 5
only; framework simplification is the one exception to whatever-landed;
a decided-once line for tier 2/3 testing and FIX-107; PR-1's checked
where points at FIX-1636's closure run; the territory figure holds no
live status; the open 1.0-vs-0.x fork gets its trade-off figure.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNTQkGXCUryuVD2TEBLi6G
Leg a becomes a standing CI job (FIX-1431 lands it, FIX-1334 extends it,
the closure reuses it) with its control pinned to the 0.1.1 tarball. Each
child lands its HTTP case and proves its control at fix time; the closure
runs the suite on installed tarballs and no longer rebuilds old commits.
ER-3 covers stream attach and resume and asserts owner-scoped reuse; ER-10
matches the shipped create-if-absent contract; the request-as-capability
model gets an evolution row owned by FIX-1018. Rules now each carry an
owner and a check; ER-18 (a restatement of D3) is dropped and the rest
renumbered. DOCS keeps intent and ownership; FIX-1018 owns the draft.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNTQkGXCUryuVD2TEBLi6G
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01HNTQkGXCUryuVD2TEBLi6G

Copy link
Copy Markdown
Collaborator Author

Round 1 folded (head 510e241). This covers the second-look review, the Architect's stamp on it, and the Cursor and Codex inline comments. D1, D2 and D3 are unchanged.

  • Folded into the spec: leg a is a standing CI job that FIX-1431 lands, FIX-1334 extends and the closure reuses. Its control is pinned to the 0.1.1 tarball. Each principal child, plus FIX-1634 and FIX-1628, adds its own HTTP case to one shared suite and proves the case fails on its pre-fix commit (ER-16). The closure runs that suite against installed tarballs and no longer rebuilds old commits. Other changes:
    • ER-3 covers stream attach and resume, and a reused id succeeding as the caller's own request.
    • ER-10 now matches the shipped create-if-absent contract.
    • A new EVOLUTION row retires request-id-as-capability; FIX-1018 owns the doc update.
    • Every rule names an owner and a check. The old ER-18 (a restatement of D3) is dropped and the rules renumbered.
    • DOCS keeps intent and ownership, and FIX-1018 owns the draft.
    • Reproduction results go on Linear (ER-17), FIX-1634 must name FIX-1302's guarantee (ER-14), and PLAN now says the closure plan must name where CI's Redis comes from.
  • Implementer notes, posted to Linear: FIX-1018 may offer a shared owner-scoped lookup that FIX-1022, 1046 and 1021 can use. FIX-1328 calls ingress admission. FIX-1636 gets staged CI artifacts, a tiered rerun (optional, would need an owner amendment), FIX-1601's plan shape with a skip list, and where CI gets Redis.
  • Not folded: a new owner-check ER and new blocked-by edges (item 5, per the Architect). FIX-1286's route is parked, since D3 already allows it. The child count stays at 12 plus the closure: FIX-1510 is FIX-1261's sub-issue in Linear.

🤖 Generated with Claude Code


Generated by Claude Code

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Coherence check (FSD Architect) — not owner approval / not the gate. Shared jhoffner login can look like product-owner sign-off; this is approach/coherence only.

Round 1 fold verified on head 510e241 against the Architect rewrite ask (issuecomment-5890190886). Matches. No silent fork and no second sequencing / ownership story.

Asked On head
Fold 1–3 (leg a standing CI via FIX-1431 / FIX-1334; pin control to 0.1.1; children own HTTP suite / ER-16; closure reuses, no old-commit rebuild) Present in SPEC goal check, PLAN (FIX-1431 / 1334 / 1636 rows + shared-suite seam), BUSINESS-RULES ER-1/2/16/19, and DECISIONS "Decided in review"
Do not fold 5 (no new owner-check ER; no new blocked-by for FIX-1022 / 1046 / 1021) Held: PLAN still has parallel bindings + one not-found shape; DECISIONS explicitly records "No shared owner-check rule"; optional shared lookup stays FIX-1018 → implementer note
Park 4 (FIX-1286 route) Held: still spec → impl; D3 "may close as proved" unchanged
6 off this epic Held: implementer note only
D1 / D2 / D3 unchanged Held

Child count and fence still match the locked set (12 + closure; FIX-1510 under 1261; ER-13/15). Soft only: when #2359 is next edited, its done-count may want a refresh — not a blocker here.

No Jake ping.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants