Repository navigation
chore(spec): remove project spec accidentally merged to main - #2392
Conversation
Merging #2359 (project/public-launch) put spec/_projects/public-launch/ on main. Project specs live only on never-merged project/* branches, and scripts/validate-spec-folder.mjs requires spec/ to hold nothing but README.md, so the "Process guards" check has been red on main since. Remove spec/_projects/ from main. Nothing is lost: the identical content remains on origin/project/public-launch (bd55748). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GmvuVRtAQQvxJfj4fMVirA
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
…#2392 merges) Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01GmvuVRtAQQvxJfj4fMVirA
Process guards fails on main since #2359 put spec/_projects on it; #2392 removes it. Same deletion here, a no-op once #2392 merges. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
Code Snob — too small to rewrite.
Head 725b22a deletes eight files and adds nothing:
spec/_projects/public-launch/BUSINESS-RULES.mdspec/_projects/public-launch/DECISIONS.mdspec/_projects/public-launch/PLAN.mdspec/_projects/public-launch/SPEC.mdspec/_projects/public-launch/absorbed/linear-content.mdspec/_projects/public-launch/figures/arc.svgspec/_projects/public-launch/figures/open-launch-version.svgspec/_projects/public-launch/figures/territory.svg
I also read scripts/validate-spec-folder.mjs. On a mergeable branch, spec/ may hold only README.md, so the whole _projects tree has to go. A rewrite cannot shrink a pure deletion of the path the check names. No POC.
Sent by Cursor Automation: Code Snob
There was a problem hiding this comment.
Problem
Merging #2359 (project/public-launch → main) landed spec/_projects/public-launch/ on main. Project specs are supposed to live only on never-merged project/<slug> branches (mirrored to Linear), with spec/ on main limited to README.md. That left Process guards failing on every main push until the stray tree is removed.
Verdict: approve
This PR is the right-sized fix: delete exactly the eight files from the accidental merge, with no relocation to main and no duplicate authority. The commit message correctly points readers at origin/project/public-launch as the canonical copy. Grep shows no remaining citations to spec/_projects/public-launch on maintained paths; epic specs that need project rules should keep linking the open project PR / branch blob URLs (existing pattern).
Simplify / “did the approach go too far?”
This PR did not go too far — it is a pure revert of policy state. The complexity came upstream (treating a standing project PR like a merge-to-main artifact), not from this cleanup.
| Alternative | Take |
|---|---|
git revert -m 1 of #2359 |
Equivalent end state for these paths; narrative-only difference. |
Keep a copy on main “for discoverability” |
Wrong — fights orchestration and keeps CI red. |
Move under specs/ |
Wrong altitude and merge policy (retained issue/epic vs never-merged project). |
Retire validate-spec-folder.mjs |
Wrong — the guard is what makes leakage loud. |
One gap worth a follow-up (not blocking here)
CI runs validate-spec-folder.mjs on PRs unless head_ref starts with project/ (.github/workflows/ci.yml). A PR that merges project/* into main therefore skips the guard on the PR and only fails after merge on main push. Simpler prevention: still run the same script when base_ref == 'main' (even for project/* heads), or add a dedicated “no spec/_projects/ in diffs targeting main” check. That closes the hole without changing the project-spec lifecycle.
Subagent passes (read-only)
- Code quality: no blocking issues; operational checklist = confirm standing project PR + Linear mirror stay authoritative (outside this diff).
- Performance: none relevant (static markdown/SVG; small CI guard win once removed).
- Reuse: aligned with
spec/README.mdand orchestration; reuse existing validator + branch URLs, not new layout.
No changeset needed.
Sent by Cursor Automation: Review For Best Approach


What failed
The required Process guards check is red on
main. The failing step is "Spec retention and legacy paths" (node scripts/validate-spec-folder.mjs). It runs unconditionally on pushes tomain.Why
Merging #2359 (
project/public-launch) putspec/_projects/public-launch/onmain. Project specs live only on never-mergedproject/*branches, and the guard requiresspec/to hold nothing butREADME.md.The fix
Remove
spec/_projects/(8 files, all underpublic-launch/) frommain. Nothing else changes.Nothing is lost. The same content is still on
origin/project/public-launch(bd55748).git diff origin/main origin/project/public-launch -- spec/_projectsis empty.No file on
mainlinks tospec/_projects/public-launch. The remainingspec/_projectsmentions are generic<slug>docs, guard tests, and one blob link to a different project branch (project/framework-simplification-and-cleanup). None of them break.Evidence
Guard before (on
origin/mainfc94405), exit 1:Guard after (this branch), exit 0:
I ran every other Process-guards step locally on this branch. All exit 0:
validate-changeset-refs.mjs: ✓ every new changeset names its Linear issuevalidate-publish-set.mjs: ✓ 3 package(s) held out of the publish setvalidate-no-nul-bytes.mjs: ✓ no tracked source file contains a literal NUL bytevalidate-model-strings.mjs: ✓ No removed model-string syntax.check-isolation-coordinate.mjs: OKNo changeset: this touches no published package.
🤖 Generated with Claude Code
https://claude.ai/code/session_01GmvuVRtAQQvxJfj4fMVirA
Generated by Claude Code