Skip to content

chore(spec): remove project spec accidentally merged to main - #2392

Merged
jhoffner merged 1 commit into
mainfrom
claude/loving-davinci-08b5bx
Oct 6, 2026
Merged

jhoffner merged 1 commit into
mainfrom
claude/loving-davinci-08b5bx

Conversation

@jhoffner

Copy link
Copy Markdown
Collaborator

What failed

The required Process guards check is red on main. The failing step is "Spec retention and legacy paths" (node scripts/validate-spec-folder.mjs). It runs unconditionally on pushes to main.

Why

Merging #2359 (project/public-launch) put spec/_projects/public-launch/ on main. Project specs live only on never-merged project/* branches, and the guard requires spec/ to hold nothing but README.md.

The fix

Remove spec/_projects/ (8 files, all under public-launch/) from main. Nothing else changes.

Nothing is lost. The same content is still on origin/project/public-launch (bd55748). git diff origin/main origin/project/public-launch -- spec/_projects is empty.

No file on main links to spec/_projects/public-launch. The remaining spec/_projects mentions are generic <slug> docs, guard tests, and one blob link to a different project branch (project/framework-simplification-and-cleanup). None of them break.

Evidence

Guard before (on origin/main fc94405), exit 1:

✗ spec/ and spec-poc/ must hold nothing but README.md here. Found 1:
    spec/_projects

Guard after (this branch), exit 0:

✓ legacy spec folders are clear and no dangling legacy spec paths are cited

I ran every other Process-guards step locally on this branch. All exit 0:

  • validate-changeset-refs.mjs: ✓ every new changeset names its Linear issue
  • validate-publish-set.mjs: ✓ 3 package(s) held out of the publish set
  • validate-no-nul-bytes.mjs: ✓ no tracked source file contains a literal NUL byte
  • validate-model-strings.mjs: ✓ No removed model-string syntax.
  • check-isolation-coordinate.mjs: OK

No changeset: this touches no published package.

🤖 Generated with Claude Code

https://claude.ai/code/session_01GmvuVRtAQQvxJfj4fMVirA


Generated by Claude Code

Merging #2359 (project/public-launch) put spec/_projects/public-launch/
on main. Project specs live only on never-merged project/* branches, and
scripts/validate-spec-folder.mjs requires spec/ to hold nothing but
README.md, so the "Process guards" check has been red on main since.

Remove spec/_projects/ from main. Nothing is lost: the identical content
remains on origin/project/public-launch (bd55748).

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01GmvuVRtAQQvxJfj4fMVirA
@vercel

vercel Bot commented Sep 29, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Sep 29, 2026 9:24pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Sep 29, 2026 9:24pm UTC
flow-state-dev-ui Ignored Ignored Sep 29, 2026 9:24pm UTC

Request Review

jhoffner pushed a commit that referenced this pull request Sep 29, 2026
jhoffner pushed a commit that referenced this pull request Sep 29, 2026
Process guards fails on main since #2359 put spec/_projects on it; #2392
removes it. Same deletion here, a no-op once #2392 merges.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
@jhoffner
jhoffner marked this pull request as ready for review October 6, 2026 01:17
@jhoffner
jhoffner merged commit ebca065 into main Oct 6, 2026
13 checks passed
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Oct 6, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-10-06T01:19:26.056500Z 725b22a Draft marked ready
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Snob — too small to rewrite.

Head 725b22a deletes eight files and adds nothing:

  • spec/_projects/public-launch/BUSINESS-RULES.md
  • spec/_projects/public-launch/DECISIONS.md
  • spec/_projects/public-launch/PLAN.md
  • spec/_projects/public-launch/SPEC.md
  • spec/_projects/public-launch/absorbed/linear-content.md
  • spec/_projects/public-launch/figures/arc.svg
  • spec/_projects/public-launch/figures/open-launch-version.svg
  • spec/_projects/public-launch/figures/territory.svg

I also read scripts/validate-spec-folder.mjs. On a mergeable branch, spec/ may hold only README.md, so the whole _projects tree has to go. A rewrite cannot shrink a pure deletion of the path the check names. No POC.

Open in Web View Automation 

Sent by Cursor Automation: Code Snob

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem

Merging #2359 (project/public-launch → main) landed spec/_projects/public-launch/ on main. Project specs are supposed to live only on never-merged project/<slug> branches (mirrored to Linear), with spec/ on main limited to README.md. That left Process guards failing on every main push until the stray tree is removed.

Verdict: approve

This PR is the right-sized fix: delete exactly the eight files from the accidental merge, with no relocation to main and no duplicate authority. The commit message correctly points readers at origin/project/public-launch as the canonical copy. Grep shows no remaining citations to spec/_projects/public-launch on maintained paths; epic specs that need project rules should keep linking the open project PR / branch blob URLs (existing pattern).

Simplify / “did the approach go too far?”

This PR did not go too far — it is a pure revert of policy state. The complexity came upstream (treating a standing project PR like a merge-to-main artifact), not from this cleanup.

Alternative Take
git revert -m 1 of #2359 Equivalent end state for these paths; narrative-only difference.
Keep a copy on main “for discoverability” Wrong — fights orchestration and keeps CI red.
Move under specs/ Wrong altitude and merge policy (retained issue/epic vs never-merged project).
Retire validate-spec-folder.mjs Wrong — the guard is what makes leakage loud.

One gap worth a follow-up (not blocking here)

CI runs validate-spec-folder.mjs on PRs unless head_ref starts with project/ (.github/workflows/ci.yml). A PR that merges project/* into main therefore skips the guard on the PR and only fails after merge on main push. Simpler prevention: still run the same script when base_ref == 'main' (even for project/* heads), or add a dedicated “no spec/_projects/ in diffs targeting main” check. That closes the hole without changing the project-spec lifecycle.

Subagent passes (read-only)

  • Code quality: no blocking issues; operational checklist = confirm standing project PR + Linear mirror stay authoritative (outside this diff).
  • Performance: none relevant (static markdown/SVG; small CI guard win once removed).
  • Reuse: aligned with spec/README.md and orchestration; reuse existing validator + branch URLs, not new layout.

No changeset needed.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants