Repository navigation
fix(stores): delete a request's stream events with its record (FIX-1647) #2393
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
22 commits
Select commit
Hold shift + click to select a range
e0f10e2
fix(stores): delete a request's events and runOnce results with its r…
claude c85197a
fix(stores): delete a request's record last; harness waits for the ru…
claude 61f18b8
fix(stores): settle every child delete before failing; filesystem del…
claude 904ab8f
fix(retention): do not evict a request whose run is still finishing (…
claude 811f4a2
fix(retention): keep a finished request for a grace window before evi…
claude d70c31f
fix(filesystem): give per-key runOnce files an unambiguous id boundar…
claude f82387a
fix(retention): evict a request only after its run has stamped finali…
claude 0fc2df2
Merge branch 'main' of https://github.com/fixpoint-labs/flow-state-de…
claude 13d6e6a
fix(retention): fence the finalization stamp to the run's own record …
claude c183148
fix(retention): fence the stamp on incarnation and close the rollout …
claude 48a8f4b
fix(filesystem): never serve a record-shaped legacy runOnce result; f…
claude 2123d5e
fix(retention): sweep stamps only runs that heartbeat through their t…
claude 71a2e33
fix(engine): fence live streams on the request incarnation; count kep…
claude a271519
fix(engine): filesystem delete keeps other requests' records and remo…
claude 58b6c4e
fix(engine): only the last overlapping run of a request finalizes it …
claude 1df5087
fix(engine): the last overlapping run stamps even when it ends by thr…
claude 35435a0
fix(engine): stamp every terminal record a run leaves; fence the stre…
claude 68e8f2f
docs: condense FIX-1647 changeset to one sentence; move details into …
claude 8fd1fdc
fix(engine): filesystem delete forgets the id's unreported event writ…
claude eab30a4
docs(engine): scope the finish sequence to requests that finish; a su…
claude 8c4619e
Merge origin/main into fix/fix-1647 (FIX-1654's incarnation fence)
claude f0567bd
Merge origin/main into fix/fix-1647 (FIX-1661's settle helper)
claude File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,7 @@ | ||
| --- | ||
| "@flow-state-dev/engine": minor | ||
| "@flow-state-dev/store-sqlite": patch | ||
| "@flow-state-dev/store-postgres": patch | ||
| --- | ||
|
|
||
| Deleting a request (including through session retention) now also removes its events and runOnce results once its run has finished, and custom `RequestStore`s must persist `finalizedAtMs`/`heartbeatsUntilFinalized`, honor `setFieldsIfStatus`'s new `expectedIncarnation` argument, and call `isStillAuthorized` in live tails (FIX-1647). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.