Skip to content

FIX-1661: the engine records each request's action result; the DevTool row reads it - #2429

Merged
jhoffner merged 8 commits into
mainfrom
fix/fix-1661
Sep 30, 2026
Merged

jhoffner merged 8 commits into
mainfrom
fix/fix-1661

Conversation

@jhoffner

@jhoffner jhoffner commented Sep 30, 2026 •

Copy link
Copy Markdown
Collaborator

The problem

When you run an action from a task's row in the DevTool, the row is supposed to show what the action came to: done, refused in its own words, or failed and why. The engine never recorded that, so the DevTool rebuilt it from traces and the live stream. Twelve review rounds on the rows each found a case where the rebuild got it wrong: a transient block, completion hooks, a value held by reference, a suspended request, a second action taking the stream. A client reading a session's history had the same gap: it could see that a request completed, but not what it returned.

What this does

When a request ends, the engine stores the action's result (output and/or error) on the request record, in the same write as its final status. The session's request list returns it: every entry says whether the request failed, why, and whether it answered. The answer itself comes back only when the caller asks for it with includeResultOutput, which the DevTool does.

The row's rebuild from traces is deleted outright, and a row now reads its request's status and result. A request with no recorded result (an older server, or history from before an upgrade) says "No result recorded for this request." rather than guessing. The Stream and Trace tabs still show a finished request's stream-only transient traces.

It deliberately does not add board provenance to the action list. The spec recommended not now, and it gets a follow-up issue.

What's asked of you

Nothing new. This implements the approved spec (#2417) and both of its signed-off decisions.

Parts worth reviewing closely

The rest of this is for whoever reviews the code.

  • request-action-result.ts and runAction.ts: the typed RequestSettlement and settledRecordFields.
    • Every final-status write builds status and result through one helper: runAction's settle and setup-failure CAS, the transport host's unenqueued termination, and the recovery sweep.
    • patchRequestRecord can no longer write a terminal status: writing status: "completed" through it is a TS2322.
    • This replaced PLAN's V2 totality check, per the review note.
    • A writer that bypassed the helper would write a record with no result, and the row would read it as no result recorded: honest, but wrong.
  • The failure path now returns the action's answer (BR-10). When a completion hook fails a request after the action answered, both the stored result and runAction's in-process return carry output next to the error. fsdev run reports it as output instead of null. Any caller that treated output !== undefined as "succeeded" would now be wrong on that path.
  • Where I'm unsure: the goal's suspend leg resumes over HTTP with action: "submit", because a suspension with a resumeSchema only allows submit. I read that from the server's 409, not from docs.

Persisted shape (BP-030). result is new and optional on the request record, and a record without it is read by its status, never as success. result.output is a JSON copy with no size cap (D1): only a listing that opts in with include_result_output carries it. An output JSON can't hold, or would silently change, is stored as outputNotRecorded: true, and the request keeps its status:

  • can't hold: BigInt, a cycle, a throwing toJSON
  • would change: NaN, ±Infinity, a function or symbol, an undefined array slot, a Map, Set, Error, RegExp or typed array

Supersedes #2414 for the rows. That PR (still open) fixes how a row's answer was merged from the stream, and rows no longer read the stream at all here. Its regression test is replaced by "reads a row's answer from the listed request's recorded result, never from the stream". The stream merge itself stays, for the inspector tabs only.

Not here:

  • board provenance (follow-up to be filed)
  • scoping include_result_output to request ids (possible follow-up if busy sessions show the cost)
  • BR-5's "Proved by" cell: it still names the totality check. Updating that cell is a one-line follow-up amendment.

Spec: specs/issues/FIX-1661/ · Linear: FIX-1661 · follows FIX-1629 (#2347) · merges when approved

How to review this: spec-backed implementation

This implements an approved spec. The approach and the numbered decisions in its DECISIONS.md are already signed off by a human, so please review the code against that direction, not the direction itself. The canonical set is retained at specs/issues/FIX-1661/ on main. Linear links to it and to the original merged spec PR, which keeps the review history. Follow-up amendment PRs explain later changes of direction. Current architecture docs remain the authority for shipped behavior (BP-037).

Most valuable here:

  • correctness on the second path: the legacy shape, the null boundary, the concurrent case, the cancel path
  • anything that derives an auth or routing decision from caller-controllable input
  • a behaviour the tests assert around rather than on

Already settled upstream: the approach and every decision in the spec's DECISIONS.md, which a human approved, and the conventions in docs/contributing/best-practices.md. If a decision is wrong, raise it as a spec finding and it gets folded back; please don't re-argue it inline.

Engineering calls: decided along the way, no product sign-off needed
  • One typed settle helper instead of a totality test (PLAN review note). settledRecordFields pairs status and result for every final-status writer.
  • Output stored as a faithful JSON copy, uncapped (D1).
    • A lossy or unstorable value becomes outputNotRecorded: true (BR-9).
    • undefined becomes {}.
    • An undefined-valued object key is left out, because it reads back the same.
  • A failure with no error code stores execution_error. FlowError.code is optional, and the listing type promises a code.
  • result is excluded from the conditional-write field set. Only the settle write can set it.
  • RequestSettlement is not exported from the engine's index. No adapter package writes a terminal request record today.
  • The stream-log cache is kept for the Stream and Trace tabs (PLAN S7). Rows don't read it.
  • The V4a suspend case drives runAction + continueRequest directly. testFlow can't attach a durability provider.
  • The docs went through docs-writer and then docs-editor (SHIP).
Everything else: verification and files

Goal check (goals/devtool-workforce-visibility/reads-a-row-actions-result/, Chromium on the shipped bundle, no model):

  • GOAL_CONTROL=no-result: FAIL on every leg, and on no other.
  • Real run: PASS:
    • handover refused, and still so after another row's dispatch took the stream
    • hook refused
    • ref done
    • suspend pending, then done
    • hook-fails failed with the action's answer
    • api, with and without the flag
  • FIX-1629's works-a-task-from-its-row goal re-run: PASS.

Red, then green:

  • Engine request-action-result.test.ts went red, then green.
    • The lossy-JSON test covers built-in containers and goes red with that check removed.
    • A 256K-character output is stored whole.
  • CLI: "reports the action's answer on a run a completion hook failed" is red when the engine's failure-path return drops the answer.
  • Route test and client query-param test: red, then green.
  • Store conformance (memory, filesystem, sqlite, pglite postgres): a store that drops result turns the "carries" case red.
  • DevTool:
    • The outcomeOf table and the row tests go red, then green.
    • The panel test asserts that the row reads the recorded result and that the Stream tab keeps the transient trace. It goes red with the merge removed.
  • V4a integration: a builder forced to return undefined turns both scenarios red.

Suites:

  • engine 3079 passed, with one exception: the filesystem BR-23 stream-conformance case times out under the full parallel run. It never reaches this code and passes when run alone.
  • fsdev 279, client 162, devtool 435, integration-tests 141, store-sqlite 324 and store-postgres 302 all passed.
  • pnpm typecheck is clean.

Files:

  • engine: stores/types.ts, execution/request-action-result.ts, execution/runAction.ts, execution/request-recovery.ts, transports/host/createInboundTransportHost.ts, routes/session-routes.ts, conformance
  • client: SessionRequestResult, includeResultOutput
  • devtool: lib/task-actions.ts rewritten; rows get { requestId, status, result }
  • also: a cli test, the goal, docs, and one changeset (patch: engine, client, devtool, fsdev)

🤖 Generated with Claude Code

https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

… DevTool row reads it (FIX-1661)

The engine writes the action's result on the request record in the same
write as the final status, through one typed settlement, and the session
request list returns it (output only with include_result_output). The
DevTool's Tasks-tab row reads status + result from the polled list; the
trace reconstruction and the stream-log cache are deleted.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
…ment the stored result (FIX-1661)

The goal check under goals/devtool-workforce-visibility/reads-a-row-actions-result
drives the shipped DevTool in Chromium over a no-model fixture flow served by
fsdev dev, one leg per case a trace reading got wrong, and a no-result control
that strips `result` from the listing and must fail every leg.

Docs: listSessionRequests in the client API reference, the stored result in
manual flow execution, the DevTool row paragraph, the client README comment,
and the server-and-client policy list. Changesets for engine, client, devtool.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
@vercel

vercel Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Sep 30, 2026 6:48pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Sep 30, 2026 6:48pm UTC
flow-state-dev-ui Ignored Ignored Preview Sep 30, 2026 6:48pm UTC

Request Review

@linear-code

linear-code Bot commented Sep 30, 2026

Copy link
Copy Markdown

FIX-1661

@jhoffner jhoffner left a comment

Copy link
Copy Markdown
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Second look + architecture pass (read-only review; nothing was run locally)

Verdict: the approach is right. Store the result with the terminal status in one write, and delete the DevTool's trace/stream rebuild. The typed RequestSettlement is a better guard than the totality test it replaced. Findings below, most important first. They are for the implementing agent to triage.

Answer to the PR's open question: other terminal writers

I grepped engine/src for terminal request-record writes outside runAction and terminateUnenqueuedRequest. Two remain that don't go through settleRequestRecord/buildRequestActionResult:

  • execution/request-recovery.ts:~105 (stale-request sweep, writes interrupted)
  • stores/subscribe-helpers.ts only synthesizes an interrupted event, so it is not a record writer.

The recovery sweep is interrupted, which carries no result by design, so it is correct today. But it is the one terminal writer that bypasses the typed helper, so it isn't covered by the compile-time guarantee the PR claims. Suggest routing it through a shared { status: "interrupted" } settlement, or adding a one-line comment there saying why it is exempt. RequestSettlement is not exported from engine/index.ts. Adapters and other packages (bullmq, next) that write request records can't reach it.

1. Unbounded result storage and list payload (worth a decision)

recordableOutput JSON-copies every completed action's output onto the request record, with no size cap. include_result_output=true (which the DevTool row poll now sends) returns every listed request's full output on every poll.

  • Storage: request records grow with the largest action output ever returned, forever, in memory/sqlite/postgres alike.
  • Wire: the poll cost scales with sum(output sizes) across the session's request list, not with the rows on screen.

The DevTool only needs the outputs for the requests behind the rows it is showing, and only needs {ok:false}-shaped ones to render a refusal. Options: (a) a byte cap in recordableOutput that degrades to outputNotRecorded: true (the type already has that escape hatch), plus (b) scoping include_result_output by requestIds, or having the row fetch one request's result lazily. Option (a) alone is a small change and closes the storage half. Please at least state the cap decision in the PR, since it is a persisted-shape choice (BP-030).

2. runAction's in-process return changed for every caller

output is now populated on the failed path when the action answered before a hook failed the request. I checked the callers I could find. cli/src/commands/run.ts, mcp/src/result-formatting.ts and the bullmq/workforce/in-process callers all check result.error first, so nothing breaks. One visible side effect: fsdev run on a failed run now emits output: <answer> in the FlowRunResult (output: result.output ?? null) where it used to emit null. It's arguably right, but it is a CLI output-contract change with no test and no changeset line. Add a CLI-level assertion or note it in the engine changeset.

3. Stored copy and in-process value can disagree

The record stores a JSON round-trip (Date → string, undefined keys dropped, NaN → null), while runAction returns the raw result.output (actionAnswer?.output). The PR text says "the stored answer and the one an in-process caller receives use one vocabulary", which holds for keys but not values. Either return the recorded copy on the failure path, or soften the doc comment on RequestActionResult. Not blocking.

4. settleRequestRecord swallows nothing, but a failed settle write loses the status

settleRequestRecord puts status and result in one write. That is good for pollers, but if recordableOutput throws somewhere other than stringify (e.g. a toJSON that throws is caught, but a getter that throws during JSON.parse reviver is not applicable; fine), the guard is OK. I found no defect here, just confirm the catch around JSON.stringify is covered by a test with a throwing toJSON in addition to BigInt/cycle. The listed tests mention BigInt and cycle only.

5. Architecture: keep the stringly "refusal" convention out of the engine, and make sure it stays out

classify() in devtool/lib/task-actions.ts still owns {ok:false} / {outcome:"declined"} interpretation. That is the right side of the line (engine stores, reader interprets), and the engine doc comment says so. But hasOutput is computed in session-routes.ts as a route-level decoration on a persisted type and only appears in the client type. Consider defining ListedRequestActionResult once in stores/types.ts (or the contracts layer) next to RequestActionResult so client and engine derive from one source rather than mirroring (SessionRequestResult is a hand-copied shape).

6. Smaller items

  • patchRequestRecord is now a one-line wrapper over writeRequestRecordPatch whose only job is a narrower type. Fine, but the two names are easy to confuse; a short comment on writeRequestRecordPatch ("internal: use patch/settle") would help.
  • terminateUnenqueuedRequest calls normalizeError(cause, { scope: "request" }). Check that this cannot leak internal error detail (stack, details) into a list response that other tenants' callers with userId access can read. The stored shape is only {code,message}, so this looks OK, but the message of a raw thrown Error at the admission layer can include store keys or ids. Worth a look under BP-031/multi-tenant (BP-035).
  • Followups the PR itself names: update BR-5's "Proved by" cell in the spec, and file the board-provenance issue. Both should exist before merge so they aren't lost.
  • Docs were drafted without docs-writer/docs-editor, as the PR says. Run them before release per the repo rule.

Not flagged

The result exclusion from ConditionalRequestFields, the execution_error default code, and the DevTool's not-reported wording are all sound.


Generated by Claude Code

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Snob — already tight. No POC.

I read packages/engine/src/execution/request-action-result.ts, the settle/patch split in runAction.ts, withListedResult in session-routes.ts, terminateUnenqueuedRequest in createInboundTransportHost.ts, outcomeOf in packages/devtool/src/react/lib/task-actions.ts, Outcome / describeOutput in task-row-actions.tsx, and the rowOutcomeSources projection in DevToolPanel.tsx.

A rewrite would not shrink this contract:

  • The trace walk, mergeRawItems, and the stream-log cache are already gone. What is left in outcomeOf is the status-then-result read the row still has to make: refusal, declined write, failed after an answer, nothing recorded.
  • buildRequestActionResult is the one builder both settleRequestRecord and the transport host call. Moving it back into runAction copies it onto the host.
  • patchRequestRecord is the one-line type fence so a terminal status cannot be written without its result. That is the totality check this PR replaced. Folding it into writeRequestRecordPatch opens that hole again.
  • withListedResult is the include_result_output strip. hasOutput is what the list still sends when the value is left off.
  • Renaming requestId to id deletes the four-line map in the panel and puts the same field back on every fixture. Tie.
  • describeOutput has one caller. Inlining it does not change the contract.

Left the typed settlement and the no-fallback row read as they are. Both are already decided on this PR.

Open in Web View Automation 

Sent by Cursor Automation: Code Snob

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Problem and approach

The bug was real: DevTool row outcomes were inferred from traces, item refs, and stream timing, which breaks for transient blocks, hook ordering, handover, and “open the panel later.” Persisting the action result on the request record at terminal settlement and reading it from the session request list is the straightforward fix—and the diff removes a lot of DevTool complexity (mergeRawItems, trace/ref resolution) rather than adding a parallel inference path.

I considered simpler alternatives:

Alternative Why I’m not asking for it
Keep trace/stream reconstruction, patch edge cases More branches, same race class; FIX-1661’s goal anti-game (no-result) correctly rules this out.
Inline buildRequestActionResult only in runAction createInboundTransportHost also settles requests; a shared request-action-result module is warranted.
Always return full output on list (no include_result_output) Would tax every poller; mirroring include_items is consistent and documented.
Drop the goal harness, rely on integration tests only The Playwright goal is heavy (~500 lines) but encodes the control matrix and proxy anti-game; I’d treat shrinking it as a follow-up, not a merge blocker.

Verdict: This is the right direction. Surface area (store field, list projection, client flag, conformance tests) matches a durable contract; the DevTool side got simpler.

Simplify / follow-ups (non-blocking)

  1. Three changesets — BP-022 allows one multi-package fragment; consolidating request-action-result-{engine,client,devtool}.md would reduce release noise.
  2. Terminal writes — Setup failure in runAction and terminateUnenqueuedRequest in the inbound host still hand-build { status, result } while normal paths use settleRequestRecord; a small shared helper would avoid a third drift path later.
  3. recordableOutput — After the output === undefined guard, the text === undefined branch looks unreachable; worth deleting or commenting if you’re keeping it for a reason.
  4. DevTool poll payload — includeResultOutput: true on every session list refresh pulls every recorded output for the whole session, not just row-action request IDs. Fine for typical debugging; if sessions get long, consider a scoped API or lazy read (inline comment).
  5. Duplicate wire types — RequestActionResult vs SessionRequestResult duplicate the same table; optional later move of the shared core to contracts (not required for this PR).
  6. incomplete + output — outcomeOf treats any non-completed status as failed even when result.output exists; tests match that; flag only if product wants incomplete successes to show as ok.

Engine tests for request-action-result / session-requests-result pass locally on this branch.

Nice work—the persistence + opt-in list projection is cleaner than extending trace heuristics.

Open in Web View Automation 

Sent by Cursor Automation: Review For Best Approach

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 5851e3f5f5

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread apps/docs/docs/api/client.md Resolved
@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-09-30T03:01:24.564661Z b9fdfea Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

… every final-status writer (FIX-1661)

Review round 1 on the action-result PR:

- The stored output is capped at MAX_RECORDED_OUTPUT_BYTES (64 KiB of
  UTF-8 JSON); past it the record says outputNotRecorded, so records and
  listings that carry outputs stay bounded.
- An output JSON would silently change (NaN, +/-Infinity, a function or
  symbol, an undefined array slot) is recorded as outputNotRecorded
  instead of storing a different value.
- settledRecordFields pairs the status with its result for every
  final-status writer: settleRequestRecord, the setup-failure CAS settle,
  the transport host's unenqueued termination, and the recovery sweep.
- RequestActionResult's doc says the stored copy and the live value share
  keys, not always values.
- fsdev run: a run a completion hook failed after the action answered
  reports that answer as output; asserted at the CLI.
- One multi-package changeset in place of three.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

Copy link
Copy Markdown
Collaborator Author

Reply to the second look (review 5360652076). All code changes are in 65ddb90.

Other terminal writers. Fixed. The stale-request recovery sweep now builds its interrupted write from the same settlement as every other writer. A new settledRecordFields(settlement) returns { status, result } together, and settleRequestRecord, the setup-failure CAS settle, terminateUnenqueuedRequest and the sweep all use it. I did not export RequestSettlement from engine/index.ts, because no adapter writes a terminal request record today. In bullmq, next, node, vercel, mcp and scheduled, src has no request-record writes at all. The only writes outside the engine and the store packages are in testing (testFlow/createTestContext), and they seed in_progress records.

1. Unbounded storage. Fixed with option (a). MAX_RECORDED_OUTPUT_BYTES = 64 * 1024, counted as UTF-8 bytes of the stored JSON. An output over the cap is stored as outputNotRecorded: true and keeps its status; on a failure the error still lands next to the marker. Tests cover exactly at the cap, one byte over, two-byte characters, the failed path, and a run end to end. The test goes red without the cap. The PR body now has a persisted-shape note (BP-030). I did not do (b), scoping include_result_output by request id; it is a possible follow-up.

2. fsdev run output contract. Fixed. A new CLI test, "reports the action's answer on a run a completion hook failed", asserts output is the answer rather than null. It is red when the engine's failure-path return drops the answer. The changesets are now one multi-package fragment that names this change and adds @flow-state-dev/fsdev.

3. Stored copy vs live value. Fixed as you suggested, by softening the RequestActionResult doc: the keys match, and the stored values are the JSON copy. Runtime returns are unchanged. Codex's review (P2) led to a related change: an output JSON would silently alter (NaN or ±Infinity, a nested function or symbol, an undefined array slot) is now outputNotRecorded instead of a changed value. undefined-valued object keys are still stored with the key left out, because they read back the same.

4. Throwing toJSON. Added, as a builder-level test. An end-to-end version is not possible, and not because of the result field. The memory store structuredClones the whole record, the item log carries the live output, and cloning a function throws DataCloneError. That path predates this PR, and result itself is always cloneable. A test also covers a toJSON that returns undefined, the case where JSON.stringify yields undefined.

5. One source for the listed shape. Not in this PR. engine never depends on client, and client mirrors engine wire types by hand, as it does for SessionRequestSummary. Moving the shared core into contracts is a reasonable follow-up.

6. Smaller items. writeRequestRecordPatch now has an "Internal: call patchRequestRecord or settleRequestRecord" note. Tenant leak: the list route is gated by the same session read access as the request's own stream and error items. Those already carry the normalized message, so result.error exposes nothing new to a new reader. The follow-ups (the BR-5 "Proved by" cell and the board-provenance issue) are for the coordinator to file. The docs-writer and docs-editor pass is being dispatched separately; I left the user-facing docs alone in this push.

Verified on 65ddb90:

  • Engine: 3079 passed. One filesystem conformance test, BR-23, timed out at its 10s limit under the full parallel run. It seeds records straight into the store and never reaches this code, and it passes alone in 6.8s (6.1s without the change).
  • fsdev 279, integration-tests 141 and store-sqlite 324 passed. pnpm typecheck is clean.

Generated by Claude Code

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

Copy link
Copy Markdown
Collaborator Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 70cc08534c

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…not recorded (FIX-1661)

Review round 3 on the action-result PR:

- Drop the 64 KiB output cap. The spec (D1, PLAN) keeps storage uncapped
  and makes only an opted-in listing carry outputs.
- A Map, Set, Error, RegExp or typed array output is recorded as
  outputNotRecorded: JSON writes them as {} or index keys without
  visiting their contents.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

Copy link
Copy Markdown
Collaborator Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 4620725901

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…(FIX-1661)

Review round 4: deleting the stream-log cache made a finished request's
transient trace vanish from the inspector views once the list refresh
landed. PLAN S7 keeps the cache when those tabs need it and cuts only the
row's use. mergeRawItems and streamRawItems are back for requestGroups;
rows still read only the recorded status and result. The panel test
asserts both, and goes red with the merge removed.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

Copy link
Copy Markdown
Collaborator Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c096773554

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…fore completion hooks (FIX-1661)

Review round 5: the record's JSON copy was taken at settle time, after the
completion hooks, so a hook that mutated the returned object changed the
recorded answer (PLAN S3 captures before hooks). recordOutput() now takes
the snapshot when the action answers; RequestSettlement carries that
RecordedOutput for both the completed and the answered-then-failed
settlements. The new test goes red with the snapshot taken at settle.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N

Copy link
Copy Markdown
Collaborator Author

@codex review


Generated by Claude Code

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: b9fdfeafa7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Resolves the conflict with main's incarnation-fenced
terminateUnenqueuedRequest: it keeps FIX-1661's typed ending (cause
recorded as the result's error) and takes main's expectedIncarnation
parameter. FIX-1660's panel test now asserts the row's answer from the
recorded result and the stream-only trace in the Stream tab.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_014LohgYyHsXCYQd6kABH11N
@jhoffner
jhoffner merged commit 7a23a75 into main Sep 30, 2026
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants