Skip to content

Rename app-lab to shift-manager (FIX-1706) - #2584

Closed
jhoffner wants to merge 1 commit into
mainfrom
cursor/rename-app-lab-shift-manager-31fc
Closed

jhoffner wants to merge 1 commit into
mainfrom
cursor/rename-app-lab-shift-manager-31fc

Conversation

@jhoffner

@jhoffner jhoffner commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator

The product is called shift-manager, but the tree and package still said labs/app-lab and @flow-state-dev/app-lab, and the lab it opens was still named DevForce.

The shell, its package, its goal checks, and its theme stylesheet now use shift-manager. The DevForce lab directory is goals/devteam-lab, and display names that said DevForce say DevTeam. labs/conductor stays where it is. The labs README no longer pitches Conductor as the lab path.

Nothing here is yours to decide. The brief settled the rename and what stays out.

For a code reviewer: the sweep is a string and path rename. The spot to check is that runtime identities were left alone on purpose (u_devforce_lab, devforce-tasks, block names such as devforce-em-file-row, and the harness-manager derivation snapshot). A global rename of those would have changed stored ids. The weak spot is user-visible copy, which now says shift-manager in the same places that said App Lab, including headings.

Fixes FIX-1706. GitHub issue #2573. No retained spec; the issue brief is the contract. No goal check: this is a rename with no new behavior. No changeset: @flow-state-dev/shift-manager and @flow-state-dev/design-system are private.

How to review this — altitude, what's in scope, what's deliberately unsettled

How to review this. The contract for this change is a one-screen agent brief on the issue, not a spec — the work was small and local enough that a full spec would have been a document round-trip. So no approach was signed off upstream, and this PR is the only gate: the design is in scope alongside the code.

Most valuable here: whether the change is actually as small and local as the brief assumed — a brief-backed change that turns out to touch a contract, add public surface, or need a migration was mis-routed and should have been specced. Then the second path (the legacy shape, the null boundary, the concurrent case, the cancel path).

In scope to challenge: the approach, the scope, and whether this earned its place at all.

Engineering calls
  • Runtime ids and in-code lab keys stay (u_devforce_lab, org_devforce_lab, devforce-feature-board, sequencer names, devforce-tasks, the devforce key inside the send-turn goal). Renaming them would change stored identities. Wrong call: a later reader treats the directory name and the user id as one thing and "fixes" only half.
  • No CSS alias. Every @flow-state-dev/design-system/app-lab.css import moved to shift-manager.css in this PR, and the package is private. Wrong call: an external import of the old subpath, which this repo does not have, would fail.
  • FIX-1690 send behavior is unchanged. send.ts only had the product name in comments. Specs and comments that named the old paths were updated so they point at the new tree.
  • Historical spec labels ER-DevForce / #er-devforce moved with the display name to ER-DevTeam / #er-devteam. Issue ids were not rewritten.
  • Left out, as the brief says: --shift / SHIFT_MANAGER_SHIFT, profiles/day|night, teams/devteam, and --team / 1..N teams.
Verification

pnpm install --offline --frozen-lockfile — lockfile up to date.

pnpm --filter @flow-state-dev/shift-manager test — 11 files, 116 passed, 1 skipped.

pnpm --filter @flow-state-dev/shift-manager typecheck — pass.

pnpm --filter @flow-state-dev/design-system test — 11 passed.

pnpm --filter @flow-state-dev/design-system typecheck — pass.

No new behavioral test. This is a rename; the existing suites are the check that imports, the start script, and the theme path still resolve. Red/green does not apply: the suites were green before the move and green after.

Open in Web Open in Cursor 

Move the lab shell to labs/shift-manager (@flow-state-dev/shift-manager),
the goal trees to goals/shift-manager and goals/devteam-lab, and the theme
stylesheet to shift-manager.css. DevForce display names follow the path.
Runtime ids stay so stored identities do not change.

No changeset: the package is private.

Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
@vercel

vercel Bot commented Oct 1, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 1, 2026 4:59pm UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 1, 2026 4:59pm UTC
flow-state-dev-ui Ignored Ignored Oct 1, 2026 4:59pm UTC

Request Review

@linear-code

linear-code Bot commented Oct 1, 2026

Copy link
Copy Markdown

FIX-1706

jhoffner commented Oct 1, 2026

Copy link
Copy Markdown
Collaborator Author

Closing this as superseded. The rename landed in #2588 (merged at 0c49e70), which also adds the --shift flag and the --team devteam profile. #2588 keeps goals/devforce-lab/ on purpose: that folder is evidence for the seat-to-coding-run join, and renaming it would change the harness-manager snapshots and trip manager-queue-lab's frozen-subtree fence. This branch now conflicts with main.


Generated by Claude Code

@jhoffner jhoffner closed this Oct 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants