Skip to content

POC: closure shell uses the shared Shift Manager helper - #2711

Closed
cursor[bot] wants to merge 21 commits into
mainfrom
poc/fix-1663-shell-uses-shared-helper
Closed

cursor[bot] wants to merge 21 commits into
mainfrom
poc/fix-1663-shell-uses-shared-helper

Conversation

@cursor

@cursor cursor Bot commented Oct 4, 2026

Copy link
Copy Markdown
Contributor

This PR does not merge. It is a subtraction on top of #2709 (fix/FIX-1663-closure). Fold it there, then close this unmerged.

Subtracted

  • Scratch-copy builds of Shift Manager go through buildShiftManagerCopy in goals/lib/shift-manager.mts. The closure still prints the unified diff of each patch.
  • The Lab route client is that module's labApi, plus holds. items with no type list still returns every item; a type list still sends item_types. ownerOf and requestStatus were never called.
  • The no-theme swap build calls buildPages (stripTheme) from its child process. The Vite swap plugin is no longer pasted into a generated script.

The start script stays in the closure. It opens --team or --config, an optional --shift, a fresh DevTeam sqlite, and the devtool URL, and it does not restore NODE_ENV the way the shared starter does.

Scratch patch builds no longer pass an empty __STATIC_SEATS__ define. That name is only read by a swapped control module, and a patch build does not swap.

What still passes

  • A typed items query is item_types=message,tool. An omitted type list is include_items=true with no item_types. holds still reads message items. ownerOf and requestStatus are gone.
  • A scratch patch that removes the design-system import from src/styles.css builds, and the report diff is the removal of that line.
  • A child process that swaps src/lib/reads.ts for the static-names control and sets stripTheme builds. The CSS does not contain the theme font (Space Grotesk).

No changeset: goals/ is not a published package.

Open in Web View Automation 

claude and others added 21 commits October 2, 2026 04:46
Adds goals/shift-manager/a-lab-is-worked-through-one-skinned-shell: legs
a, b0, b and c over DevForce and the pentest Lab, the six controls,
journeys J3 and J4, every child's check (part 3) and the gap sweep
(part 4), with its verdict log from a run on c29aafa. The run has
findings, recorded in the verdict log; none is fixed here.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
The control removes the send on both trees (PLAN Controls), which since
FIX-1690 means send.ts as well as transcript.ts; a swap may now name
several target files.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
The earlier findings are fixed: b0, part 4 and all six controls now hold.
One new finding is recorded: a4 refused 15 s into a run whose harness had
not yet confirmed its session, and a2 drew nothing live from the running
task's Session. Nothing is fixed here.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…'s (FIX-1663)

An in-process vite.build() sets NODE_ENV=production and leaves it set, so
P3.1's vitest child resolved node: built-ins to Vite's browser stub and failed
with 'fileURLToPath is not a function' whenever pages were built first.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…ols; each DevTeam start on a fresh store

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…rol at its renamed signal

FIX-1737 C renamed the child's signal to "an answer from the Stream lands in the store" (its goal.md names it so).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…37738)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
NavIcon's <svg> left fill at its default, so its computed fill was #000000
and it-takes-its-look-from-the-design-system counted it as a stray. The
icons are line icons: fill none, stroke currentColor and the stroke width
now sit on the <svg>, as the registry's lucide icons set them.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
… it reaches a row from Tasks

Since FIX-1737 D, Tasks hides queued rows until the Queued toggle is on, so
reach() could not click the unclaimed row. It now turns the toggle on, as a
person looking for any open row would.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…mbers off the tree

The fan-out's expected skips came from a hardcoded member list, which missed
the chief-of-staff seat FIX-1718 added to the board's channel. They now come
from the board channel's CHANNEL.md, through the roster the lab opened.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
Projects shipped (dfa9f46), so the project level no longer draws four
placeholder empty states. a3, b's and c's reach now open No project and each
of the store's projects, read through the Lab's routes: No project's Stream
and Brief show their named empty states, its Board's lanes and Workstreams
list are the workstreams no project lists; a project's Stream is its room
(or Join, or members only), its Board one lane per listed workstream holding
a board with the store's rows, its Workstreams the row's list and its Brief
the row's brief. J4 opens /p/unassigned's four tabs at their new surfaces.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
FIX-1737 C draws a member's pending ask in the feed as feed-ask; the
stream-asks list is gone, so a1 found no card in the workstream's stream.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…its card

Since FIX-1737 D, Inbox's detail draws the ask's question as its heading and
hands the card the ask without it, while the Stream's card carries the
question itself. a1 compared the two cards' text alone, so they always
differed. It now requires the Stream's card to say the detail's question,
and the rest of it to equal the detail's card.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…90545)

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
Decided for the closure: an ask with no workstream session belongs to every
channel the seat is a member of, because BR-18 draws its card on each of
those Streams. a1 now reads the set from the store (the ask's parent channel
when a post started it, else the seat's memberships), requires Inbox to name
exactly that set, and checks the card on each of those Streams.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…inned to the room kind

Decided for the closure: lib/talk.ts's sendAction (a project room's read,
post and join, FIX-1718) and lib/reads.ts's createSession (the person's room
session, FIX-1718 and FIX-1752) write only to the person's own sessions on
the channel kind, never a worker's. Part 4 allows them only so: talk.ts sends
once, through runTalkAction, for read, post or join; every room call passes
ROOM_KIND; every createSession in reads.ts is on ROOM_KIND. ER-15's row in
the epic's business rules lists the two.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…am opens

The excerpt said stores: inMemoryStores(), while the devteam profile opens
sqliteStores({ filename: STORE }).

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
…d0265): PASS

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
Patch builds and the Lab route client call goals/lib/shift-manager.mts.
The no-theme swap build calls that same build instead of pasting the Vite plugin.

Co-authored-by: Jake Hoffner <jhoffner@users.noreply.github.com>
@vercel

vercel Bot commented Oct 4, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

3 Skipped Deployments
Project Deployment Actions Updated
flow-state-dev-docs Ignored Ignored Oct 4, 2026 5:48am UTC
flow-state-dev-kitchen-sink Ignored Ignored Oct 4, 2026 5:48am UTC
flow-state-dev-ui Ignored Ignored Oct 4, 2026 5:48am UTC

Request Review

@linear-code

linear-code Bot commented Oct 4, 2026

Copy link
Copy Markdown

FIX-1663

jhoffner pushed a commit that referenced this pull request Oct 4, 2026
…d Shift Manager helper

Folds in the subtraction from POC #2711 (34d0034), which will not merge:

- Patch builds go through buildShiftManagerCopy (goals/lib/shift-manager.mts);
  the report still prints each patched file's unified diff.
- labApi is the shared route client plus `holds`. The shared `items` now takes
  an optional type list: given, it still sends item_types; omitted, it returns
  every item.
- The no-theme swap child calls buildPages with stripTheme instead of carrying
  its own copy of the Vite plugins.
- ownerOf and requestStatus, which nothing called, are gone.
- The start script stays the closure's own: --team or --config, an optional
  --shift, a fresh DevTeam sqlite, the devtool URL, no NODE_ENV restore.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq

jhoffner commented Oct 4, 2026

Copy link
Copy Markdown
Collaborator

Folded into #2709 at 0144486; closing unmerged.


Generated by Claude Code

@jhoffner jhoffner closed this Oct 4, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants