Repository navigation
spec(epic): FIX-1649 wrap, the path as shipped and leg c as the closure checks it - #2714
Conversation
… the closure checks it Redraw figures/path.svg from the merged PRs, 30 Sep to 4 Oct: every child that landed, the v2-look slices of FIX-1737 and the late fixes FIX-1730..1736, 1747, 1749, with the closure's runs and the critical path through design v2. Reconcile leg c in SPEC, BUSINESS-RULES (ER-13) and PLAN with FIX-1663's goal check: the sweep is the registry cards Shift Manager draws plus the devtool page (c:sweep), hardcoded-accent fails at c:tool alone, worker-session may reach c:sweep, and the static half is c:static. EVOLUTION records the closure's two calls: Inbox's workstreams per BR-18 (a1 reads its set from the store) and ER-15's room-kind allowance for sendAction( in lib/talk.ts and createSession( in lib/reads.ts, already listed in ER-15 and not repeated. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look + architecture pass (read-only; notes for the implementing agent)Verdict: the approach is right. No better shape; nothing here is an opening for a refactor. A post-closure spec amendment that records what the goal check actually runs is the lean option. The alternative is leaving SPEC/ER-13 describing a leg c that no longer exists. I checked the claims against the repo at
Worth fixing (small)
Notes, no action needed
Architecture (improve-codebase-architecture lens)Spec-only diff ( No blocking findings. Generated by Claude Code |
There was a problem hiding this comment.
/simplify review — FIX-1649 wrap spec
Verdict: Direction looks right; I would not block merge on architecture. The wrap amendment table, path redraw, and closure→epic backfill match how other epics in this repo handle terminal state. The main simplify opportunity is less duplication, not a different story.
What works
- EVOLUTION as the amendment ledger (leg c sweep narrowed,
hardcoded-accentatc:tool, Inbox multi-channel reading, ER-15 room writes) is the right place for “why we changed intent after shipping.” - Redrawing
path.svgto “as shipped” is consistent with the epic-spec template: the path updates on scope/dependency changes; wrap is the natural terminal update. - Pointing leg c at what Shift Manager actually draws (registry cards + devtool, not react chrome) fixes real drift between pre-build spec and shipped app — that amendment is necessary.
Where the approach went further than needed
-
Two sources of truth for leg c — EVOLUTION says
goal.md+legs.mtsare canonical, but SPEC (Signal row, sweep block, mermaid) and ER-13 now repeat signal IDs, part lists, and control coupling. Leg d already delegates togoals/shift-manager/it-draws-v2s-look/; legs a–c could follow the same pattern.Cleaner alternative (same semantics, smaller diff): EVOLUTION + path + minimal SPEC fold (“closure passed on
01444863c; checks: FIX-1663 goal”) + ER-13 withoutc:tooljargon. Keep sweep/control detail in the goal tree only. -
Path narrative copied ~4× — PLAN image alt,
path.svgaria-label, PLAN prose, and SVG footer text all carry the full timeline. That’s the highest ongoing maintenance cost in this PR (hand-edited pixel Gantt), not SVG byte size.Cleaner alternative: Short alt/aria (“date Gantt; detail in PLAN §The path”); one prose paragraph in PLAN; SVG = geometry + lane labels only. If you need a generator later, consider Mermaid gantt or exporting from a tool — not required for this merge.
-
Stale pre-ship line at wrap — “Today’s
main: legs a, b and d fail…” is misleading after #2709 merged. Drop or rephrase (“pre–Shift Manager merge” / controltoday's-mainonly).
Skipped (judgment call, not simplify-in-diff)
- Whether the frozen 2026-09-30 set table should gain a “closed” row — EVOLUTION already says live state is Linear; a separate editorial pass.
- Whether ER-15 bullets belong in BUSINESS-RULES vs evolution-only — both are defensible; I’d pick one normative home.
Checks
Spec-only PR; no code tests run. Subagent pass: code-quality + reuse reviewers aligned on duplication; performance reviewer flagged maintainability only.
Happy to approve a follow-up that thins SPEC/ER-13, or this PR after the “Today’s main” fix if you want that corrected before merge.
Sent by Cursor Automation: Review For Best Approach
…ne home SPEC's Signal cell is one line per leg, with leg c linked to the closure's goal.md as leg d links to it-draws-v2s-look; the sweep block is one sentence; the today's-main clause is scoped to that control on a pre-Shift-Manager commit. ER-13 points at FIX-1663's goal check instead of naming c:* signals. EVOLUTION's wrap rows keep the why and end at the SPEC goal section plus goal.md; the ER-15 row links to the rule in BUSINESS-RULES. path.svg's aria-label and PLAN's alt are short; the timeline lives in one PLAN paragraph. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: b4d0197c75
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d, the plan historicized EVOLUTION's Inbox row now says what shipped: BR-18's asksFor() draws an ask on every channel that has its seat, and Inbox names a post-started ask's parent channel only. a1 reads Inbox's set, so for a post-started ask it proves the parent Stream only; checking every member Stream is an open follow-up for the goals/lib helper fold. PLAN's "Where it is" and "What unblocks what, from here" become what happened. Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq


Wrap amendment to the retained FIX-1649 epic spec, opened after the epic's work finished. The closure, FIX-1663 (#2709,
894c418d2), passed on01444863cwith every control right. This PR changes onlyspecs/epics/FIX-1649/. The original review record stays #2421.What changes
1. The path as it actually shipped.
figures/path.svgused to show the 30 September plan as phases. It now has one lane per issue or group, dated 30 Sep to 4 Oct, each bar running from when the issue was filed (or the gate) to when it merged. The lanes cover the first build, closure run 1's fixes, FIX-1690, design v2, FIX-1722, 1723 and 1725, the late fixes (FIX-1730 to 1735, 1747, 1749), FIX-1736, FIX-1737's four slices, FIX-1650's inputs, and the closure's runs until one was clean.The longest wait was v2's look, not the shell: the structure merged on day one.
2. The closure's goal check is now the one home for how legs a to c are checked, the way
it-draws-v2s-look/already is for leg d. The goal check isgoals/shift-manager/a-lab-is-worked-through-one-skinned-shell/goal.mdandlegs.mts.3. Two closure decisions recorded in EVOLUTION.
sendAction(inlib/talk.tsfor the room kind's read, post and join, andcreateSession(inlib/reads.tsfor the room kind. ER-15 already lists both writes, so they are linked, not repeated.Reviewers · look here
Not changed: the 30 September set table, the box figure (it still draws react chrome as composed in), and D2's card.
Verify: fences balanced, no unquoted risky mermaid labels, every SVG self-contained with both themes and an aria-label, every referenced figure exists. The path was rendered and checked in light and dark.
🤖 Generated with Claude Code
https://claude.ai/code/session_01Cnm5DbhFmkarpesBpPQ9Dq
Generated by Claude Code