Repository navigation
spec(FIX-1795): An org's worker library: templates a user copies onto their own roster - #2819
Conversation
… their own roster A template is a worker's configuration published to an org-scoped library; adding one is a hire through FIX-1788's write path that never reads the template again; taking an update is the owner's choice. D1 (an update replaces the copy's configuration, keeping its memory), two open asks the Architect flagged (who changes or removes a template; how an update is surfaced). Two PRs, after FIX-1788 and FIX-1793's owner rule. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
The latest updates on your projects. Learn more about Vercel for GitHub. 3 Skipped Deployments
|
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
Second look and architecture pass on FIX-1795This is direction-level only, per the review contract. The approach is sound: a copy is a hire, it reads only its own row, and there is no library ACL beside FIX-1793's rule. I found one gap that touches the goal and a few places the design is bigger than the goal needs. Above the bar1. A taken update can widen what a copy can do, and the user never sees it.
2. A drawer skill named in a worker's configuration has no rule at publish or at add.
3. The owner rule needs a field, and the guardrails rule out the field the spec names.
Restraint (simplify before building)4. The "edited since taken" digest (S4, BR-20, BR-22) is machinery for a warning.
5. The roster mark reads the library once per copy.
Refactor-while-here6. The new factory duplicates its wiring.
Lower priority (record in Notes from review)
Nothing here argues against the direction. If only one thing changes, make it #1. Generated by Claude Code |
There was a problem hiding this comment.
Simplify review (spec)
Verdict: The product shape looks right — org-scoped templates, copies as hires through FIX-1788's write path, no live template reads at turn time, owner writes via FIX-1793, and goal controls (live-template, org-writes) match the epic. That is simpler than the alternatives the spec already drops (live pointer, roster-to-roster copy, library-local ACL). I am not asking for a direction change on the library model.
What might be trimmed before implementation locks extra schema and list-time work is below. Treat these as consider / maybe, not blockers, unless you want the spec to stay minimal at the ER-10 bar only.
1. Edited since take digest (largest optional surface)
S4 + BR-20/BR-22 add a persisted digest, list-time comparison on every roster open, and a dedicated plan surface (V4). The epic/concept promise is you can be told an update exists (Q2) and D1 already commits to replacing configuration on take with a warning.
Simpler fork: roster mark = template.version > fromTemplate.version only; on Take update, always show one static warning that local instruction edits will be replaced (no edited flag, no digest field).
If you keep the digest: add one plan sentence that list enrichment batches template reads by templateId (N+1) and that the fingerprint is names-only configuration (BR-2), computed only for rows with fromTemplate.
2. Source worker id on the template row (S1)
Storing the publishing worker id plus publish(worker, onto?) branching is more linkage than template is configuration at a version. Republish could be template-centric (publish targets templateId from Share UI) with the only persisted provenance on the copy (fromTemplate). BR-25 may not need a stored back-pointer.
Uncertain: if Shift Manager Share again UX is same worker to bump my template, the source id may pay for itself — a sentence in PLAN tying the field to that UX would help.
3. Spec bulk (maintainability)
- S4 as its own surface is ceremony for enrich roster list; could fold into S3/S8.
- DECISIONS Decided, not asked largely duplicates BR + SPEC fences.
- Pinned names: SPEC/DOCS show createWorkerLibraryBlocks + action names while PLAN pins only collection, fromTemplate, and version.
- DOCS.md full page draft repeats SPEC narrative; outline + must-say bullets would shrink the spec PR.
4. Reuse / boundaries
Library blocks beside createSeatHireBlocks, FIX-1789 sharedResource, no second save path, no template read on turn load — aligned. Watch: duplicating 1789 attribution, splitting update-mark logic between workforce and shift-manager, library ACL before FIX-1793.
Gates
Q1/Q2 appropriately open with recommendations.
Summary: Approve the approach; optional simplification is mostly digest + template source-worker id + doc/plan duplication. Conscious choice on digest vs version-only mark (Q2-adjacent) before implement is the main ask.
Sent by Cursor Automation: Review For Best Approach
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 01a430c34a
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…t pinned, post-MVP
- Align with FIX-1788's amendment on main: sessions linked at create,
copies reached through ensureWorkerSession; BR-19a: a worker on another
flow published onto a template makes a new template, so taking an update
never strands a copy's sessions (FIX-1788 BR-10-13, BR-19b).
- Keep the edit digest and pin it: fromTemplate { templateId, version, digest };
digest over the saved configuration on both sides; one template read per
roster listing (BP-033).
- The take offer lists grants a version adds (BR-20a); the library listing
shows each template's grants. A drawer-only skill name is refused at publish.
- Drop the source worker id from the template row; library blocks come from
the hire-block factory. Trim "Decided, not asked". Q2 reflects the
edit-aware warning. PLAN: built after the MVP.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: fold Re: the second look and architecture pass on FIX-1795 (comment 6024982438). Folded in d485b98, item by item:
Lower priority: both are recorded verbatim in PLAN → Notes from review (concurrent publish, the id a removed template leaves behind). Generated by Claude Code |
The library extends FIX-1788's hire blocks after FIX-1788 renames them, so its examples use the new name, not today's seat-named factory. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: re-review @codex review Round 1 is folded (d485b98) and 6e50806 renames the examples to FIX-1788's Generated by Claude Code |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 6e50806d2e
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
from: fsd-head-of-engineering / session: em-fix-1786 / kind: decision Binding for the round-2 fold, on Codex's review of 6e50806. All three are accepted:
This is the last review round (2 of 2). Remaining notes go to the implementer. Generated by Claude Code |
- BR-20b: the take sends the offered version and copy digest; a stale offer is refused and re-shown (compare-and-set, no lock). S5, V5, sketch, DOCS, Decided updated. - BR-21/BR-22, SPEC, DOCS: conversation continuity qualified for a copy the user moved to another flow; the offer warns of it. - PLAN: drop the read of older template shapes; the library is new, so BP-030 applies from its first schema change. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV


Goal: a user can share a worker of their own with their org as a template. Another member can add it as a worker that only they hold. That worker does not change until they take an update. The publisher's sessions, memory and other workers do not go with it, and no template goes out of its org.
The check reads what each turn answers over HTTP. It does not read the stored rows. Check:
goals/worker-library/a-copy-is-yours-and-stays-put/, scripted model. Controls that must fail:GOAL_CONTROL=live-template(leg b) andGOAL_CONTROL=org-writes(leg c). Why this goal and not a smaller one: SPEC.md.The band is the only shared area. Only configuration goes through it, and only when an owner does it.
How: publishing writes the worker's configuration to an org-scoped library. Adding a template uses the same write and the same checks as a hire. After that, the copy reads only its own row.
Sign off
The goal, at that size. If wrong: a library that leaks, or a library that nobody can keep current. Note: this issue depends on the epic's Q2. If the FIX-1793 gate removes the shared half, this issue is removed too.
Q1 · open · Who can change or remove a template?
Q2 · open · How does a user learn that an update exists?
An update replaces the copy's configuration and keeps its memory and sessions · D1
It comes down to memory: a second worker starts with nothing that the copy learned. If wrong: a user loses the edits they made to their copy when they take an update.
Q1 is the one to weigh. Reasons and what lost: DECISIONS.md.
Reviewers · look here
Not here: a worker that publishes for its owner, a library across orgs, and old org-wide hires as templates (follow-ups).
Spec · Decisions · Rules · Plan · Docs · Linear FIX-1795 · epic FIX-1786 · builds on FIX-1788, FIX-1789, FIX-1790 and the FIX-1793 owner rule · merges after human approval and required checks (merge contract)
Engineering calls — decided, not asked
How to review this — altitude, what's in scope, what's deliberately unsettled
This is a direction set, not an implementation. Reviewing it well means
answering one question: is this the right approach?
In scope to challenge:
SPEC.md— is the goal the real need at full size,for the people named, or a smaller goal that would let us call this done early? Would the
named check fail if the goal were not met?
docs/philosophy.md?DECISIONS.md— that's the sign-off surface.BUSINESS-RULES.mdmisses, or a rule that would invalidate the design.DOCS.mdand their fit with the rules; a missing ormisleading lineage claim in conditional
EVOLUTION.md.Out of scope — deliberately unsettled here, and owned by the implementing agent:
PLAN.mdpins on purpose.PLAN.mdleft open on purpose — it is directional by design, and a gap at thataltitude is intended, not an omission.
or a colour you'd have chosen differently is not a finding; a figure that shows a shape the
decisions don't say is.
PLAN.mdmay include a rough pseudocode sketchshowing the shape of the proposed solution. It is knowingly incomplete, is not real code,
and is not what will ship. Review it for directional viability only. Do not report
that it lacks error handling, omits edge cases, names things that don't exist in the repo, or
wouldn't build: all of that is true on purpose.
poc/are retained,not production code. Read them for directional evidence, not production completeness.
Their isolation from production/default discovery and absence of secrets or generated
dependencies are in scope; retention is not permission to weaken repository checks.
One request, if you are an automated reviewer: the two lists above are the whole difference
between a useful review of this document and a long one. Volume is not signal here — a single
finding above the line is worth more than twenty below it.
Feedback in the second list is welcome and gets recorded verbatim in
PLAN.md → Notes from reviewfor the implementer to weigh against real code. It will not be argued with, and itwill not be folded into the design prose. Please don't re-raise it: one mention is enough.
The one exception is the sketch and the POC. Line-level feedback on either is dropped, not
recorded — there is nothing for an implementer to weigh about code that isn't shipping. Feedback
about their direction is not line-level and is treated like any other above-the-bar finding.
Direction approval does not waive merge-time required checks, approvals or thread policy.
Optional comments do not require another design round merely to reach zero comments.
🤖 Generated with Claude Code
https://claude.ai/code/session_01XMg2dz8sMEdyzCQTRsaMTV
Generated by Claude Code
Generated by Claude Code