Skip to content

feat(core): add combiner helper factory - #29

Merged
jhoffner merged 2 commits into
mainfrom
codex/linear-mention-fix-79-core-helper-combiner
Mar 3, 2026
Merged

jhoffner merged 2 commits into
mainfrom
codex/linear-mention-fix-79-core-helper-combiner

Conversation

@jhoffner

@jhoffner jhoffner commented Mar 3, 2026

Copy link
Copy Markdown
Collaborator

Motivation

  • Provide a simple, composable helper that deterministically merges multiple artifacts into a normalized structure with minimal reinterpretation and a stable default output shape.
  • Offer a typed factory consistent with existing core helpers that can be used inside sequencers and other composition patterns.

Description

  • Add packages/core/src/helpers/combiner.ts which implements combiner(config) returning a standard handler block and a default output schema { combined, mergeNotes? }.
  • Implement deterministic merge rules: object merges recurse by key, arrays are concatenated with stable deduplication, scalar/type conflicts resolve by taking the later artifact, and mixed-type inputs are normalized by order + dedupe.
  • Export the helper and its types from packages/core/src/helpers/index.ts and document the new helper.combiner(config) entry in packages/core/README.md.
  • Add packages/core/test/combiner.test.ts with unit tests covering object overlap/conflicts, array deduplication, mixed-type normalization, schema override, and composition inside a sequencer.

Testing

  • Ran targeted unit tests with pnpm --filter @flow-state-dev/core test -- combiner.test.ts summarizer.test.ts and the test suite completed successfully (tests passed).
  • Ran type checking with pnpm --filter @flow-state-dev/core typecheck and it completed without errors.
  • The new combiner tests validate merging behavior, schema override acceptance, and sequencer composability and all assertions passed.

Codex Task

@vercel

vercel Bot commented Mar 3, 2026 •

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
flow-state-dev-docs Ready Ready Preview, Comment Mar 3, 2026 6:37pm
flow-state-dev-kitchen-sink Ready Ready Preview, Comment Mar 3, 2026 6:37pm

@linear

linear Bot commented Mar 3, 2026

Copy link
Copy Markdown

@chatgpt-codex-connector

Copy link
Copy Markdown

You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard.
To continue using code reviews, you can upgrade your account or add credits to your account and enable them for code reviews in your settings.

This branch was successfully deployed

2 active deployments
Preview – flow-state-dev-kitchen-sink — 3b97656e Deployed Mar 3, 2026 by vercel[bot]
Preview – flow-state-dev-docs — 3b97656e Deployed Mar 3, 2026 by vercel[bot]
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant